anchao merged PR #15971:
URL: https://github.com/apache/nuttx/pull/15971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach
tmedicci commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2732548756
> > Thanks for submitting. It helps booting the device, but still gives
wrong results. I attached two logs, one with the content of this PR and the
other with building #15997 .
[trace_v
anchao commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2731334540
> Thanks for submitting. It helps booting the device, but still gives wrong
results. I attached two logs, one with the content of this PR and the other
with building #15997 .
[trace_v
tmedicci commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2730549101
> > > > I tried this change before the one I've suggested (and the device
still halts). Either way, the functions that are part of the instrumentation
itself should not be instrumented (
anchao commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2727223541
> > > I tried this change before the one I've suggested (and the device
still halts). Either way, the functions that are part of the instrumentation
itself should not be instrumented (the
tmedicci commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2725372135
> maybe we can use the same variable in "`instr_level`" and call
`atomic_fetch_sub ` to subtract the count in `__cyg_profile_func_exit()`
>
> ```
> __cyg_profile_func_enter
>
tmedicci commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2726569771
> > I tried this change before the one I've suggested (and the device still
halts). Either way, the functions that are part of the instrumentation itself
should not be instrumented (the
anchao commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2725035884
maybe we can use the same variable in "`instr_level`" and call
`atomic_fetch_sub ` to subtract the count in `__cyg_profile_func_exit()`
```
__cyg_profile_func_enter
->atomi
tmedicci commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2724888394
> > > > @xiaoxiang781216 @anjiahao1 I think the correct solution should be
to add a nesting counter in the instrument hook to avoid recursion.
poll_notify() can only solve the current pr
anchao commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2721466557
> > > @xiaoxiang781216 @anjiahao1 I think the correct solution should be to
add a nesting counter in the instrument hook to avoid recursion. poll_notify()
can only solve the current proble
tmedicci commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2721294472
> > @xiaoxiang781216 @anjiahao1 I think the correct solution should be to
add a nesting counter in the instrument hook to avoid recursion. poll_notify()
can only solve the current proble
tmedicci commented on PR #15971:
URL: https://github.com/apache/nuttx/pull/15971#issuecomment-2721000742
> @xiaoxiang781216 @anjiahao1 I think the correct solution should be to add
a nesting counter in the instrument hook to avoid recursion. poll_notify() can
only solve the current problem.
tmedicci opened a new pull request, #15971:
URL: https://github.com/apache/nuttx/pull/15971
## Summary
* fs/vfs/fs_poll: Add noinstrument_function to poll_notify function
Add the noinstrument_function attribute to the poll_notify function to avoid
it looping if -finstrument-fun
13 matches
Mail list logo
