yamt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2791477503
> > > > > Any reason there isn't a sync in
[`littlefs_truncate`](https://github.com/apache/nuttx/blob/90e9b2426d54682070b0fcc38ad5415bbf77f733/fs/littlefs/lfs_vfs.c#L929),
> > > >
> > >
liamHowatt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2791608100
For some reason I did not notice that it syncs for all opens, not just
O_TRUNC opens. The current code comment made my eyes see a `if (oflags &
LFS_O_TRUNC)`, but there isn't.
--
This
yamt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2774250147
> > @xiaoxiang781216 can you explain
> >
> > * why O_TRUNC should be immediately committed
>
> If the storage is near exhausted, the next write will fail without commit.
is
xiaoxiang781216 commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2774226026
> @xiaoxiang781216 can you explain
>
> * why O_TRUNC should be immediately committed
If the storage is near exhausted, the next write will fail without commit.
>
yamt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2780186256
> > > > Any reason there isn't a sync in
[`littlefs_truncate`](https://github.com/apache/nuttx/blob/90e9b2426d54682070b0fcc38ad5415bbf77f733/fs/littlefs/lfs_vfs.c#L929),
> > >
> > >
xiaoxiang781216 commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2780170759
> > > Any reason there isn't a sync in
[`littlefs_truncate`](https://github.com/apache/nuttx/blob/90e9b2426d54682070b0fcc38ad5415bbf77f733/fs/littlefs/lfs_vfs.c#L929),
> >
> >
yamt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2777379683
> > Any reason there isn't a sync in
[`littlefs_truncate`](https://github.com/apache/nuttx/blob/90e9b2426d54682070b0fcc38ad5415bbf77f733/fs/littlefs/lfs_vfs.c#L929),
>
> good idea, patch
xiaoxiang781216 commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2775614932
> Any reason there isn't a sync in
[`littlefs_truncate`](https://github.com/apache/nuttx/blob/90e9b2426d54682070b0fcc38ad5415bbf77f733/fs/littlefs/lfs_vfs.c#L929),
good idea,
liamHowatt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2774961465
Any reason there isn't a sync in
[`littlefs_truncate`](https://github.com/apache/nuttx/blob/90e9b2426d54682070b0fcc38ad5415bbf77f733/fs/littlefs/lfs_vfs.c#L929),
then? The woraround for
yamt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2774437272
> > > > @xiaoxiang781216 can you explain
> > > >
> > > > * why O_TRUNC should be immediately committed
> > >
> > >
> > > If the storage is near exhausted, the next write will f
xiaoxiang781216 commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2774411385
> > > @xiaoxiang781216 can you explain
> > >
> > > * why O_TRUNC should be immediately committed
> >
> >
> > If the storage is near exhausted, the next write will fa
yamt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2774137541
@xiaoxiang781216
can you explain
* why O_TRUNC should be immediately committed
* why you don't need to check errors from lfs_file_sync
* why this needs to be fixed here (not in litt
liamHowatt commented on PR #2913:
URL: https://github.com/apache/nuttx/pull/2913#issuecomment-2773686018
I think it goes against user expectations. A user reading and rewriting a
file in a context where power can fail could find the file empty after a
power-up. LittleFS is advertised as mai
13 matches
Mail list logo
