Re: [PR] fix some comment in https://github.com/apache/nuttx/pull/14764 [nuttx]

2024-11-19 Thread via GitHub
xiaoxiang781216 merged PR #14837: URL: https://github.com/apache/nuttx/pull/14837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] fix some comment in https://github.com/apache/nuttx/pull/14764 [nuttx]

2024-11-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #14837: URL: https://github.com/apache/nuttx/pull/14837#discussion_r1847493893 ## mm/iob/iob_free.c: ## @@ -141,59 +141,34 @@ FAR struct iob_s *iob_free(FAR struct iob_s *iob) * cases. */ -#if CONFIG_IOB_THROTTLE > 0 - if ((g_io

Re: [PR] fix some comment in https://github.com/apache/nuttx/pull/14764 [nuttx]

2024-11-18 Thread via GitHub
hujun260 commented on PR #14837: URL: https://github.com/apache/nuttx/pull/14837#issuecomment-2484484414 > @hujun260 I think you are doing more than just fix some comments, please update the commit log message to explain the modifications you are proposing here. ok -- This is an a

Re: [PR] fix some comment in https://github.com/apache/nuttx/pull/14764 [nuttx]

2024-11-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #14837: URL: https://github.com/apache/nuttx/pull/14837#discussion_r1846608167 ## mm/iob/iob_statistics.c: ## @@ -68,7 +68,7 @@ void iob_getstats(FAR struct iob_stats_s *stats) } #if CONFIG_IOB_THROTTLE > 0 - stats->nthrottle = g_

Re: [PR] fix some comment in https://github.com/apache/nuttx/pull/14764 [nuttx]

2024-11-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #14837: URL: https://github.com/apache/nuttx/pull/14837#discussion_r1846407874 ## mm/iob/iob_alloc.c: ## @@ -105,20 +105,9 @@ static FAR struct iob_s *iob_tryalloc_internal(bool throttled) { FAR struct iob_s *iob; #if CONFIG_IOB_THRO

Re: [PR] fix some comment in https://github.com/apache/nuttx/pull/14764 [nuttx]

2024-11-18 Thread via GitHub
nuttxpr commented on PR #14837: URL: https://github.com/apache/nuttx/pull/14837#issuecomment-2482300285 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] fix some comment in https://github.com/apache/nuttx/pull/14764 [nuttx]

2024-11-18 Thread via GitHub
hujun260 opened a new pull request, #14837: URL: https://github.com/apache/nuttx/pull/14837 ## Summary mm/iob: fix some comment in https://github.com/apache/nuttx/pull/14764 ## Impact iob ## Testing iob test -- This is an automated message from the Apach