xiaoxiang781216 merged PR #15855:
URL: https://github.com/apache/nuttx/pull/15855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
tim-sony commented on PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2670521721
> CI is ok, all good.
Thank you so much! @fdcavalcanti
Let's wait for our maintainers to take a final look.
--
This is an automated message from the Apache Git Service.
To respon
fdcavalcanti commented on PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2669031178
CI is ok, all good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
fdcavalcanti commented on PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2668325731
> > Please run a sanity check on S2. If you don't have one available I can
trigger internal CI so we can be sure.
>
> Thanks for your comment, @fdcavalcanti! Since we don't hav
tim-sony commented on PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2667373132
> Please run a sanity check on S2. If you don't have one available I can
trigger internal CI so we can be sure.
Thanks for your comment, @fdcavalcanti! Since we don't have an S2 b
fdcavalcanti commented on PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2665492304
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
tim-sony commented on code in PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#discussion_r1959306469
##
arch/xtensa/src/esp32s2/esp32s2_start.c:
##
@@ -404,7 +404,13 @@ static void noreturn_function IRAM_ATTR
__esp32s2_start(void)
else
{
esp_spiram_ini
tim-sony commented on code in PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#discussion_r1959306469
##
arch/xtensa/src/esp32s2/esp32s2_start.c:
##
@@ -404,7 +404,13 @@ static void noreturn_function IRAM_ATTR
__esp32s2_start(void)
else
{
esp_spiram_ini
sdc-g commented on code in PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#discussion_r1959211389
##
arch/xtensa/src/esp32s2/esp32s2_start.c:
##
@@ -404,7 +404,13 @@ static void noreturn_function IRAM_ATTR
__esp32s2_start(void)
else
{
esp_spiram_init_c
nuttxpr commented on PR #15855:
URL: https://github.com/apache/nuttx/pull/15855#issuecomment-2664771979
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
Yes, this PR appears to mostly meet the NuttX requireme
tim-sony opened a new pull request, #15855:
URL: https://github.com/apache/nuttx/pull/15855
*Note: Please adhere to [Contributing
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
A trivial change. Considering the CONFIG item is from [the ESP
11 matches
Mail list logo
