xiaoxiang781216 commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2755405392
> > @jerpelea
> > > * SPDX-License-Identifier: Apache-2.0
> >
> >
> > Where should this go? In every file?
>
> every file that had a license ex:
https://git
xiaoxiang781216 merged PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
jerpelea commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2703303557
> @jerpelea
>
> > * SPDX-License-Identifier: Apache-2.0
>
> Where should this go? In every file?
every file that had a license
ex:
https://github.com/apache
maxikrie commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2701776282
> * SPDX-License-Identifier: Apache-2.0
Where should this go? In every file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
cederom commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2698884542
Thank you @maxikrie :-) Looks almost done... just a line to be removed from
a git commit message after signature (`git commit --amend`).. and we are ready
to go :-) THANKS!! :-)
```
acassis commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2669967804
> @cederom I am confused why there are again long line issues? I fixed them
previously and also ../nuttx/tools/checkpatch.sh -g HEAD~...HEAD doesn't
complain..
Please run checkp
cederom commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1962498715
##
examples/nimble_blecent/peer.c:
##
@@ -0,0 +1,926 @@
+/
+ * apps/examples/nimble_blece
maxikrie commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2669961868
@cederom I am confused why there are again long line issues? I fixed them
previously and also ../nuttx/tools/checkpatch.sh -g HEAD~...HEAD doesn't
complain..
--
This is an automat
cederom commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2649286019
Thank you @maxikrie, awesome work!! :-) Please squash so we have everything
bundled into one single commit with common description and we are ready to go
:-)
--
This is an automated
xiaoxiang781216 commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2646750362
@maxikrie please sqaush your patch into by git rebase --interactive HEAD~8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
maxikrie commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1947254062
##
examples/nimble_blecent/misc.c:
##
@@ -0,0 +1,243 @@
+/
+ * apps/examples/nimble_blec
maxikrie commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1947254360
##
examples/nimble_blecent/misc.c:
##
@@ -0,0 +1,210 @@
+/
+ * apps/examples/nimble_blec
cederom commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2623386622
ping @maxikrie :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lupyuen commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2582325441
@maxikrie Could you try rebasing with the latest `master` branch? The branch
looks rather old (Oct 30).
Also the CI Check seems to be running OK for the latest builds. Thanks!
raiden00pl commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2582278634
does anyone have any idea why CI is returning nxstyle errors unrelated to PR
content?
https://github.com/user-attachments/assets/5012fd41-a6ec-4836-8ebd-1ba758744002";
/>
raiden00pl commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1910138761
##
examples/nimble_bleprph/nimble_bleprph_main.c:
##
@@ -0,0 +1,447 @@
+/
+ * apps/exa
raiden00pl commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1910135097
##
examples/nimble_blecent/misc.c:
##
@@ -0,0 +1,243 @@
+/
+ * apps/examples/nimble_bl
raiden00pl commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1910132702
##
examples/nimble_blecent/misc.c:
##
@@ -0,0 +1,243 @@
+/
+ * apps/examples/nimble_bl
maxikrie commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2580704360
I am not sure, should I look into this? I am just checking since I didn't
touch these and they didn't appear to be an issue when I run the nxstyle tool.
I want to make sure this is no
cederom commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2579921130
Thank you @maxikrie :-)
Most of the formatting issues detected by CI are in the codebase already:
https://github.com/apache/nuttx-apps/actions/runs/12679172534/job/35340025084
maxikrie commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2579848178
I fixed the formatting issues and fixed an error in the Makefile (I
previously had only tested the CMake build), but there are again failed checks.
Can somebody check? I am not sure w
maxikrie commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1908559469
##
examples/nimble_blecent/Kconfig:
##
@@ -0,0 +1,30 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in th
maxikrie commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1907876555
##
examples/nimble_blecent/Kconfig:
##
@@ -0,0 +1,30 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in th
acassis commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2557145426
ping @maxikrie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
xiaoxiang781216 commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2495623420
> @cederom Is there a way to check whether my changes will pass the check
before committing? I read the documentation on
[pre-commit](https://nuttx.apache.org/docs/latest/contr
maxikrie commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2495446536
@cederom Is there a way to check whether my changes will pass the check
before committing? I read the documentation on
[pre-commi](https://nuttx.apache.org/docs/latest/contributing/co
cederom commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2453018597
Source code still needs reformat, @maxikrie please take a look at:
* https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
* https://nuttx.apache.org/docs/latest/contributin
cederom commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2453017957
CI checkpatch is now fixed, CI restarted :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
raiden00pl commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1826123562
##
examples/nimble_blecent/Kconfig:
##
@@ -0,0 +1,30 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in
raiden00pl commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2452311501
@maxikrie Mynewt The mynewt coding standard is far from the NuttX coding
standard, so the code will be a lot different anyway. Keeping 2 examples
demonstrating the same functionalit
maxikrie commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1826086880
##
examples/nimble_blecent/misc.c:
##
@@ -0,0 +1,210 @@
+/
+ * apps/examples/nimble_blec
maxikrie commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2452256092
> why not modify the current nimble peripheral example
(https://github.com/apache/nuttx-apps/blob/master/examples/nimble/nimble_main.c)?
do we need 2 different examples for this?
raiden00pl commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2449874312
why not modify the current nimble peripheral example
(https://github.com/apache/nuttx-apps/blob/master/examples/nimble/nimble_main.c)?
do we need 2 different examples for this?
--
acassis commented on code in PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#discussion_r1824453921
##
examples/nimble_blecent/misc.c:
##
@@ -0,0 +1,210 @@
+/
+ * apps/examples/nimble_blece
github-actions[bot] commented on PR #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807#issuecomment-2448632165
This PR exceeds the recommended size of 1000 lines. Please make sure you are
NOT addressing multiple issues with one PR. Note this PR might be rejected due
to its size.
maxikrie opened a new pull request, #2807:
URL: https://github.com/apache/nuttx-apps/pull/2807
## Summary
These example apps create a BLE central and peripheral based on
mynewt-nimBLE and work in companion. The apps are mostly based on their
equivalents, which can be found at
https://gi
36 matches
Mail list logo
