Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-08 Thread via GitHub
xiaoxiang781216 merged PR #15445: URL: https://github.com/apache/nuttx/pull/15445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-08 Thread via GitHub
yamt commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2577445871 > Yes, every test runs with debug assertion enabled. ok. thank you. i now dropped the assertion patch from this PR. -- This is an automated message from the Apache Git Service. To

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-08 Thread via GitHub
fdcavalcanti commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2577332380 Yes, every test runs with debug assertion enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-07 Thread via GitHub
yamt commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2576618884 > Got build failures on defconfigs `eth_lan9250,` `qemu_debug` and `qemu_openth`. Seems like the same error on CI. > > ``` > xtensa-esp32s3-elf-ld: /builds/idf/apache/incubator-nut

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-07 Thread via GitHub
fdcavalcanti commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2575121448 Got build failures on defconfigs `eth_lan9250,` `qemu_debug` and `qemu_openth`. Seems like the same error on CI. ``` xtensa-esp32s3-elf-ld: /builds/idf/apache/incubator-nuttx/s

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-07 Thread via GitHub
fdcavalcanti commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2575034753 Hi @yamt I'll run some tests and get back to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-06 Thread via GitHub
yamt commented on code in PR #15445: URL: https://github.com/apache/nuttx/pull/15445#discussion_r1905011198 ## net/utils/net_lock.c: ## @@ -135,6 +135,9 @@ _net_timedwait(FAR sem_t *sem, bool interruptible, unsigned int timeout) int net_lock(void) { + extern mutex_t g_wifi

Re: [PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-06 Thread via GitHub
yamt commented on PR #15445: URL: https://github.com/apache/nuttx/pull/15445#issuecomment-2574527891 i marked this a draft because i haven't tested this well. i will drop the assertion patch after testing. -- This is an automated message from the Apache Git Service. To respond to the me

[PR] esp32s3_wifi_adapter.c: Fix a deadlock [nuttx]

2025-01-06 Thread via GitHub
yamt opened a new pull request, #15445: URL: https://github.com/apache/nuttx/pull/15445 ## Summary esp32s3_wifi_adapter.c: Fix a deadlock Fixes: https://github.com/apache/nuttx/issues/15314 ## Impact ## Testing esp32s3-devkit:wifi -- This is an au