Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-19 Thread via GitHub
xiaoxiang781216 merged PR #10961: URL: https://github.com/apache/nuttx/pull/10961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-18 Thread via GitHub
xiaoxiang781216 commented on PR #10961: URL: https://github.com/apache/nuttx/pull/10961#issuecomment-1769091174 > Thank you @xiaoxiang781216 I applied temporarily your patch here just to confirm it will fix the issue. If the CI pass I remove this commit, apply your PR and rebase my PR with

Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-18 Thread via GitHub
acassis commented on PR #10961: URL: https://github.com/apache/nuttx/pull/10961#issuecomment-1769062014 Thank you @xiaoxiang781216 I applied temporarily your patch here just to confirm it will fix the issue. If the CI pass I remove this commit, apply your PR and rebase my PR with it. --

Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #10961: URL: https://github.com/apache/nuttx/pull/10961#discussion_r1364255949 ## net/route/net_del_ramroute.c: ## @@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg) net_ipv4_dumproute("Compa

Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #10961: URL: https://github.com/apache/nuttx/pull/10961#discussion_r1364152007 ## net/route/net_del_ramroute.c: ## @@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg) net_ipv4_dumproute("Compa

Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-18 Thread via GitHub
acassis commented on code in PR #10961: URL: https://github.com/apache/nuttx/pull/10961#discussion_r1364016806 ## net/route/net_del_ramroute.c: ## @@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg) net_ipv4_dumproute("Comparing", r

Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-17 Thread via GitHub
xiaoxiang781216 commented on code in PR #10961: URL: https://github.com/apache/nuttx/pull/10961#discussion_r1363325887 ## net/route/net_del_ramroute.c: ## @@ -91,7 +91,8 @@ static int net_match_ipv4(FAR struct net_route_ipv4_s *route, FAR void *arg) net_ipv4_dumproute("Compa

Re: [PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-17 Thread via GitHub
acassis commented on PR #10961: URL: https://github.com/apache/nuttx/pull/10961#issuecomment-1767322281 @xiaoxiang781216 the macro HTONL(match->target) is returning different types of integer depending on architecture and compiler. What should be the right fix here? -- This is an automat

[PR] esp32: Add wifishare board config and documentation [nuttx]

2023-10-17 Thread via GitHub
acassis opened a new pull request, #10961: URL: https://github.com/apache/nuttx/pull/10961 ## Summary esp32: Add wifishare board config and documentation ## Impact Users will be able to use ESP32 board as Access Point and Base Station at same time and share Internet connection! #