tmedicci commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2650775403
> Hi @tmedicci thanks for the merge.
>
> As I am new to NuttX I don't know all the rules, but should I have marked
this new feature as `EXPERIMENTAL`?
>
> I would like to fu
jerpelea commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2650165139
we should discuss on the dev mailing list
I will start a new thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Laczen commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2650157349
> > > > please split arch and documentation in separate PR if we try to
maintain LTS releases this is a requirement
> > >
> > >
> > > In this case, @jerpelea , It makes sense to
jerpelea commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2650102724
> > > please split arch and documentation in separate PR if we try to
maintain LTS releases this is a requirement
> >
> >
> > In this case, @jerpelea , It makes sense to keep t
Laczen commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2649829882
Hi @tmedicci thanks for the merge. As I am new to NuttX I don't know all the
rules, but should I have marked this new feature as `EXPERIMENTAL`?
I would like to further improve on it
tmedicci commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2649005513
> @Laczen just a heads up, if #15804 is merged first, when you rebase this
some things might require changes since I changed KConfig stuff for wireless.
I just merged it.
@L
tmedicci merged PR #15732:
URL: https://github.com/apache/nuttx/pull/15732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa
fdcavalcanti commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2648703848
@Laczen just a heads up, if #15804 is merged first, you might have too
change some things on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the
tmedicci commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2639796101
I think this PR can be merged as-is, right @jerpelea ?
4 reviewers, no request for changes...
--
This is an automated message from the Apache Git Service.
To respond to the messa
Laczen commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2639580599
> > please split arch and documentation in separate PR if we try to maintain
LTS releases this is a requirement
>
> In this case, @jerpelea , It makes sense to keep them in the same
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1944256977
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xtensa/sr
fdcavalcanti commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1942969310
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xte
fdcavalcanti commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1942969310
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xte
fdcavalcanti commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2636477188
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941765042
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xtensa/sr
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941763667
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/sr
tmedicci commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941580509
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/
tmedicci commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2634587976
> please split arch and documentation in separate PR if we try to maintain
LTS releases this is a requirement
In this case, @jerpelea , It makes sense to keep them in the same PR (
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941448200
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/sr
Laczen commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2634415725
> please split arch and documentation in separate PR if we try to maintain
LTS releases this is a requirement
Hi @jerpelea could you please help me how to do this correct taking into
jerpelea commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2634240488
please split arch and documentation in separate PR
if we try to maintain LTS releases this is a requirement
--
This is an automated message from the Apache Git Service.
To respond to
tmedicci commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941239393
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941203308
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xtensa/sr
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941186683
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/sr
tmedicci commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941143873
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1694 @@
+/
+ * arch/xtensa/
tmedicci commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941127259
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941042832
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/sr
tmedicci commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1941025723
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1940515857
##
arch/xtensa/src/esp32/esp32_espnow_pktradio.c:
##
@@ -0,0 +1,1696 @@
+/
+ * arch/xtensa/sr
Laczen commented on code in PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#discussion_r1940513537
##
arch/xtensa/src/esp32/Kconfig:
##
@@ -745,6 +745,99 @@ config ESP32_WIRELESS
---help---
Enable Wireless support
+config ESP32_ESPNOW_PKTRADI
fdcavalcanti commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2631032316
Please fix KConfig on this point, seems to be missing the node ID
description:
```
│ │ [*] ESPNOW packet radio support
fdcavalcanti commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2630572870
Please do not merge yet, still running tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tmedicci commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2627865261
Amazing work, @Laczen!
Congratulations.
Apart from the `defconfig`, can you improve the testing method with clear
instructions on how to build and test it (considering that
fdcavalcanti commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2627856099
Can you add a `defconfig` ready to use with this functionality? You can call
it `espnow`.
Also some documentation would be good. You can a brief description of this
to `Docume
fdcavalcanti commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2627848828
Hi @Laczen that's a great contribution!
Please improve the PR description.
I'll take a look and run some tests on it.
--
This is an automated message from the Apache Git Servi
nuttxpr commented on PR #15732:
URL: https://github.com/apache/nuttx/pull/15732#issuecomment-2627766490
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR description does not fully meet the NuttX r
Laczen opened a new pull request, #15732:
URL: https://github.com/apache/nuttx/pull/15732
## Summary
Espnow is a connectionless WiFi communication protocol that can be used to
exchange information between esp nodes.
## Impact
A espnow pktradio driver is proposed that all
37 matches
Mail list logo
