Re: [PR] drivers/sensor: add new sensot type to align android sensor type [nuttx]

2025-01-20 Thread via GitHub
Donny9 commented on code in PR #15610: URL: https://github.com/apache/nuttx/pull/15610#discussion_r1922962621 ## drivers/sensors/sht4x_uorb.c: ## @@ -875,7 +875,6 @@ int sht4x_register(FAR struct i2c_master_s *i2c, int devno, uint8_t addr) priv->hum.sensor_lower.ops = &g_s

Re: [PR] drivers/sensor: add new sensot type to align android sensor type [nuttx]

2025-01-20 Thread via GitHub
linguini1 commented on code in PR #15610: URL: https://github.com/apache/nuttx/pull/15610#discussion_r1922520678 ## drivers/sensors/sht4x_uorb.c: ## @@ -875,7 +875,6 @@ int sht4x_register(FAR struct i2c_master_s *i2c, int devno, uint8_t addr) priv->hum.sensor_lower.ops = &

Re: [PR] drivers/sensor: add new sensot type to align android sensor type [nuttx]

2025-01-20 Thread via GitHub
xiaoxiang781216 merged PR #15610: URL: https://github.com/apache/nuttx/pull/15610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] drivers/sensor: add new sensot type to align android sensor type [nuttx]

2025-01-20 Thread via GitHub
Donny9 commented on PR #15610: URL: https://github.com/apache/nuttx/pull/15610#issuecomment-2601776760 > @Donny9 Is there any advantage in compatibility with Android here? If so, maybe it's worth adding a note in `uorb.h` and Documentation that compatibility with Android is intentional and

Re: [PR] drivers/sensor: add new sensot type to align android sensor type [nuttx]

2025-01-20 Thread via GitHub
raiden00pl commented on PR #15610: URL: https://github.com/apache/nuttx/pull/15610#issuecomment-2601760193 @Donny9 Is there any advantage in compatibility with Android here? If so, maybe it's worth adding a note in `uorb.h` and Documentation that compatibility with Android is intentional an

Re: [PR] drivers/sensor: add new sensot type to align android sensor type [nuttx]

2025-01-19 Thread via GitHub
nuttxpr commented on PR #15610: URL: https://github.com/apache/nuttx/pull/15610#issuecomment-2601627782 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.