Re: [PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
anchao commented on PR #15594: URL: https://github.com/apache/nuttx/pull/15594#issuecomment-2599448469 @acassis please review again: https://github.com/apache/nuttx/pull/15596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
anchao commented on PR #15594: URL: https://github.com/apache/nuttx/pull/15594#issuecomment-2599439267 > I don't remember, but I remember using EXTRALIB flag sometime ago, hehehe @acassis here it is https://acassis.wordpress.com/2022/10/18/how-to-transform-warning-in-error-duri

Re: [PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
acassis merged PR #15594: URL: https://github.com/apache/nuttx/pull/15594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
acassis commented on PR #15594: URL: https://github.com/apache/nuttx/pull/15594#issuecomment-2599436769 > > @anchao does it also work for standard makefiles ? > > @acassis Makefiles already have this feature, but due to different backend implementations, makefile use EXTRAFLAGS to pas

Re: [PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
anchao commented on PR #15594: URL: https://github.com/apache/nuttx/pull/15594#issuecomment-2599406046 > @anchao does it also work for standard makefiles ? @acassis Makefiles already have this feature, but due to different backend implementations, makefile use EXTRAFLAGS to pass speci

Re: [PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
acassis commented on PR #15594: URL: https://github.com/apache/nuttx/pull/15594#issuecomment-2598685753 @anchao does it also work for standard makefiles ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
nuttxpr commented on PR #15594: URL: https://github.com/apache/nuttx/pull/15594#issuecomment-2598416233 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does *not* fully meet the NuttX requirements. W

[PR] cmake/mkconfig: add support of set custom command options to config.h [nuttx]

2025-01-17 Thread via GitHub
anchao opened a new pull request, #15594: URL: https://github.com/apache/nuttx/pull/15594 ## Summary cmake/mkconfig: add support of set custom command options to config.h add support of set custom command options to config.h Use the -D parameter to pass the config to header f