Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-24 Thread via GitHub
michallenc commented on PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097#issuecomment-3001448204 > It's irrelevant now but, for completeness, my use case is fine and still works OK. Thanks for the check! > I do wonder, though, if the the new `NXBOOT_PROGRESS` was a

Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-24 Thread via GitHub
TimJTi commented on PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097#issuecomment-2999896514 > Hopefully I won't find any issues when, next week as said, I test the default use-case of using the boot app rather than as a library > > Was there an urgency to merge this

Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-17 Thread via GitHub
TimJTi commented on PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097#issuecomment-2980458063 Hopefully I won't find any issues when, next week as said, I test the default use-case of using the boot app rather than as a library Was there an urgency to merge this now?

Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-17 Thread via GitHub
xiaoxiang781216 merged PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-16 Thread via GitHub
michallenc commented on code in PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097#discussion_r2150135674 ## boot/nxboot/Kconfig: ## @@ -122,9 +122,14 @@ config NXBOOT_PREVENT_DOWNGRADE WARNING: NXboot currently implements preferences only for

Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097#discussion_r2150106081 ## boot/nxboot/Kconfig: ## @@ -122,9 +122,14 @@ config NXBOOT_PREVENT_DOWNGRADE WARNING: NXboot currently implements preferences only for

Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-16 Thread via GitHub
TimJTi commented on PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097#issuecomment-2975658820 > @TimJTi could you test this with your configuration to check if I hadn't break anything for your use case? Of course...but I'm away at the moment, so can't until next week. The

Re: [PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-16 Thread via GitHub
michallenc commented on PR #3097: URL: https://github.com/apache/nuttx-apps/pull/3097#issuecomment-2975576804 @TimJTi could you test this with your configuration to check if I hadn't break anything for your use case? -- This is an automated message from the Apache Git Service. To respond

[PR] boot/nxboot: fix compile errors caused by nxboot_progress [nuttx-apps]

2025-06-16 Thread via GitHub
michallenc opened a new pull request, #3097: URL: https://github.com/apache/nuttx-apps/pull/3097 ## Summary Function `nxboot_progress` is located in `nxboot_main.c`, but this file is not compiled when NXboot is used as a library to an existing application and not as a bootloader. Therefo