acassis commented on PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#issuecomment-2494493935
ping @royratcliffe
Please use the Documentation to help you to squash the commits:
https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggesti
acassis commented on PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#issuecomment-1864797297
@royratcliffe thank you for the fix. Please take a look at our git
repository and look for other boards inclusion pull requests, normally a board
inclusion will have 2 or 3 commits only.
acassis commented on code in PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#discussion_r1432940371
##
.vscode/launch.json:
##
@@ -0,0 +1,42 @@
+{
+// Use IntelliSense to learn about possible attributes.
+// Hover to view descriptions of existing attributes.
+
acassis commented on PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#issuecomment-1859210156
@royratcliffe
Please fix these coding style issues:
```
Error:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/stm32h7/stm32_serial.c:1701:78:
error: Long line found
Error:
acassis commented on code in PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#discussion_r1429198525
##
boards/arm/stm32h7/heliguy_fmu-h747ai/configs/nsh_cm7_rptun/defconfig:
##
@@ -9,6 +9,7 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_STANDARD_SERIAL is not set
#
royratcliffe commented on code in PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#discussion_r1426961356
##
boards/arm/stm32h7/heliguy_fmu-h747ai/configs/nsh_cm7_rptun/defconfig:
##
@@ -9,6 +9,7 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_STANDARD_SERIAL is not s
acassis commented on code in PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#discussion_r1423978662
##
boards/arm/stm32h7/heliguy_fmu-h747ai/configs/nsh_cm7_rptun/defconfig:
##
@@ -9,6 +9,7 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_STANDARD_SERIAL is not set
#
xiaoxiang781216 commented on code in PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#discussion_r1423317385
##
boards/arm/stm32h7/heliguy_fmu-h747ai/configs/nsh_cm7_rptun/defconfig:
##
@@ -9,6 +9,7 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_STANDARD_SERIAL is no
acassis commented on code in PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#discussion_r1422614822
##
boards/arm/stm32h7/heliguy_fmu-h747ai/configs/nsh_cm7_rptun/defconfig:
##
@@ -9,6 +9,7 @@
# CONFIG_NSH_DISABLE_PS is not set
# CONFIG_STANDARD_SERIAL is not set
#
acassis commented on PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#issuecomment-1850284495
> > @royratcliffe could you rearrange your patch and fix the conflict?
>
> Thanks @xiaoxiang781216. Will do.
@royratcliffe I think what Xiang was saying it to squash some thes
acassis commented on PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#issuecomment-1850268260
@royratcliffe thank you very much for your PR and sorry for delay. I missed
that commit!
Please fix this CI issue:
```
Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/s
royratcliffe commented on PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#issuecomment-1833358922
> @royratcliffe could you rearrange your patch and fix the conflict?
Thanks @xiaoxiang781216. Will do.
--
This is an automated message from the Apache Git Service.
To respond
xiaoxiang781216 commented on PR #11291:
URL: https://github.com/apache/nuttx/pull/11291#issuecomment-1833058418
@royratcliffe could you rearrange your patch and fix the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
royratcliffe opened a new pull request, #11291:
URL: https://github.com/apache/nuttx/pull/11291
## Summary
Adds dual-core support for the STM32H747AI with a simple generic example
board equipping six LEDs, I2C, and SPI channels.
## Impact
Small impact on the existing code base f
14 matches
Mail list logo
