lupyuen commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2691734844
@keever50 We're seeking at least 2 reviewers, according to the latest
guidelines below. Let's wait a day or two for more reviewers before we merge
this. Thanks :-)
https://lists.apache
cederom commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2691863838
Thanks @keever50 :-)
* Builds for me on FreeBSD but have no SPI to test :-)
* Would be nice to present runtime logs of working solution :-)
--
This is an automated message from the
acassis merged PR #15894:
URL: https://github.com/apache/nuttx/pull/15894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2691420358
@lupyuen Thank you for sharing that!
However i am curious. How do PR reviews usually go? Do we wait till enough
reviewers spotted the PR by luck? Or do i need to ping reviewers?
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2690195968
@lupyuen looks like it worked now but with 3 skips i see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lupyuen commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2683394620
There's a download error, I restarted the CI Checks.
```
End-of-central-directory signature not found. Either this file is not
a zipfile, or it constitutes one disk of a mul
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2682943620
I'm not sure how i fix this one... It does not seem related to what i just
pushed?
`/github/workspace/sources/nuttx/tools/testbuild.sh: line 385:
/github/workspace/sources/nuttx/../nu
lupyuen commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677910306
Looks great, thanks! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677909757
oh okay do the same thing twice and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677906247
ahhh i see signed off now! However now i have issues pushing it because it
does not let me enter my password anymore. Ill get back to this soon
--
This is an automated message from
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677900199
@lupyuen By just running commit -s i get "nothing to commit, working tree
clean". I ran git commit --amend --no-edit -S which should in theory add a sign?
--
This is an automated messa
lupyuen commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677899773
Hmmm I don't see the "Signed-off-by". Could you do `git push`? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677883271
Signed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
lupyuen commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677878629
Sorry could you run `git commit -s` to sign off? Thanks :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677874634
I realized i copied the entire PR message and should have been only summery
i believe. Hope this isnt a big issue.
--
This is an automated message from the Apache Git Service.
To respo
keever50 commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677870987
Okay! Signed and added a message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
lupyuen commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2677236562
Please fill in the Commit Description (copy from the PR Summary). And
remember to sign-off with `git commit -s`. Thanks! :-)
-
https://github.com/apache/nuttx/pull/15894/commits/93e0db
nuttxpr commented on PR #15894:
URL: https://github.com/apache/nuttx/pull/15894#issuecomment-2676441776
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR does not fully meet the NuttX requirements.
keever50 opened a new pull request, #15894:
URL: https://github.com/apache/nuttx/pull/15894
*Note: Please adhere to [Contributing
Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
Board logic change.
This PR adds weak_function attributes t
19 matches
Mail list logo
