cederom commented on PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#issuecomment-2748378145
Lets just update the testing to benchmarks nomenclature.. as in
documentation so folks will search this app in benchmarks not tests.. thank you
@tmedicci :-)
Tests are specific
tmedicci commented on PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#issuecomment-2749306851
> Thanks @tmedicci.. this github works strangely recently.. did you see in
code notes that I made before or these are visible after I click request
changes again? o_O
Now I can
xiaoxiang781216 merged PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
cederom commented on PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#issuecomment-2749335484
> > > @cederom: Thanks @tmedicci.. this github works strangely recently..
did you see in code notes that I made before or these are visible after I click
request changes again? o_O
tmedicci commented on PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#issuecomment-2749319635
> > Thanks @tmedicci.. this github works strangely recently.. did you see in
code notes that I made before or these are visible after I click request
changes again? o_O
>
> Now
cederom commented on code in PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#discussion_r2010226471
##
benchmarks/mtd/CMakeLists.txt:
##
@@ -0,0 +1,33 @@
+#
##
+# apps/testing/fs/mtd_test/
tmedicci commented on PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#issuecomment-2748699984
> Lets just update the testing to benchmarks nomenclature.. as in
documentation so folks will search this app in benchmarks not tests.. thank you
@tmedicci :-)
>
> Tests are sp
tmedicci commented on PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#issuecomment-2748346410
> Thank you @tmedicci :-) Some minor updates of test -> benchmark noted :-)
When ready please also update build and runtime logs and we are ready to go,
thanks!! :-)
I had upda
cederom commented on PR #3033:
URL: https://github.com/apache/nuttx-apps/pull/3033#issuecomment-2748239973
Thank you @tmedicci :-) Some minor updates of test -> benchmark noted :-)
When ready please also update build and runtime logs and we are ready to go,
thanks!! :-)
--
This is an aut