jerpelea merged PR #15958:
URL: https://github.com/apache/nuttx/pull/15958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa
anchao commented on code in PR #15958:
URL: https://github.com/apache/nuttx/pull/15958#discussion_r1986490349
##
audio/audio_comp.c:
##
@@ -51,8 +51,8 @@ struct audio_comp_priv_s
/* This is the contained, low-level audio device array and count. */
- FAR struct audio_lowe
nuttxpr commented on PR #15958:
URL: https://github.com/apache/nuttx/pull/15958#issuecomment-2709219914
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No, this PR does not fully meet the NuttX requirements.
anchao commented on PR #15958:
URL: https://github.com/apache/nuttx/pull/15958#issuecomment-2709366850
> Thanks @anchao :-)
>
> Have you also tried to release the drivers after this update? Does it work
fine?
Yes, We have internal projects running this change
>
> In
anchao commented on code in PR #15958:
URL: https://github.com/apache/nuttx/pull/15958#discussion_r1986569809
##
audio/audio_comp.c:
##
@@ -942,31 +942,27 @@ FAR struct audio_lowerhalf_s *audio_comp_initialize(FAR
const char *name,
{
FAR struct audio_comp_priv_s *priv;
v
xiaoxiang781216 commented on code in PR #15958:
URL: https://github.com/apache/nuttx/pull/15958#discussion_r1986520893
##
audio/audio_comp.c:
##
@@ -942,31 +942,27 @@ FAR struct audio_lowerhalf_s *audio_comp_initialize(FAR
const char *name,
{
FAR struct audio_comp_priv_s *p
anchao opened a new pull request, #15958:
URL: https://github.com/apache/nuttx/pull/15958
## Summary
audio/composite: merge composite instance allocate to one times
here is not need to allocate two times
Signed-off-by: chao an
## Impact
N/A
## Te
xiaoxiang781216 commented on code in PR #15958:
URL: https://github.com/apache/nuttx/pull/15958#discussion_r1986487693
##
audio/audio_comp.c:
##
@@ -51,8 +51,8 @@ struct audio_comp_priv_s
/* This is the contained, low-level audio device array and count. */
- FAR struct a