Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022066226 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -671,22 +671,51 @@ static int gdb_recv_ack(FAR struct gdb_state_s *state) static ssize_t gdb_bin2hex(FAR void *buf, s

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-05 Thread via GitHub
tmedicci commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2766222976 Hi @chirping78 , If you don't mind, can you please run `make host_info` and update the PR's description with it? Particularly, I'm interested on Toolchain versions used for testin

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-04 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022516887 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance prin

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-04 Thread via GitHub
chirping78 commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2766268852 > Hi @chirping78 , > > If you don't mind, can you please run `make host_info` and update the PR's description with it? Particularly, I'm interested on Toolchain versions used fo

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-04 Thread via GitHub
anchao commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2021992236 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -671,22 +671,51 @@ static int gdb_recv_ack(FAR struct gdb_state_s *state) static ssize_t gdb_bin2hex(FAR void *buf, size_t buf

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-04 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022408425 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance prin

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-01 Thread via GitHub
chirping78 closed pull request #16095: arch/xtensa: add gdbstub support URL: https://github.com/apache/nuttx/pull/16095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-01 Thread via GitHub
chirping78 commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2768795076 Currently the structure of `g_reg_offs` is too simple to accommodate two different requirements, coredump and gdbstub. see: https://github.com/apache/nuttx/pull/16095#discussion_r202

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-01 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022427924 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance prin

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-01 Thread via GitHub
XuNeo commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022391385 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance print rem

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-04-01 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022338900 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance prin

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022085067 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance prin

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
chirping78 commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2767977014 > By the error message, it seems you're using Python 2.7. Can you double-check, please? @tmedicci pls check the host_info: ``` Host system OS: Ubuntu 20.04.6 LTS

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
anchao commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2021992236 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -671,22 +671,51 @@ static int gdb_recv_ack(FAR struct gdb_state_s *state) static ssize_t gdb_bin2hex(FAR void *buf, size_t buf

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
sdc-g commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022029137 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance print rem

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
tmedicci commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2766287933 > > Hi @chirping78 , > > If you don't mind, can you please run `make host_info` and update the PR's description with it? Particularly, I'm interested on Toolchain versions used for te

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
tmedicci commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2021075085 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance print

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2020670293 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -671,22 +671,51 @@ static int gdb_recv_ack(FAR struct gdb_state_s *state) static ssize_t gdb_bin2hex(FAR void *buf, size_t

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-30 Thread via GitHub
xiaoxiang781216 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2020357356 ## arch/xtensa/src/common/xtensa_debug.c: ## @@ -438,9 +505,22 @@ int up_debugpoint_remove(int type, void *addr, size_t size) uint32_t *xtensa_debug_handler(

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-30 Thread via GitHub
lupyuen commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2764472651 Please remember to fill in the Commit Description. Thanks :-) - https://github.com/apache/nuttx/pull/16095/commits/9b029ba76630a3f6180879d0a23a0045761d8b47 - https://github.com/apac

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-30 Thread via GitHub
nuttxpr commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2764468929 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, al

[PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-30 Thread via GitHub
chirping78 opened a new pull request, #16095: URL: https://github.com/apache/nuttx/pull/16095 ## Summary As follow up to #15907, add gdbstub support to xtensa arch. ## Impact No impact to users, only enhanced the development tools. ## Testing Please note that tw