Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2025-01-07 Thread via GitHub
pussuw commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2574698701 > @pussuw If that's the case, should an additional option be introduced to control the behavior of the current CPU index mapping? The existing configurations or their combinations do not s

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2025-01-06 Thread via GitHub
no1wudi commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2574582408 @pussuw If that's the case, should an additional option be introduced to control the behavior of the current CPU index mapping? The existing configurations or their combinations do not se

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2025-01-06 Thread via GitHub
pussuw commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2574582230 Maybe as a kludge solution I can set CONFIG_ARCH_RV_HARTID_BASE to != 0, since I don't use this offset value anyway. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2025-01-06 Thread via GitHub
pussuw commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2574565628 > > I use an overloaded version (defined by board logic) of hartid<->cpuid mapping in my downstream project. This was the whole point to define those as weak symbols. Please do not break t

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2025-01-02 Thread via GitHub
no1wudi commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2567465976 > I use an overloaded version (defined by board logic) of hartid<->cpuid mapping in my downstream project. This was the whole point to define those as weak symbols. Please do not bre

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2025-01-01 Thread via GitHub
pussuw commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2567113594 > > Why make things dependent on CONFIG_ARCH_RV_HARTID_BASE? Without this patch you can overload riscv_hartid_to_cpuid / riscv_cpuid_to_hartid? I'd prefer this breaking change was not merg

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2025-01-01 Thread via GitHub
no1wudi commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2566983666 > Why make things dependent on CONFIG_ARCH_RV_HARTID_BASE? Without this patch you can overload riscv_hartid_to_cpuid / riscv_cpuid_to_hartid? I'd prefer this breaking change was not merge

Re: [PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2024-12-31 Thread via GitHub
nuttxpr commented on PR #15396: URL: https://github.com/apache/nuttx/pull/15396#issuecomment-2566360905 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

[PR] arch/risc-v: Make CPU index handling based on ARCH_RV_HARTID_BASE [nuttx]

2024-12-31 Thread via GitHub
no1wudi opened a new pull request, #15396: URL: https://github.com/apache/nuttx/pull/15396 ## Summary This PR refactors the CPU index handling in the RISC-V architecture to be based on the ARCH_RV_HARTID_BASE configuration. The changes include: