Re: [PR] arch/armv7-r: fix gic.h build error [nuttx]

2025-01-17 Thread via GitHub
xiaoxiang781216 merged PR #15585: URL: https://github.com/apache/nuttx/pull/15585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] arch/armv7-r: fix gic.h build error [nuttx]

2025-01-17 Thread via GitHub
xiaoxiang781216 commented on PR #15585: URL: https://github.com/apache/nuttx/pull/15585#issuecomment-2598072987 > > should we sync the macro definition with armv7-a instead? > > @xiaoxiang781216, given that I am still new with armv7-a, to quickly check whether cortex-r5 works, maybe w

Re: [PR] arch/armv7-r: fix gic.h build error [nuttx]

2025-01-16 Thread via GitHub
yf13 commented on PR #15585: URL: https://github.com/apache/nuttx/pull/15585#issuecomment-2597281135 > should we sync the macro definition with armv7-a instead? @xiaoxiang781216, given that I am still new with armv7-a, to quickly check whether cortex-r5 works, maybe we can do minimum

Re: [PR] arch/armv7-r: fix gic.h build error [nuttx]

2025-01-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #15585: URL: https://github.com/apache/nuttx/pull/15585#discussion_r1919426597 ## arch/arm/src/armv7-r/gic.h: ## @@ -696,7 +696,7 @@ static inline void arm_cpu_sgi(int sgi, unsigned int cpuset) * SMP scenario. */ - r

[PR] arch/armv7-r: fix gic.h build error [nuttx]

2025-01-16 Thread via GitHub
yf13 opened a new pull request, #15585: URL: https://github.com/apache/nuttx/pull/15585 ## Summary This fixes compilation error: ``` /tmp/nuttx/arch/arm/src/armv7-r/gic.h:699:17: error: 'GIC_ICDSGIR_NSATT_GRP1' undeclared (first use in this function); did you mean 'GIC_ICDS