Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
xiaoxiang781216 merged PR #16486: URL: https://github.com/apache/nuttx/pull/16486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
jasonbu commented on code in PR #16486: URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128795986 ## include/nuttx/spinlock.h: ## @@ -499,6 +543,85 @@ irqstate_t spin_lock_irqsave(FAR volatile spinlock_t *lock) # define spin_lock_irqsave(l) ((void)(l), up_irq_save

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
jasonbu commented on code in PR #16486: URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128789186 ## include/nuttx/spinlock.h: ## @@ -532,6 +570,47 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile spinlock_t *lock) return flags; } +/

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
pussuw commented on code in PR #16486: URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128563069 ## include/nuttx/spinlock.h: ## @@ -603,12 +603,17 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile spinlock_t *lock) static inline_function irqstate_t rspin_lo

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
pussuw commented on code in PR #16486: URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128565957 ## include/nuttx/spinlock.h: ## @@ -499,6 +543,85 @@ irqstate_t spin_lock_irqsave(FAR volatile spinlock_t *lock) # define spin_lock_irqsave(l) ((void)(l), up_irq_save(

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
pussuw commented on code in PR #16486: URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128563069 ## include/nuttx/spinlock.h: ## @@ -603,12 +603,17 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile spinlock_t *lock) static inline_function irqstate_t rspin_lo

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
pussuw commented on code in PR #16486: URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128561699 ## include/nuttx/spinlock.h: ## @@ -532,6 +570,47 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile spinlock_t *lock) return flags; } +/*

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
anchao commented on code in PR #16486: URL: https://github.com/apache/nuttx/pull/16486#discussion_r2128541076 ## include/nuttx/spinlock.h: ## @@ -585,11 +585,11 @@ irqstate_t spin_lock_irqsave_nopreempt(FAR volatile spinlock_t *lock) * Similar feature with enter_critical_se

Re: [PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-05 Thread via GitHub
jasonbu commented on PR #16486: URL: https://github.com/apache/nuttx/pull/16486#issuecomment-2943095570 labeler fail should be the network issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] add spin_lock_irqsave_nopreempt rspin_lock_irqsave_noprempt implement. [nuttx]

2025-06-04 Thread via GitHub
jasonbu opened a new pull request, #16486: URL: https://github.com/apache/nuttx/pull/16486 ## Summary As our previous discussion, we should use a new API spin_lock_irqsave_nopreempt to handle the spin_lock with sched locked, and did not change the default behavior of original spin_lock_i