Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-23 Thread via GitHub
xiaoxiang781216 merged PR #15648: URL: https://github.com/apache/nuttx/pull/15648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
wangzhi-art commented on code in PR #15648: URL: https://github.com/apache/nuttx/pull/15648#discussion_r1926419681 ## arch/arm/src/stm32/stm32_i2c.c: ## @@ -552,7 +557,8 @@ static inline int stm32_i2c_sem_waitdone(struct stm32_i2c_priv_s *priv) uint32_t regval; int ret;

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
wangzhi-art commented on code in PR #15648: URL: https://github.com/apache/nuttx/pull/15648#discussion_r1926419681 ## arch/arm/src/stm32/stm32_i2c.c: ## @@ -552,7 +557,8 @@ static inline int stm32_i2c_sem_waitdone(struct stm32_i2c_priv_s *priv) uint32_t regval; int ret;

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
hujun260 commented on code in PR #15648: URL: https://github.com/apache/nuttx/pull/15648#discussion_r1926312301 ## arch/arm/src/stm32/stm32_i2c.c: ## @@ -552,7 +557,8 @@ static inline int stm32_i2c_sem_waitdone(struct stm32_i2c_priv_s *priv) uint32_t regval; int ret; -

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
wangzhi-art commented on code in PR #15648: URL: https://github.com/apache/nuttx/pull/15648#discussion_r1926259849 ## arch/arm/src/xmc4/xmc4_i2c.c: ## @@ -837,8 +844,8 @@ static int i2c_transfer(struct i2c_master_s *dev, } else { +

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
hujun260 commented on code in PR #15648: URL: https://github.com/apache/nuttx/pull/15648#discussion_r1926215172 ## arch/arm/src/xmc4/xmc4_i2c.c: ## @@ -837,8 +844,8 @@ static int i2c_transfer(struct i2c_master_s *dev, } else { +

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
wangzhi-art commented on code in PR #15648: URL: https://github.com/apache/nuttx/pull/15648#discussion_r1925103831 ## arch/arm/src/lc823450/lc823450_i2c.c: ## @@ -1028,10 +1032,12 @@ static int lc823450_i2c_transfer(struct i2c_master_s *dev, } else { +

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
hujun260 commented on code in PR #15648: URL: https://github.com/apache/nuttx/pull/15648#discussion_r1925042811 ## arch/arm/src/lc823450/lc823450_i2c.c: ## @@ -1028,10 +1032,12 @@ static int lc823450_i2c_transfer(struct i2c_master_s *dev, } else { +

Re: [PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
nuttxpr commented on PR #15648: URL: https://github.com/apache/nuttx/pull/15648#issuecomment-2606782107 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not adequately meet the Nu

[PR] Use small lock to protect resources related to i2c. [nuttx]

2025-01-22 Thread via GitHub
wangzhi-art opened a new pull request, #15648: URL: https://github.com/apache/nuttx/pull/15648 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary Use small lock to protect resources related to i2c.