Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2024-01-24 Thread via GitHub
casaroli commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1909118027 > > I found another shorter solution to the problem and I will push it in a separate draft PR for your evaluation @acassis @xiaoxiang781216 > > @casaroli do you have any update?

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-12-12 Thread via GitHub
xiaoxiang781216 commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1851858276 > I found another shorter solution to the problem and I will push it in a separate draft PR for your evaluation @acassis @xiaoxiang781216 @casaroli do you have any update?

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-23 Thread via GitHub
casaroli commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1824037861 I found another shorter solution to the problem and I will push it in a separate draft PR for your evaluation @acassis @xiaoxiang781216 -- This is an automated message from the Apache

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-22 Thread via GitHub
casaroli commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1401677252 ## arch/arm/src/Makefile: ## @@ -18,7 +18,7 @@ # -include $(TOPDIR)/Make.defs +include

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1401540178 ## arch/arm/src/Makefile: ## @@ -18,7 +18,7 @@ # -include $(TOPDIR)/Make.defs +

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1401540178 ## arch/arm/src/Makefile: ## @@ -18,7 +18,7 @@ # -include $(TOPDIR)/Make.defs +

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-21 Thread via GitHub
casaroli commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1400851199 ## arch/arm/src/Makefile: ## @@ -18,7 +18,7 @@ # -include $(TOPDIR)/Make.defs +include

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-21 Thread via GitHub
xiaoxiang781216 commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1400311455 ## arch/arm/src/Makefile: ## @@ -18,7 +18,7 @@ # -include $(TOPDIR)/Make.defs +

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-20 Thread via GitHub
casaroli commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1400149513 ## arch/arm/src/Makefile: ## @@ -18,7 +18,7 @@ # -include $(TOPDIR)/Make.defs +include

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #11202: URL: https://github.com/apache/nuttx/pull/11202#discussion_r1399557908 ## arch/arm/src/Makefile: ## @@ -18,7 +18,7 @@ # -include $(TOPDIR)/Make.defs +

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-20 Thread via GitHub
casaroli commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1819479636 @xiaoxiang781216 do you think we can merge something like this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-20 Thread via GitHub
casaroli commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1819017850 It looks like cmake works and do not need this modification. However, in `libtest` we are missing the word `PRIVATE` in `target_sources`. I can do it in a separate PR -- This is

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-17 Thread via GitHub
acassis commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1816668177 > > @casaroli @xiaoxiang781216 does it need to be extended to CMake as well? > > I have never done a successful cmake build of NuttX. I tested here and CMake is working fine t

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-17 Thread via GitHub
casaroli commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1816190493 > @casaroli @xiaoxiang781216 does it need to be extended to CMake as well? I never did a cmake build of NuttX. I will investigate that. -- This is an automated message from the A

Re: [PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-16 Thread via GitHub
acassis commented on PR #11202: URL: https://github.com/apache/nuttx/pull/11202#issuecomment-1815512979 @casaroli @xiaoxiang781216 does it need to be extended to CMake as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] PoC: allow apps to customize NuttX build time variables [nuttx]

2023-11-16 Thread via GitHub
casaroli opened a new pull request, #11202: URL: https://github.com/apache/nuttx/pull/11202 ## Summary This is a PoC of one of the possible ways to let the applications customize build-time options of NuttX (in `Make.defs`). For example, the `libtest` example is adding some libs to `