Re: [PR] Improve arch text heap implementation [nuttx]

2023-10-13 Thread via GitHub
xiaoxiang781216 commented on PR #10871: URL: https://github.com/apache/nuttx/pull/10871#issuecomment-1762662013 @yamt the patch you concern is removed from pr, please review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Improve arch text heap implementation [nuttx]

2023-10-13 Thread via GitHub
xiaoxiang781216 commented on PR #10871: URL: https://github.com/apache/nuttx/pull/10871#issuecomment-1761668914 > what's your motivation? > > > arch: Change ARCH_USE_TEXT_HEAP default to y instead selection > > as you see in the CI results, ci failure isn't related to thi

Re: [PR] Improve arch text heap implementation [nuttx]

2023-10-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #10871: URL: https://github.com/apache/nuttx/pull/10871#discussion_r1358378418 ## arch/sim/src/sim/posix/sim_hostmemory.c: ## @@ -60,18 +60,18 @@ static atomic_int g_uordblks; * *

Re: [PR] Improve arch text heap implementation [nuttx]

2023-10-13 Thread via GitHub
Donny9 commented on code in PR #10871: URL: https://github.com/apache/nuttx/pull/10871#discussion_r1358367945 ## arch/sim/src/sim/posix/sim_hostmemory.c: ## @@ -60,18 +60,18 @@ static atomic_int g_uordblks; * **

Re: [PR] Improve arch text heap implementation [nuttx]

2023-10-10 Thread via GitHub
xiaoxiang781216 commented on PR #10871: URL: https://github.com/apache/nuttx/pull/10871#issuecomment-1754795993 > what's your motivation? > > > arch: Change ARCH_USE_TEXT_HEAP default to y instead selection > > as you see in the CI results, this affects more things than sim. in

Re: [PR] Improve arch text heap implementation [nuttx]

2023-10-10 Thread via GitHub
yamt commented on PR #10871: URL: https://github.com/apache/nuttx/pull/10871#issuecomment-1754740582 what's your motivation? . as you see in the CI results, this affects more things than sim. -- This is an automated message from the Apache Git Service. To respond to the messa

[PR] Improve arch text heap implementation [nuttx]

2023-10-07 Thread via GitHub
xiaoxiang781216 opened a new pull request, #10871: URL: https://github.com/apache/nuttx/pull/10871 ## Summary - arch: Remove up_textheap_heapmember related stuff - arch/sim: Call host_memalign in up_allocate_heap - arch/sim: Simplify the implementation of textheap - arch: Ch