Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-21 Thread via GitHub
xiaoxiang781216 merged PR #15623: URL: https://github.com/apache/nuttx/pull/15623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
XuNeo commented on code in PR #15623: URL: https://github.com/apache/nuttx/pull/15623#discussion_r1923182694 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -283,9 +287,43 @@ static int gdb_putchar(FAR struct gdb_state_s *state, int ch) return ret; } + if (csum) +{

Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
anchao commented on code in PR #15623: URL: https://github.com/apache/nuttx/pull/15623#discussion_r1923135144 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -283,9 +287,43 @@ static int gdb_putchar(FAR struct gdb_state_s *state, int ch) return ret; } + if (csum) +

Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
XuNeo commented on code in PR #15623: URL: https://github.com/apache/nuttx/pull/15623#discussion_r1923127761 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -283,9 +287,43 @@ static int gdb_putchar(FAR struct gdb_state_s *state, int ch) return ret; } + if (csum) +{

Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
XuNeo commented on code in PR #15623: URL: https://github.com/apache/nuttx/pull/15623#discussion_r1923125832 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -283,9 +287,43 @@ static int gdb_putchar(FAR struct gdb_state_s *state, int ch) return ret; } + if (csum) +{

Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
XuNeo commented on code in PR #15623: URL: https://github.com/apache/nuttx/pull/15623#discussion_r1923124734 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -55,12 +55,8 @@ #define BUFSIZE CONFIG_LIB_GDBSTUB_PKTSIZE -#ifdef CONFIG_BOARD_MEMORY_RANGE -static const struct memory_re

Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
anchao commented on code in PR #15623: URL: https://github.com/apache/nuttx/pull/15623#discussion_r1923112060 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -283,9 +287,43 @@ static int gdb_putchar(FAR struct gdb_state_s *state, int ch) return ret; } + if (csum) +

Re: [PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
nuttxpr commented on PR #15623: URL: https://github.com/apache/nuttx/pull/15623#issuecomment-2603643125 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR description is a good start but could be improv

[PR] Gdbstub support binary memory read [nuttx]

2025-01-20 Thread via GitHub
XuNeo opened a new pull request, #15623: URL: https://github.com/apache/nuttx/pull/15623 *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).* ## Summary GDB has introduced binary memory read mode, which can improve mem