acassis merged PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.a
acassis commented on PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#issuecomment-2683010662
@eren-terzioglu the 220 ohms as pull-down is too small, it is better to use
1K or even better 4k7
--
This is an automated message from the Apache Git Service.
To respond to the messa
eren-terzioglu commented on code in PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#discussion_r1970343920
##
games/brickmatch/bm_main.c:
##
@@ -300,24 +347,117 @@ void draw_board(FAR struct screen_state_s *state,
usleep(10);
}
}
+#else
+
+/***
eren-terzioglu commented on PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#issuecomment-2682444349
> GAMES_BRICKMATCH_USE_SPI_SCREEN
I did not change anything on previous implementation, additions only made to
LED Matrix. I build it without any error but did not test it
acassis commented on PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#issuecomment-2682606433
> Thanks @acassis, updated.
Sorry, I found more some small issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
acassis commented on code in PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#discussion_r1970145506
##
games/brickmatch/bm_main.c:
##
@@ -300,24 +347,117 @@ void draw_board(FAR struct screen_state_s *state,
usleep(10);
}
}
+#else
+
+/**
eren-terzioglu commented on PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#issuecomment-2682538039
Thanks @acassis, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
acassis commented on code in PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#discussion_r1970069918
##
games/brickmatch/Kconfig:
##
@@ -33,6 +33,39 @@ config GAMES_BRICKMATCH_STACKSIZE
int "Brickmatch Game stack size"
default DEFAULT_TASK_STACKSIZE
acassis commented on PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#issuecomment-2682386696
@eren-terzioglu nice work! I suggest testing also in a LCD display to
confirm that the old code still working
--
This is an automated message from the Apache Git Service.
To respond
acassis commented on code in PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#discussion_r1970019225
##
games/brickmatch/Kconfig:
##
@@ -33,6 +33,39 @@ config GAMES_BRICKMATCH_STACKSIZE
int "Brickmatch Game stack size"
default DEFAULT_TASK_STACKSIZE
nuttxpr commented on PR #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010#issuecomment-2681217815
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The PR, as described, **does not fully meet** the Nu
eren-terzioglu opened a new pull request, #3010:
URL: https://github.com/apache/nuttx-apps/pull/3010
##Summary
Added gpio input option to brickmatch demo to have more ways input
(especially devices which does not have adc support). Additionally, added led
matrix (ws2812) support to h
12 matches
Mail list logo
