CosmicRoach commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-3002583362
> [@CosmicRoach](https://github.com/CosmicRoach) could you create PR to fix
it?
Although our ideas are meaningful, after careful consideration and attempts
at modification
CosmicRoach commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-2919682927
> [@CosmicRoach](https://github.com/CosmicRoach) could you create PR to fix
it?
Okay, I will create a PR.
--
This is an automated message from the Apache Git Service.
To
xiaoxiang781216 commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-2916451594
@CosmicRoach could you create PR to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
CosmicRoach commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-2916172476
> > > [@zhhyu7](https://github.com/zhhyu7) I think we have two ways to fix
it, which way do you think is better?
> > >
> > > 1. Don't allow choosing `icmp->id` as `0`, that
wengzhe commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-2913057738
> > [@zhhyu7](https://github.com/zhhyu7) I think we have two ways to fix it,
which way do you think is better?
> >
> > 1. Don't allow choosing `icmp->id` as `0`, that is, retur
CosmicRoach commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-2912854618
> [@zhhyu7](https://github.com/zhhyu7) I think we have two ways to fix it,
which way do you think is better?
>
> 1. Don't allow choosing `icmp->id` as `0`, that is, return
wengzhe commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-2912702722
@zhhyu7 I think we have two ways to fix it, which way do you think is better?
1. Don't allow choosing `icmp->id` as `0`, that is, return a positive number
when `local_port == 0
xiaoxiang781216 commented on issue #16429:
URL: https://github.com/apache/nuttx/issues/16429#issuecomment-2906388011
@wengzhe could you look at this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
CosmicRoach opened a new issue, #16429:
URL: https://github.com/apache/nuttx/issues/16429
### Description / Steps to reproduce the issue
Returned Value:
* External port number on success; 0 on failure
In some cases，when the return value is 0, it may indicate success.
!
