Re: [I] [BUG] Default configuration values hardcoded in code [nuttx]

2025-05-22 Thread via GitHub
acassis commented on issue #16420: URL: https://github.com/apache/nuttx/issues/16420#issuecomment-2900991551 @xiaoxiang781216 I think one downside of removing CONFIG_ is that these macros may become hard to find later. It's better to remove them step by step, adding them to Kconfig. -- T

Re: [I] [BUG] Default configuration values hardcoded in code [nuttx]

2025-05-21 Thread via GitHub
xiaoxiang781216 commented on issue #16420: URL: https://github.com/apache/nuttx/issues/16420#issuecomment-2899658513 if these macros can't migrate to Kconfig soon, it's better to remove CONFIG_ prefix and #ifndef check to avoiding confuse people. -- This is an automated message from the A

Re: [I] [BUG] Default configuration values hardcoded in code [nuttx]

2025-05-21 Thread via GitHub
acassis commented on issue #16420: URL: https://github.com/apache/nuttx/issues/16420#issuecomment-2899586783 @raiden00pl I think most of those "failsafe" #ifndef / #define comes from an era when NuttX didn't use Kconfig. Since Kconfig introduction it doesn't make sense anymore. -- This i

[I] [BUG] Default configuration values hardcoded in code [nuttx]

2025-05-21 Thread via GitHub
raiden00pl opened a new issue, #16420: URL: https://github.com/apache/nuttx/issues/16420 ### Description / Steps to reproduce the issue There are many places in NuttX where configuration defaults are set in the source code, not from Kconfig. This should be handled by Kconfig on