jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1376867557
re-based to current master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1375383376
> Yes, I think it isn't good to let's driver dig into task_group struct.
Let's come back to my first suggestion but reject by you: All mm_map_s related
function use tasK_group_s as the
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1374467833
@xiaoxiang781216 : Here is a commit which shows how the IF would look like
if you added the mm_map_s as an argument to every function (the option 1. you
mentioned avove). In my opinion it
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1373730206
One way to remove group argument from mm_map_remove is just to put a
restriction that "driver mustn't call mm_map_remove in the munmap function if
the group is unknown (NULL)". Then you wo
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1373445063
Thanks @hartmannathan for fixing the typos in the comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1371903609
re-based to latest master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1371900569
>
now done. Rammaps doesn't need the private mapping structure for anything,
all info fits in map_entry_s. So removed that too.
--
This is an automated message from the Apache Gi
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1371889416
The rammaps went broken, I will need to fix it still. It was a bit too
quick...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1370964335
> BTW, it's better to migrate the ram map and anon map to the new interface,
which is clearer and also demo that new mmap interface is flexible enough to
support the complex case.
A
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1370756078
> > I will present the posix SHMFS; this is an interface that I know is
interesting to many. For example we have implemented an own version of PX4 uORB
publish subscribe interface with
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1370572411
> BTW, it's better to migrate the ram map and anon map to the new interface,
which is clearer and also demo that new mmap interface is flexible enough to
support the complex case.
A
jlaitine commented on PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#issuecomment-1369965088
There were some issues left after re-base. I commented them, and will fix
those tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
12 matches
Mail list logo
