Re: [I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on issue #16504: URL: https://github.com/apache/nuttx/issues/16504#issuecomment-2961384385 This suggestion is only changing the default value, no size impact on the final image. ICMP already has an option and disabled by default. -- This is an automated message f

(nuttx) branch dependabot/pip/Documentation/requests-2.32.4 deleted (was 4eab4d141f)

2025-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/Documentation/requests-2.32.4 in repository https://gitbox.apache.org/repos/asf/nuttx.git was 4eab4d141f build(deps): bump requests from 2.32.3 to 2.32.4 in /Documentati

Re: [PR] build(deps): bump requests from 2.32.3 to 2.32.4 in /Documentation [nuttx]

2025-06-10 Thread via GitHub
dependabot[bot] commented on PR #16502: URL: https://github.com/apache/nuttx/pull/16502#issuecomment-2961038353 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] build(deps): bump requests from 2.32.3 to 2.32.4 in /Documentation [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 closed pull request #16502: build(deps): bump requests from 2.32.3 to 2.32.4 in /Documentation URL: https://github.com/apache/nuttx/pull/16502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2139058108 ## arch/arm/src/stm32f0l0g0/Kconfig: ## @@ -1505,6 +1505,10 @@ config STM32F0L0G0_HAVE_ADC1_DMA bool default n +config STM32F0L0G0_HAVE_ADC_OV

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2139039190 ## arch/arm/src/stm32f0l0g0/stm32_adc.c: ## @@ -1295,6 +1312,31 @@ static void adc_configure(struct adc_dev_s *dev) adc_dumpregs(priv); } + #if defined(CO

Re: [PR] Update the ELF guides [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on PR #16509: URL: https://github.com/apache/nuttx/pull/16509#issuecomment-2961001227 @nmaggioni please fix the documentation build error: https://github.com/apache/nuttx/actions/runs/15573715022/job/43855943063?pr=16509 -- This is an automated message from th

Re: [I] [BUG] nuttx-aware debugging with gdb: fail to load pynuttx `fs` module [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on issue #16507: URL: https://github.com/apache/nuttx/issues/16507#issuecomment-2960991344 @XuNeo and @Donny9 could you look at this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Add missing CFLAGS to the ELF guides [nuttx]

2025-06-10 Thread via GitHub
nmaggioni commented on PR #16506: URL: https://github.com/apache/nuttx/pull/16506#issuecomment-2960937864 Momentarily closing this in favor of the new related PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add missing CFLAGS to the ELF guides [nuttx]

2025-06-10 Thread via GitHub
nmaggioni closed pull request #16506: Add missing CFLAGS to the ELF guides URL: https://github.com/apache/nuttx/pull/16506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] Update the ELF guides [nuttx]

2025-06-10 Thread via GitHub
nmaggioni opened a new pull request, #16509: URL: https://github.com/apache/nuttx/pull/16509 ## Summary This PR extends and supersedes #16506 by offering a more extensive rewrite of both ELF guides: the contents have been updated for export packages generated by newer NuttX versions,

Re: [I] [BUG] nxsem_wait_irq assertion failure [nuttx]

2025-06-10 Thread via GitHub
atr294 commented on issue #16462: URL: https://github.com/apache/nuttx/issues/16462#issuecomment-2960924152 @pussuw @acassis My apologies for the delay. It took me some time to get `CONFIG_MM_KMAP` working on my Litex target due to initial memory layout issues. After resolving those,

[PR] riscv qemu-rv: fix kernel mapping by enabling CONFIG_MM_KMAP in knsh [nuttx]

2025-06-10 Thread via GitHub
atr294 opened a new pull request, #16508: URL: https://github.com/apache/nuttx/pull/16508 ## Summary * Enable CONFIG_MM_KMAP in the knsh defconfig for the QEMU RISC-V board. This change addresses kernel mapping issues when running in S-mode with the MMU enabled, as discussed in [apa

(nuttx-website) branch asf-site updated: Publishing web: be40bd59e126a7ffe6ebacfb1b7682fcd8e89704 docs: 19eac98526beb7a76152564fe848c4a003dd70da

2025-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 14a2d3507 Publishing web: be40bd5

[I] [BUG] nuttx-aware debugging with gdb: fail to load pynuttx `fs` module [nuttx]

2025-06-10 Thread via GitHub
sumpfralle opened a new issue, #16507: URL: https://github.com/apache/nuttx/issues/16507 ### Description / Steps to reproduce the issue I tried to follow the instructions for [nuttx-aware debugging with gdb](https://nuttx.apache.org/docs/latest/quickstart/debugging.html#with-gdb).

[PR] Add missing CFLAGS to the ELF guides [nuttx]

2025-06-10 Thread via GitHub
nmaggioni opened a new pull request, #16506: URL: https://github.com/apache/nuttx/pull/16506 ## Summary Following the current ELF guides ([[1]](https://nuttx.apache.org/docs/12.9.0/guides/partially_linked_elf.html), [[2]](https://nuttx.apache.org/docs/12.9.0/guides/fully_linked_elf.h

Re: [I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
TimJTi commented on issue #16504: URL: https://github.com/apache/nuttx/issues/16504#issuecomment-2960406672 Ok, but I see people lamenting the loss of options that allow NuttX to better suit small processors. Shouldn't we accommodate that somehow as NON default options? -- This is an

Re: [PR] RFC 5424 implementation for SYSLOG [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #16493: URL: https://github.com/apache/nuttx/pull/16493#discussion_r2138622134 ## drivers/syslog/Kconfig: ## @@ -140,61 +140,94 @@ config SYSLOG_INTBUFSIZE comment "Formatting options" +config SYSLOG_RFC5424 + bool "Standard sys

Re: [PR] RFC 5424 implementation for SYSLOG [nuttx]

2025-06-10 Thread via GitHub
linguini1 commented on code in PR #16493: URL: https://github.com/apache/nuttx/pull/16493#discussion_r2138580797 ## drivers/syslog/Kconfig: ## @@ -140,61 +140,94 @@ config SYSLOG_INTBUFSIZE comment "Formatting options" +config SYSLOG_RFC5424 + bool "Standard syslog fo

Re: [PR] RFC 5424 implementation for SYSLOG [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #16493: URL: https://github.com/apache/nuttx/pull/16493#discussion_r2138571543 ## drivers/syslog/Kconfig: ## @@ -140,61 +140,94 @@ config SYSLOG_INTBUFSIZE comment "Formatting options" +config SYSLOG_RFC5424 + bool "Standard sys

Re: [I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on issue #16504: URL: https://github.com/apache/nuttx/issues/16504#issuecomment-2960280129 POSIX-compliance isn't an option. It's also bad to add an option to control the minor default behavior, since only few people can remember them. -- This is an automated mes

[PR] Add BLE config to esp32-sparrow [nuttx]

2025-06-10 Thread via GitHub
robertc2000 opened a new pull request, #16505: URL: https://github.com/apache/nuttx/pull/16505 ## Summary Added a configuration for ESP32-Sparrow kit with Bluetooth support enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on issue #16504: URL: https://github.com/apache/nuttx/issues/16504#issuecomment-2960084534 it's fine to enable multicast loop by default like Linux -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
TimJTi commented on issue #16504: URL: https://github.com/apache/nuttx/issues/16504#issuecomment-2960092328 Would it be an idea to add a "POSIX-compliance" Kconfig option, default yes. If disabled, a list of all the individual features that can be disabled is shown. As items are added to th

Re: [PR] RFC 5424 implementation for SYSLOG [nuttx]

2025-06-10 Thread via GitHub
linguini1 commented on code in PR #16493: URL: https://github.com/apache/nuttx/pull/16493#discussion_r2138440895 ## drivers/syslog/Kconfig: ## @@ -140,61 +140,94 @@ config SYSLOG_INTBUFSIZE comment "Formatting options" +config SYSLOG_RFC5424 + bool "Standard syslog fo

Re: [PR] improve libc/stream subsystem [nuttx]

2025-06-10 Thread via GitHub
acassis commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2138422072 ## libs/libc/stream/lib_mtdoutstream.c: ## @@ -342,18 +330,22 @@ int lib_mtdoutstream_open(FAR struct lib_mtdoutstream_s *stream, return -EINVAL; } - st

Re: [PR] improve libc/stream subsystem [nuttx]

2025-06-10 Thread via GitHub
acassis commented on code in PR #16496: URL: https://github.com/apache/nuttx/pull/16496#discussion_r2138404580 ## libs/libc/stream/lib_mtdsostream.c: ## @@ -0,0 +1,359 @@ +/ + * libs/libc/stream/lib_mtds

Re: [I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
acassis commented on issue #16504: URL: https://github.com/apache/nuttx/issues/16504#issuecomment-2960023136 @sastel I think it is because NuttX try to only enable the minimal thinks possible. But things are changing, in the past we could enable or disable signals, until someone realized si

Re: [PR] RFC 5424 implementation for SYSLOG [nuttx]

2025-06-10 Thread via GitHub
linguini1 commented on code in PR #16493: URL: https://github.com/apache/nuttx/pull/16493#discussion_r2138226804 ## drivers/syslog/vsyslog_rfc5424.c: ## @@ -0,0 +1,262 @@ +/ + * drivers/syslog/vsyslog_rf

Re: [PR] RFC 5424 implementation for SYSLOG [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on code in PR #16493: URL: https://github.com/apache/nuttx/pull/16493#discussion_r2138222779 ## drivers/syslog/Kconfig: ## @@ -140,61 +140,94 @@ config SYSLOG_INTBUFSIZE comment "Formatting options" +config SYSLOG_RFC5424 + bool "Standard sys

Re: [I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
sastel commented on issue #16504: URL: https://github.com/apache/nuttx/issues/16504#issuecomment-2959615664 This Linux programming document from 1998 [Multicast Programming](https://tldp.org/HOWTO/Multicast-HOWTO-6.html) says in section _6.1 IP_MULTICAST_LOOP_ "Loopback is by default enable

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
tinnedkarma commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2138057721 ## arch/arm/src/stm32f0l0g0/stm32_adc.c: ## @@ -1295,6 +1312,31 @@ static void adc_configure(struct adc_dev_s *dev) adc_dumpregs(priv); } + #if defined(CONFIG

Re: [I] Actions list to improve NuttX quality and reliability [nuttx]

2025-06-10 Thread via GitHub
acassis commented on issue #16278: URL: https://github.com/apache/nuttx/issues/16278#issuecomment-2959501844 Hi @NevynUK we didn't start it yet, but my initial idea was to took a look at coccinelle and frama-c, but yest cpp-check seems a nice option. Another option to take a look is SonarQu

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
Donny9 commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2959482238 > please add a commit message to [0ec77cf](https://github.com/apache/nuttx/commit/0ec77cf1375923da6208322190849597075752ad) and change the title to tools/pynuttx: update fs.py base on new

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
tinnedkarma commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2138041392 ## arch/arm/src/stm32f0l0g0/stm32_adc.c: ## @@ -1295,6 +1312,31 @@ static void adc_configure(struct adc_dev_s *dev) adc_dumpregs(priv); } + #if defined(CONFIG

(nuttx) 02/04: sched/wdog: Replace periodcial timer with the wd_start_next.

2025-06-10 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit efe2af643f6362d5d461049e7f9b7ea67edb0eb5 Author: ouyangxiangzhen AuthorDate: Thu May 29 14:42:45 2025 +0800 sched/w

(nuttx) 03/04: sched/wqueue: Remove the work_queue_period.

2025-06-10 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit df183b668272dafb7e3e236fcbdf6d87ede6f3b9 Author: ouyangxiangzhen AuthorDate: Wed Jun 4 17:11:49 2025 +0800 sched/wq

(nuttx) 01/04: sched/wdog: Remove the wd_start_period.

2025-06-10 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 9d1b9585245d0ac1079e887b1166c6a8215619e9 Author: ouyangxiangzhen AuthorDate: Wed Jun 4 11:35:31 2025 +0800 sched/wd

(nuttx) 04/04: sched: Add comments for wd_start_next and work_queue_next.

2025-06-10 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 19eac98526beb7a76152564fe848c4a003dd70da Author: ouyangxiangzhen AuthorDate: Mon Jun 9 21:04:56 2025 +0800 sched: A

(nuttx) branch master updated (5e94d4482b -> 19eac98526)

2025-06-10 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5e94d4482b fs/vfs: check buffer count and pointer for iovec new 9d1b958524 sched/wdog: Remove the wd_start_period

Re: [PR] sched/wdog: Replace periodical timer with the wd_start_next. [nuttx]

2025-06-10 Thread via GitHub
acassis merged PR #16481: URL: https://github.com/apache/nuttx/pull/16481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

[I] [HELP] Why isn't multicast loopback switched on by default? [nuttx]

2025-06-10 Thread via GitHub
sastel opened a new issue, #16504: URL: https://github.com/apache/nuttx/issues/16504 ### Description @acassis I noticed recently that multicast loopback is disabled by default in NuttX. I have a pair of applications which when I run them on the same device using Linux, discover each

[I] [FEATURE] GSoC 2025 - Silicon Heaven Integration into the NuttX mainline [nuttx]

2025-06-10 Thread via GitHub
zdebanos opened a new issue, #16503: URL: https://github.com/apache/nuttx/issues/16503 ### Is your feature request related to a problem? Please describe. Dear NuttX community, I created this issue to serve as a place for the reporting of progress concerning my GSoC 2025 project

Re: [I] Issue building ELF programs with no symbol table. [nuttx-apps]

2025-06-10 Thread via GitHub
acassis commented on issue #1828: URL: https://github.com/apache/nuttx-apps/issues/1828#issuecomment-2959162090 Hi @nmaggioni thank you for confirming the issue. Sure, all our documentation is located inside NuttX source code itself (Documentation/ folder). Please submit a PR with the fix.

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
raiden00pl commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2137770211 ## arch/arm/src/stm32f0l0g0/stm32_adc.c: ## @@ -1295,6 +1312,31 @@ static void adc_configure(struct adc_dev_s *dev) adc_dumpregs(priv); } + #if defined(CONFIG_

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
stbenn commented on PR #16500: URL: https://github.com/apache/nuttx/pull/16500#issuecomment-2959012006 @raiden00pl We are not planning on adding timer trigger support, but Kyle is currently working on adding DMA support -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
tinnedkarma commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2137760993 ## arch/arm/src/stm32f0l0g0/stm32_adc.c: ## @@ -1295,6 +1312,31 @@ static void adc_configure(struct adc_dev_s *dev) adc_dumpregs(priv); } + #if defined(CONFIG

[PR] build(deps): bump requests from 2.32.3 to 2.32.4 in /Documentation [nuttx]

2025-06-10 Thread via GitHub
dependabot[bot] opened a new pull request, #16502: URL: https://github.com/apache/nuttx/pull/16502 Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. Release notes Sourced from https://github.com/psf/requests/releases";>requests's releases. v2.32.4 2

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
Donny9 commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2958604587 > > > Fix the race condition issues pointed out by @xiaoxiang781216 and then this is fine to merge by me. I will not review this any longer as this is not my code anymore. > > > >

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
Donny9 commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2958601775 @jlaitine The changes made this time are indeed quite significant, involving modifications to the core relationship between file descriptors and file structures. We've made over 140 a

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
Donny9 commented on code in PR #16499: URL: https://github.com/apache/nuttx/pull/16499#discussion_r2137501582 ## fs/inode/fs_files.c: ## @@ -587,37 +621,138 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR struct inode *inode, #endif } +/

(nuttx) branch dependabot/pip/Documentation/requests-2.32.4 created (now 4eab4d141f)

2025-06-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/Documentation/requests-2.32.4 in repository https://gitbox.apache.org/repos/asf/nuttx.git at 4eab4d141f build(deps): bump requests from 2.32.3 to 2.32.4 in /Documentati

Re: [PR] espressif[risc-v|xtensa]: Check events when reading PCNT counter value [nuttx]

2025-06-10 Thread via GitHub
Vajnar commented on code in PR #16491: URL: https://github.com/apache/nuttx/pull/16491#discussion_r2137284771 ## arch/risc-v/src/common/espressif/esp_pcnt.c: ## Review Comment: cc: @ppisa -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] espressif[risc-v|xtensa]: Check events when reading PCNT counter value [nuttx]

2025-06-10 Thread via GitHub
Vajnar commented on code in PR #16491: URL: https://github.com/apache/nuttx/pull/16491#discussion_r2137255677 ## arch/risc-v/src/common/espressif/esp_pcnt.c: ## Review Comment: Hi @tmedicci, for the first question, yes that is the case. The probability is low, but the wind

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
pussuw commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957958025 > > Fix the race condition issues pointed out by @xiaoxiang781216 and then this is fine to merge by me. I will not review this any longer as this is not my code anymore. > > The new

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
raiden00pl commented on PR #16500: URL: https://github.com/apache/nuttx/pull/16500#issuecomment-2958118582 hi @kywwilson11 @stbenn, are you planing to add support for TIMER triggering for ADC? I wanted to start working on it soon, so I'd like to make sure we don't duplicate our work :) --

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
raiden00pl commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2137149183 ## arch/arm/src/stm32f0l0g0/hardware/stm32_adc.h: ## @@ -108,9 +113,16 @@ #define STM32_ADC1_CFGR2(STM32_ADC1_BASE + STM32_ADC_CFGR2_OFFSET) #define ST

Re: [PR] Add ADC support for STM32G0 (along with oversampling) [nuttx]

2025-06-10 Thread via GitHub
raiden00pl commented on code in PR #16500: URL: https://github.com/apache/nuttx/pull/16500#discussion_r2137212888 ## arch/arm/src/stm32f0l0g0/hardware/stm32_adc.h: ## @@ -240,27 +277,48 @@ #define ADC_CHSELR_CHSEL16 (1 << 16) /* Select channel 16 */ #define ADC_CHSE

Re: [PR] RFC 5424 implementation for SYSLOG [nuttx]

2025-06-10 Thread via GitHub
tinnedkarma commented on code in PR #16493: URL: https://github.com/apache/nuttx/pull/16493#discussion_r2137189292 ## drivers/syslog/vsyslog_rfc5424.c: ## @@ -0,0 +1,262 @@ +/ + * drivers/syslog/vsyslog_

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957935536 > Fix the race condition issues pointed out by @xiaoxiang781216 and then this is fine to merge by me. I will not review this any longer as this is not my code anymore. The

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
jlaitine commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957885073 Why are the original patches, *which we tested to be working correctly*, partially re-written in this PR, instead of pointing out if there were errors in those in the closed PR? I

Re: [PR] fs/vfs: Separate file descriptors from file descriptions [nuttx]

2025-06-10 Thread via GitHub
xiaoxiang781216 commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957928622 > Why are the original patches, _which we tested to be working correctly_, partially re-written in this PR, instead of pointing out if there were errors in those in the closed PR?