Re: [PR] Add CMakeLists for STM32L4 / Nucleo-l476rg board [nuttx]

2025-03-31 Thread via GitHub
pryre commented on PR #16101: URL: https://github.com/apache/nuttx/pull/16101#issuecomment-2767922026 Apologies, I've messed up my commit tree. I will resubmit a clean copy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
jlaitine commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2022165895 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/**

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
jlaitine commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2022157093 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/**

Re: [PR] fs/littlefs: Add read-only parameter [nuttx]

2025-03-31 Thread via GitHub
yamt commented on code in PR #15945: URL: https://github.com/apache/nuttx/pull/15945#discussion_r2022099888 ## fs/littlefs/lfs_vfs.c: ## @@ -1168,6 +1162,11 @@ static int littlefs_write_block(FAR const struct lfs_config *c, FAR struct inode *drv = fs->drv; int ret; + i

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
anchao commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2012139268 ## include/nuttx/sem_fast.h: ## @@ -0,0 +1,184 @@ +/ + * include/nuttx/sem_fast.h + * + * SPD

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022085067 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance prin

Re: [PR] Add CMakeLists for STM32L4 / Nucleo-l476rg board (Fixed) [nuttx]

2025-03-31 Thread via GitHub
nuttxpr commented on PR #16102: URL: https://github.com/apache/nuttx/pull/16102#issuecomment-2767983462 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements.

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
chirping78 commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2767977014 > By the error message, it seems you're using Python 2.7. Can you double-check, please? @tmedicci pls check the host_info: ``` Host system OS: Ubuntu 20.04.6 LTS

[PR] Add CMakeLists for STM32L4 / Nucleo-l476rg board (Fixed) [nuttx]

2025-03-31 Thread via GitHub
pryre opened a new pull request, #16102: URL: https://github.com/apache/nuttx/pull/16102 ## Summary This pull request adds CMakeLists.txt files required to build for the `stm32l4` arch, specifically the `stm32l476rg` board. ## Impact There should be no adverse effects fr

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
anchao commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2021992236 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -671,22 +671,51 @@ static int gdb_recv_ack(FAR struct gdb_state_s *state) static ssize_t gdb_bin2hex(FAR void *buf, size_t buf

(nuttx) 01/06: boards/xtensa/esp32s3: Enable SPI Flash's MTD block driver

2025-03-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 440d4a688ad7def724cc9cfe542b7122d26ffcc5 Author: Tiago Medicci Serrano AuthorDate: Tue Mar 25 16:33:19 2025 -0300

[PR] Add CMakeLists for STM32L4 / Nucleo-l476rg board [nuttx]

2025-03-31 Thread via GitHub
pryre opened a new pull request, #16101: URL: https://github.com/apache/nuttx/pull/16101 ## Summary This pull request adds CMakeLists.txt files required to build for the `stm32l4` arch, specifically the `stm32l476rg` board. ## Impact There should be no adverse effects fr

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
sdc-g commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2022029137 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance print rem

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
jlaitine commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2765736803 Based on comments from @pussuw , I will still do the following changes to this: 1) have separate functions for no cancellation point or errno in libc without the "nx..." prefix

(nuttx) 03/06: boards/xtensa/esp32s2: Enable SPI Flash's MTD block

2025-03-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 09bcec95a830da3ed38ad125d33954cdb47cc93b Author: Tiago Medicci Serrano AuthorDate: Thu Mar 27 11:51:23 2025 -0300

(nuttx) branch master updated: sensors/nau7802: Add support for the NAU7802

2025-03-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 504f838577 sensors/nau7802: Add support for th

Re: [PR] drivers/sensors/nau7802: Add support for the NAU7802 [nuttx]

2025-03-31 Thread via GitHub
xiaoxiang781216 merged PR #16087: URL: https://github.com/apache/nuttx/pull/16087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (fb807dbbe1 -> 7482170f3f)

2025-03-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from fb807dbbe1 Documentation/szpi-esp32s3: Add doc for LVGL new 440d4a688a boards/xtensa/esp32s3: Enable SPI Flash'

(nuttx) 06/06: boards/risc-v/esp32c6: Enable SPI Flash's MTD block

2025-03-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 7482170f3fd797820b052c6d41c6ee9817c1baaf Author: Tiago Medicci Serrano AuthorDate: Thu Mar 27 11:52:51 2025 -0300

(nuttx) branch master updated (fb24cae852 -> fb807dbbe1)

2025-03-31 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from fb24cae852 boards/extensa/esp32: use wlan config to start wlan add bd87bec6fb boards/szpi-esp32s3: Register LCD

Re: [PR] boards/szpi-esp32s3: Enable LVGL [nuttx]

2025-03-31 Thread via GitHub
xiaoxiang781216 merged PR #16100: URL: https://github.com/apache/nuttx/pull/16100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[I] [BUG] foc feedforward [nuttx-apps]

2025-03-31 Thread via GitHub
binsruby opened a new issue, #3047: URL: https://github.com/apache/nuttx-apps/issues/3047 ### Description / Steps to reproduce the issue the function foc_feedforward_pmsm_b16 in foc_feedforward.c, vdq_comp->q should use idq->d, not idq->q /* NOTE: vdq_comp is substrac

Re: [PR] drivers/sensors/nau7802: Add support for the NAU7802 [nuttx]

2025-03-31 Thread via GitHub
acassis commented on code in PR #16087: URL: https://github.com/apache/nuttx/pull/16087#discussion_r2021011659 ## include/nuttx/sensors/ioctl.h: ## @@ -480,6 +480,30 @@ #define SNIOC_LPF _SNIOC(0x00A0) +/* Command: SNIOC_SET_GAIN + * Description: S

Re: [I] [HELP] romfs on esp32 [nuttx]

2025-03-31 Thread via GitHub
acassis commented on issue #16099: URL: https://github.com/apache/nuttx/issues/16099#issuecomment-2767516648 @lupyuen did you try something like this in the past? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] espressif: Enable SPI Flash's MTD block driver for all supported SoCs [nuttx]

2025-03-31 Thread via GitHub
tmedicci opened a new pull request, #16098: URL: https://github.com/apache/nuttx/pull/16098 ## Summary This PR enables the SPI Flash's MTD block driver, which enables testing the SPI Flash device without any associated filesystems. ESP32, ESP32-S2, ESP32-S3, ESP32-C3, ESP32-C6, and E

Re: [PR] boards/szpi-esp32s3: Enable LVGL [nuttx]

2025-03-31 Thread via GitHub
nuttxpr commented on PR #16100: URL: https://github.com/apache/nuttx/pull/16100#issuecomment-2766647759 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is insufficient and lacks critical detai

Re: [PR] drivers/sensors/nau7802: Add support for the NAU7802 [nuttx]

2025-03-31 Thread via GitHub
bskdany commented on code in PR #16087: URL: https://github.com/apache/nuttx/pull/16087#discussion_r2021406071 ## include/nuttx/sensors/ioctl.h: ## @@ -480,6 +480,30 @@ #define SNIOC_LPF _SNIOC(0x00A0) +/* Command: SNIOC_SET_GAIN + * Description: S

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
tmedicci commented on PR #16095: URL: https://github.com/apache/nuttx/pull/16095#issuecomment-2766287933 > > Hi @chirping78 , > > If you don't mind, can you please run `make host_info` and update the PR's description with it? Particularly, I'm interested on Toolchain versions used for te

Re: [PR] arch/xtensa/esp32: Add support for hardware accelerated SHA [nuttx]

2025-03-31 Thread via GitHub
tmedicci commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2021024832 ## arch/xtensa/src/esp32/esp32_sha.c: ## Review Comment: Hi @PruteanuVlad , thanks for your effort on updating it! I see a couple of problems regarding the

(nuttx) 02/02: boards/extensa/esp32: use wlan config to start wlan

2025-03-31 Thread tmedicci
This is an automated email from the ASF dual-hosted git repository. tmedicci pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fb24cae85218b8ef23c10ab2eefd8740c5714068 Author: Laczen JMS AuthorDate: Fri Mar 28 14:00:00 2025 +0100 boards/exte

Re: [PR] arch/xtensa/src/common: Make esp32 wlan device configurable [nuttx]

2025-03-31 Thread via GitHub
tmedicci merged PR #16092: URL: https://github.com/apache/nuttx/pull/16092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apa

(nuttx) branch master updated (a834540f42 -> fb24cae852)

2025-03-31 Thread tmedicci
This is an automated email from the ASF dual-hosted git repository. tmedicci pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from a834540f42 Documentation/szpi-esp32s3: Add doc for LCD new b8964f5c46 arch/xtensa/src/common/espressif: Add wlan

Re: [PR] arch/xtensa/src/common: Make esp32 wlan device configurable [nuttx]

2025-03-31 Thread via GitHub
tmedicci commented on PR #16092: URL: https://github.com/apache/nuttx/pull/16092#issuecomment-2766442652 > > @tmedicci I have added the other boards as well. > > Thanks! > > Just let me trigger our internal CI once again... come back soon. Everything is fine! Thanks @Lacz

Re: [I] [HELP] Proper multi-directory custom app integration [nuttx]

2025-03-31 Thread via GitHub
acassis commented on issue #16093: URL: https://github.com/apache/nuttx/issues/16093#issuecomment-2766186242 @stbenn is this happing only with Makefile build? Or do it happen with CMake too? @xiaoxiang781216 any idea? -- This is an automated message from the Apache Git Service. To

Re: [PR] drivers/sensors/nau7802: Add support for the NAU7802 [nuttx]

2025-03-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #16087: URL: https://github.com/apache/nuttx/pull/16087#discussion_r2020373347 ## include/nuttx/sensors/ioctl.h: ## @@ -480,6 +480,30 @@ #define SNIOC_LPF _SNIOC(0x00A0) +/* Command: SNIOC_SET_GAIN + * Descrip

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
tmedicci commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2021075085 ## arch/xtensa/src/common/xtensa_tcbinfo.c: ## @@ -36,35 +36,9 @@ static const uint16_t g_reg_offs[] = { + /* In the same order as gdb command "maintenance print

Re: [I] [HELP] Proper multi-directory custom app integration [nuttx]

2025-03-31 Thread via GitHub
stbenn commented on issue #16093: URL: https://github.com/apache/nuttx/issues/16093#issuecomment-2766280033 I have only tried the makefile build, so I can't comment on if the behavior occurs in CMake build. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] arch/xtensa/src/common: Make esp32 wlan device configurable [nuttx]

2025-03-31 Thread via GitHub
tmedicci commented on PR #16092: URL: https://github.com/apache/nuttx/pull/16092#issuecomment-2766002543 > @tmedicci I have added the other boards as well. Thanks! Just let me trigger our internal CI once again... come back soon. -- This is an automated message from the Apach

Re: [I] [BUG] NUCLEO-STM32F767zi can not initialize /dev/buttons [nuttx]

2025-03-31 Thread via GitHub
acassis commented on issue #16097: URL: https://github.com/apache/nuttx/issues/16097#issuecomment-2766177626 @vrmay23 please create a PR with the fix. @raiden00pl PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-31 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r2021011359 ## arch/arm/src/common/Toolchain.defs: ## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on sim +

Re: [PR] Fix x86/64 early-print [nuttx]

2025-03-31 Thread via GitHub
Fix-Point commented on code in PR #15936: URL: https://github.com/apache/nuttx/pull/15936#discussion_r2021011359 ## arch/arm/src/common/Toolchain.defs: ## @@ -124,6 +124,11 @@ ifeq ($(CONFIG_UNWINDER_ARM),y) endif endif +# Fix -Wshadow warnings for built-in bitops on sim +

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-31 Thread via GitHub
acassis merged PR #16094: URL: https://github.com/apache/nuttx/pull/16094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
jlaitine closed pull request #16030: Optimize mutex atomic fast path URL: https://github.com/apache/nuttx/pull/16030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] benchmarks/mtd: Select libc's floating point support and improve format specifiers portability [nuttx-apps]

2025-03-31 Thread via GitHub
tmedicci commented on PR #3046: URL: https://github.com/apache/nuttx-apps/pull/3046#issuecomment-2765997038 > please use `depends on` instead of `select`. Here is a previous discussion about a similar issue: [apache/nuttx#15599](https://github.com/apache/nuttx/issues/15599) and a discussio

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
jlaitine commented on PR #16030: URL: https://github.com/apache/nuttx/pull/16030#issuecomment-2765749632 I will still do the following chages based on comments from @pussuw : 1) Will have separate functions for non-cancellation or errno in libc without the nx-prefix and functions in kerne

[PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
jlaitine opened a new pull request, #16030: URL: https://github.com/apache/nuttx/pull/16030 ## Summary This further optimizes mutexes: 1. If priority inheritance or priority protect are enabled in nuttx config, the fast atomic mutex path should be used, if priority adjusting is not

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
pussuw commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2020730729 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
xiaoxiang781216 commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2020723547 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/***

Re: [PR] arch/xtensa: add gdbstub support [nuttx]

2025-03-31 Thread via GitHub
chirping78 commented on code in PR #16095: URL: https://github.com/apache/nuttx/pull/16095#discussion_r2020670293 ## libs/libc/gdbstub/lib_gdbstub.c: ## @@ -671,22 +671,51 @@ static int gdb_recv_ack(FAR struct gdb_state_s *state) static ssize_t gdb_bin2hex(FAR void *buf, size_t

Re: [PR] boards/szpi-esp32s3: Add support for LCD [nuttx]

2025-03-31 Thread via GitHub
JianyuWang0623 commented on PR #16094: URL: https://github.com/apache/nuttx/pull/16094#issuecomment-2765601250 > I think G and B channels are at inverted positions. When it should be Blue it is Green and when it should be Green it is Blue @acassis It seems that the RGB data endian

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
pussuw commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2020504308 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
pussuw commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2020504308 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/

Re: [PR] Optimize mutex atomic fast path [nuttx]

2025-03-31 Thread via GitHub
pussuw commented on code in PR #16030: URL: https://github.com/apache/nuttx/pull/16030#discussion_r2020504308 ## libs/libc/semaphore/sem_wait.c: ## @@ -98,3 +98,43 @@ int sem_wait(FAR sem_t *sem) leave_cancellation_point(); return ERROR; } + +/