Re: [PR] fs: partition: fs_mbr: fix for MBR block count calculation. [nuttx]

2024-01-13 Thread via GitHub
centurysys commented on PR #11540: URL: https://github.com/apache/nuttx/pull/11540#issuecomment-1890855796 @alandeassis I think my commit message is wrong and the limit will be 4 GiB. FAT only allows up to 2 GiB, so this may not be a practical problem. The partition that is over 4GiB

Re: [PR] bluetooth: Prevent btsak from repeatedly showing the same error. [nuttx]

2024-01-13 Thread via GitHub
alandeassis commented on PR #11535: URL: https://github.com/apache/nuttx/pull/11535#issuecomment-1890823504 @ldube what Mr. Alin is saying is you need to put this message in the git commit message, it is easir to see than looking at this PR (that will be closed after the merge) -- This i

Re: [PR] fs: partition: fs_mbr: fix for MBR block count calculation. [nuttx]

2024-01-13 Thread via GitHub
alandeassis commented on PR #11540: URL: https://github.com/apache/nuttx/pull/11540#issuecomment-1890822992 @centurysys @xiaoxiang781216 maybe we need to show some warning to let users know that if CONFIG_FS_LARGEFILE is not enabled they don't use sdcards with partition bigger than 2GB --

Re: [I] ESP32S3: SPI cannot use. [nuttx]

2024-01-13 Thread via GitHub
alandeassis commented on issue #11539: URL: https://github.com/apache/nuttx/issues/11539#issuecomment-1890822154 @w2016561536 this issue is happening because you are not registering the SPI char device, you need to call spi_register() to do it. Please look how it is done in other boards.

Re: [I] posix signal use [nuttx]

2024-01-13 Thread via GitHub
alandeassis commented on issue #11532: URL: https://github.com/apache/nuttx/issues/11532#issuecomment-1890817664 @xiaotailang depeding when you are trying to use it, the POSIX functions are not initialized yet and will not work. Could you please show some generic example to let us to test i

(nuttx-website) branch asf-site updated: Publishing web: 36ddd7c60a8230335eda886c909bc938739114a2 docs: 8fb05d44bce1852e5c5ac82461271bb9d83ab9cf

2024-01-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 31fde377 Publishing web: 36ddd7c6

Re: [PR] fs: partition: fs_mbr: fix for MBR block count calculation. [nuttx]

2024-01-13 Thread via GitHub
centurysys commented on code in PR #11540: URL: https://github.com/apache/nuttx/pull/11540#discussion_r1451629482 ## fs/partition/fs_mbr.c: ## @@ -36,7 +36,12 @@ / #define MBR_SIZE

Re: [PR] fs: partition: fs_mbr: fix for MBR block count calculation. [nuttx]

2024-01-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #11540: URL: https://github.com/apache/nuttx/pull/11540#discussion_r1451497317 ## fs/partition/fs_mbr.c: ## @@ -36,7 +36,12 @@ / #define MBR_SIZE

Re: [PR] decoupling rptun ping and rptun_virtio_device, rptun ping and rptun. [nuttx]

2024-01-13 Thread via GitHub
xiaoxiang781216 commented on code in PR #11537: URL: https://github.com/apache/nuttx/pull/11537#discussion_r1451495913 ## drivers/rptun/Kconfig: ## @@ -38,11 +45,4 @@ config RPTUN_PM goto RAM-retention mode, can't access from another CPU. So, we p

[PR] fs: partition: fs_mbr: fix for MBR block count calculation. [nuttx]

2024-01-13 Thread via GitHub
centurysys opened a new pull request, #11540: URL: https://github.com/apache/nuttx/pull/11540 When the MBR partition size exceeds 2 GiB, a 32-bit wrap-around occurs, causing an error in the block count calculation. * wrong brw-rw-rw- 5150605312 mmcblk0 brw-rw-rw- 629145600

[I] ESP32S3: SPI cannot use. [nuttx]

2024-01-13 Thread via GitHub
w2016561536 opened a new issue, #11539: URL: https://github.com/apache/nuttx/issues/11539 ## Problem: Use system spitool, the spi bus cannot be got. ![0240113175904](https://github.com/apache/nuttx/assets/40821031/e860c9a5-bf93-415f-a791-12612f550fe0) ## Config: ``

(nuttx-apps) branch master updated: Wasm.mk: disable by default

2024-01-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 893074383 Wasm.mk: disable by default 893

Re: [PR] Wasm.mk: disable by default [nuttx-apps]

2024-01-13 Thread via GitHub
xiaoxiang781216 merged PR #2065: URL: https://github.com/apache/nuttx-apps/pull/2065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(nuttx-apps) branch master updated: nsh syscmds: add CONFIG_RPTUN_PING when use rptun_ping

2024-01-13 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 7047fa5bd nsh syscmds: add CONFIG_RPTUN_P

Re: [PR] nsh syscmds: add CONFIG_RPTUN_PING when use rptun_ping [nuttx-apps]

2024-01-13 Thread via GitHub
xiaoxiang781216 merged PR #2259: URL: https://github.com/apache/nuttx-apps/pull/2259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] decoupling rptun ping and rptun_virtio_device, rptun ping and rptun. [nuttx]

2024-01-13 Thread via GitHub
raiden00pl commented on code in PR #11537: URL: https://github.com/apache/nuttx/pull/11537#discussion_r1451397335 ## drivers/rptun/Kconfig: ## @@ -38,11 +45,4 @@ config RPTUN_PM goto RAM-retention mode, can't access from another CPU. So, we provid

Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]

2024-01-13 Thread via GitHub
raiden00pl commented on code in PR #11536: URL: https://github.com/apache/nuttx/pull/11536#discussion_r1451395414 ## include/nuttx/rptun/rptun.h: ## @@ -30,7 +30,9 @@ #ifdef CONFIG_RPTUN #include -#include +#include Review Comment: I see that this file is added in htt

Re: [PR] rptun: Strip rpmsg and rptun. Extract common rpmsg api in rptun.c to rpmsg.c, rpmsg provide rpmsg_ops to each backend for specific implementation. [nuttx]

2024-01-13 Thread via GitHub
raiden00pl commented on code in PR #11536: URL: https://github.com/apache/nuttx/pull/11536#discussion_r1451390688 ## include/nuttx/rptun/rptun.h: ## @@ -30,7 +30,9 @@ #ifdef CONFIG_RPTUN #include -#include +#include Review Comment: there is no such file in upstream