[PR] arch/risc-v: fix a few typos in comments [nuttx]

2023-12-30 Thread via GitHub
yf13 opened a new pull request, #11469: URL: https://github.com/apache/nuttx/pull/11469 ## Summary fix a few typos in comments ## Impact None ## Testing N/A -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-30 Thread via GitHub
yamt commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1872680677 > > > > why do you want to sort it? why do you want to make it optional? > > > > > > > > > There are two types of sorts: sorted by symbol name or sorted by symbol value(address). B

Re: [PR] Make 64-bit time_t unsigned [nuttx]

2023-12-30 Thread via GitHub
mu578 commented on PR #8201: URL: https://github.com/apache/nuttx/pull/8201#issuecomment-1872680316 Posix time_t is signed as a consensus. Originally it triggered some controversy and debates over whether it should be signed or unsigned, the problem is not new. Why does this consensu

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1872656913 > > > why do you want to sort it? why do you want to make it optional? > > > > > > There are two types of sorts: sorted by symbol name or sorted by symbol value(address)

(nuttx) branch master updated: sim: add assertions on hostfs copy of structures

2023-12-30 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c1c723b162 sim: add assertions on hostfs copy

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 merged PR #11458: URL: https://github.com/apache/nuttx/pull/11458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx-website) branch asf-site updated: Publishing web: 36ddd7c60a8230335eda886c909bc938739114a2 docs: 1ec63e170167fe424ff2b486d378974fbb706a0a

2023-12-30 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new cbd1d9e1 Publishing web: 36ddd7c6

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
yamt commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438664717 ## arch/sim/src/sim/sim_checkhostfstypes.c: ## @@ -0,0 +1,113 @@ +/ + * arch/sim/src/sim/sim_ch

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
yamt commented on PR #11458: URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1872570889 > @yamt please sqaush your patch into one. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
yamt commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438664060 ## arch/sim/src/sim/sim_checkhostfstypes.c: ## @@ -0,0 +1,113 @@ +/ + * arch/sim/src/sim/sim_ch

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on PR #11458: URL: https://github.com/apache/nuttx/pull/11458#issuecomment-1872563665 @yamt please sqaush your patch into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438652938 ## arch/sim/src/sim/sim_checkhostfstypes.c: ## @@ -0,0 +1,113 @@ +/ + * arch/sim/src

(nuttx) branch master updated: make 64-bit time_t back to unsigned

2023-12-30 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 1ec63e1701 make 64-bit time_t back to unsigned

Re: [PR] make 64-bit time_t back to unsigned [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 merged PR #11466: URL: https://github.com/apache/nuttx/pull/11466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] make 64-bit time_t back to unsigned [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on PR #11466: URL: https://github.com/apache/nuttx/pull/11466#issuecomment-1872563309 > @xiaoxiang781216 so which LTP test fails with this change? POSIX does not mandate `time_t` to be signed, so if the test case fails then LTP test case should be updated. O

Re: [PR] make 64-bit time_t back to unsigned [nuttx]

2023-12-30 Thread via GitHub
pkarashchenko commented on PR #11466: URL: https://github.com/apache/nuttx/pull/11466#issuecomment-1872545734 @xiaoxiang781216 so which LTP test fails with this change? POSIX does not mandate `time_t` to be signed, so if the test case fails then LTP test case should be updated. -- This i

Re: [PR] make 64-bit time_t back to unsigned [nuttx]

2023-12-30 Thread via GitHub
fxysunshine commented on PR #11466: URL: https://github.com/apache/nuttx/pull/11466#issuecomment-1872523591 > I mean, does the LTP test fail with unsigned 64-bit `time_t` as #10303 does not state anything about change from unsigned to signed, but is about moving type definitions into a prop

Re: [I] NSH: ps command broken between release 12.0 and 12.1 [nuttx]

2023-12-30 Thread via GitHub
maxikrie commented on issue #11463: URL: https://github.com/apache/nuttx/issues/11463#issuecomment-1872520474 Yes, I noticed this as well. So, I increased the stack size for NSH task `CONFIG_SYSTEM_NSH_STACKSIZE=4096` but I also had to increase the stack size of the init task

Re: [PR] support sorting symbol tables by name [nuttx]

2023-12-30 Thread via GitHub
yamt commented on PR #11448: URL: https://github.com/apache/nuttx/pull/11448#issuecomment-1872503676 > > why do you want to sort it? why do you want to make it optional? > > There are two types of sorts: sorted by symbol name or sorted by symbol value(address). Before the change, the

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
yamt commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438553341 ## arch/sim/src/sim/sim_checknuttxtypes.c: ## @@ -0,0 +1,100 @@ +/ + * arch/sim/src/sim/sim_che

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
yamt commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438553059 ## arch/sim/src/sim/sim_checknuttxtypes.c: ## @@ -0,0 +1,100 @@ +/ + * arch/sim/src/sim/sim_che

Re: [PR] make 64-bit time_t back to unsigned [nuttx]

2023-12-30 Thread via GitHub
yamt commented on PR #11466: URL: https://github.com/apache/nuttx/pull/11466#issuecomment-1872501264 > > > @yamt #10303 is needed to pass LTP test case. From https://en.wikipedia.org/wiki/Unix_time, most POSIX OS(except 32bit QNX) define time_t to signed integer, so it's better to follow ot

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438542972 ## arch/sim/src/sim/sim_checknuttxtypes.c: ## @@ -0,0 +1,100 @@ +/ + * arch/sim/src/

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438542649 ## arch/sim/src/sim/sim_checknuttxtypes.c: ## @@ -0,0 +1,100 @@ +/ + * arch/sim/src/

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
yamt commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438538394 ## arch/sim/src/sim/sim_checknuttxtypes.c: ## @@ -0,0 +1,100 @@ +/ + * arch/sim/src/sim/sim_che

Re: [PR] adding kernel build for CanMV-K230 device [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on code in PR #11465: URL: https://github.com/apache/nuttx/pull/11465#discussion_r1438534089 ## arch/risc-v/include/k230/irq.h: ## @@ -31,8 +31,16 @@ /* Map RISC-V exception code to NuttX IRQ */ +#ifndef CONFIG_BUILD_KERNEL +#define K230_IRQ_TIMER

Re: [I] [help] confirming ostest output in KERNEL mode [nuttx-apps]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on issue #2246: URL: https://github.com/apache/nuttx-apps/issues/2246#issuecomment-1872493511 @fxysunshine could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(nuttx-apps) branch master updated: nshlib/ifconfig: Let "dns" option depends on `CONFIG_NETDB_DNSCLIENT`

2023-12-30 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 4c0bd143e nshlib/ifconfig: Let "dns" opti

Re: [PR] nshlib/ifconfig: Let "dns" option depend on `CONFIG_NETDB_DNSCLIENT` [nuttx-apps]

2023-12-30 Thread via GitHub
xiaoxiang781216 merged PR #2245: URL: https://github.com/apache/nuttx-apps/pull/2245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] sim: add assertions on hostfs copy of structures [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on code in PR #11458: URL: https://github.com/apache/nuttx/pull/11458#discussion_r1438531464 ## arch/sim/src/sim/sim_checknuttxtypes.c: ## @@ -0,0 +1,100 @@ +/ + * arch/sim/src/

Re: [PR] make 64-bit time_t back to unsigned [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on PR #11466: URL: https://github.com/apache/nuttx/pull/11466#issuecomment-1872491916 > Is the LTP test a part of the CI run? We run LTP internally, and plan to enable it on github In 24Q1. > LGTM! Let's merge the change if the LTP test pass

Re: [PR] make 64-bit time_t back to unsigned [nuttx]

2023-12-30 Thread via GitHub
xiaoxiang781216 commented on PR #11466: URL: https://github.com/apache/nuttx/pull/11466#issuecomment-1872491710 > > @yamt #10303 is needed to pass LTP test case. From https://en.wikipedia.org/wiki/Unix_time, most POSIX OS(except 32bit QNX) define time_t to signed integer, so it's better to