Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11401: URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428728141 ## boards/Board.mk: ## @@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx libboard$(LIBEXT): $(OBJS) $(CXXOBJS) $(call ARCHIVE, $@, $(OBJS) $(CXXOBJS))

Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #11401: URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428719216 ## boards/Board.mk: ## @@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx libboard$(LIBEXT): $(OBJS) $(CXXOBJS) $(call ARCHIVE, $@, $(OBJS)

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on PR #11379: URL: https://github.com/apache/nuttx/pull/11379#issuecomment-1858730276 @xiaoxiang781216 `ARCH_RV_MMIO_BITS` option has been used in `riscv_mtimer.c`, please let me know if there is anything else. -- This is an automated message from the Apache Git Service. T

Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11401: URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428692786 ## boards/Board.mk: ## @@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx libboard$(LIBEXT): $(OBJS) $(CXXOBJS) $(call ARCHIVE, $@, $(OBJS) $(CXXOBJS))

(nuttx) branch master updated: tcp: Recover from iob shortage with TCP_WRITE_BUFFERS

2023-12-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 06e5b661ed tcp: Recover from iob shortage with

Re: [PR] tcp: Recover from iob shortage with TCP_WRITE_BUFFERS [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 merged PR #11406: URL: https://github.com/apache/nuttx/pull/11406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1858706861 > > > > @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix i

Re: [PR] examples/rmtchar: Implement RX and/or TX using the RMT char driver [nuttx-apps]

2023-12-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #2232: URL: https://github.com/apache/nuttx-apps/pull/2232#discussion_r1428665819 ## examples/rmtchar/rmtchar_receiver.c: ## @@ -0,0 +1,137 @@ +/ + * apps/examples

Re: [PR] fix etctmp.c and etctmp/ leakage [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #11401: URL: https://github.com/apache/nuttx/pull/11401#discussion_r1428670725 ## boards/Board.mk: ## @@ -87,6 +87,7 @@ $(CXXOBJS) $(LINKOBJS): %$(OBJEXT): %.cxx libboard$(LIBEXT): $(OBJS) $(CXXOBJS) $(call ARCHIVE, $@, $(OBJS)

Re: [PR] boards/riscv: Add support for PINE64 Ox64 BL808 SBC [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 merged PR #11377: URL: https://github.com/apache/nuttx/pull/11377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: boards/riscv: Add support for PINE64 Ox64 BL808 SBC

2023-12-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 87c1b81857 boards/riscv: Add support for PINE6

Re: [PR] netdev/ipv6: Move `xxx_ipv6multicast` from arch to common code [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #11378: URL: https://github.com/apache/nuttx/pull/11378#discussion_r1428649223 ## net/icmpv6/Kconfig: ## @@ -8,6 +8,7 @@ menu "ICMPv6 Networking Support" config NET_ICMPv6 bool "Enable ICMPv6 networking" default n +

Re: [PR] net/netdev: Modify the logic for setting the IFF_RUNNING status of interfaces. [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 merged PR #11396: URL: https://github.com/apache/nuttx/pull/11396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: net/netdev: Modify the logic for setting the IFF_RUNNING status of interfaces.

2023-12-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 98e3615b60 net/netdev: Modify the logic for se

(nuttx) branch master updated: mpfs_pmpcfg: Move PMPCFG registers to common location

2023-12-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 986a79b231 mpfs_pmpcfg: Move PMPCFG registers

Re: [PR] mpfs_pmpcfg: Move PMPCFG registers to common location [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 merged PR #11403: URL: https://github.com/apache/nuttx/pull/11403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated (fbd8a2127a -> baea0012e7)

2023-12-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from fbd8a2127a mpfs_ethernet.c: Remove DMA_ENABLE hack add baea0012e7 mpfs_usb.c: Use kernel memory instead of user

Re: [PR] mpfs_usb.c: Use kernel memory instead of user memory for DMA [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 merged PR #11404: URL: https://github.com/apache/nuttx/pull/11404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

(nuttx) branch master updated: mpfs_ethernet.c: Remove DMA_ENABLE hack

2023-12-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new fbd8a2127a mpfs_ethernet.c: Remove DMA_ENABLE

Re: [PR] mpfs_ethernet.c: Remove DMA_ENABLE hack [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 merged PR #11405: URL: https://github.com/apache/nuttx/pull/11405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1428610566 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1428610566 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] boards/riscv: Add support for PINE64 Ox64 BL808 SBC [nuttx]

2023-12-15 Thread via GitHub
robertlipe commented on code in PR #11377: URL: https://github.com/apache/nuttx/pull/11377#discussion_r1428610015 ## boards/risc-v/bl808/ox64/src/bl808_appinit.c: ## @@ -0,0 +1,167 @@ +/ + * boards/risc-

(nuttx-website) branch asf-site updated: Publishing web: 36ddd7c60a8230335eda886c909bc938739114a2 docs: 9483729328d4aa2986a94aa38668495fbe113b93

2023-12-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 4839eec4 Publishing web: 36ddd7c6

Re: [PR] boards/riscv: Add support for PINE64 Ox64 BL808 SBC [nuttx]

2023-12-15 Thread via GitHub
lupyuen commented on code in PR #11377: URL: https://github.com/apache/nuttx/pull/11377#discussion_r1428602976 ## boards/risc-v/bl808/ox64/src/bl808_appinit.c: ## @@ -0,0 +1,167 @@ +/ + * boards/risc-v/b

[PR] examples/rmtchar: Implement RX and/or TX using the RMT char driver [nuttx-apps]

2023-12-15 Thread via GitHub
tmedicci opened a new pull request, #2232: URL: https://github.com/apache/nuttx-apps/pull/2232 ## Summary * examples/rmtchar: Implement RX and/or TX using the RMT char driver The RMT (remote control) character driver is used to send and/or receive data packets. Eventually, this

[PR] tcp: Recover from iob shortage with TCP_WRITE_BUFFERS [nuttx]

2023-12-15 Thread via GitHub
PetteriAimonen opened a new pull request, #11406: URL: https://github.com/apache/nuttx/pull/11406 ## Summary When `CONFIG_NET_TCP_WRITE_BUFFERS` is enabled, iobs are used for both queuing data from application, and for assembling packets for sending. If there is a system-wide shortag

Re: [PR] upgrade llvm version to 17.0.6 [nuttx]

2023-12-15 Thread via GitHub
trns1997 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1858046399 > > > @trns1997 I have your patch which could pass ci now. sim:matter is disabled because CMake script need be modified to work with new libcxx. @zhhyu7 and @xuxin930 will fix it tomorro

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

[PR] mpfs_ethernet.c: Remove DMA_ENABLE hack [nuttx]

2023-12-15 Thread via GitHub
pussuw opened a new pull request, #11405: URL: https://github.com/apache/nuttx/pull/11405 ## Summary The hack just opens the entire SoC memory unconditionally, which is not a good idea. Test features can be used ad-hoc, they don't need to be supported by the build. ## Impact

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

Re: [PR] risc-v: Initial support for CanMV-k230 board [nuttx]

2023-12-15 Thread via GitHub
yf13 commented on code in PR #11379: URL: https://github.com/apache/nuttx/pull/11379#discussion_r1427844470 ## arch/risc-v/src/common/riscv_mtimer.c: ## @@ -83,7 +83,7 @@ static const struct oneshot_operations_s g_riscv_mtimer_ops = #ifndef CONFIG_ARCH_USE_S_MODE static uint64

[PR] mpfs_usb.c: Use kernel memory instead of user memory for DMA [nuttx]

2023-12-15 Thread via GitHub
pussuw opened a new pull request, #11404: URL: https://github.com/apache/nuttx/pull/11404 ## Summary DMA directly to user (virtual) memory won't work, as the DMA engine(s) don't do address translations, i.e. they require a physical address. Using kernel heap is fine as it is mapped

[PR] mpfs_pmpcfg: Move PMPCFG registers to common location [nuttx]

2023-12-15 Thread via GitHub
pussuw opened a new pull request, #11403: URL: https://github.com/apache/nuttx/pull/11403 ## Summary Move MPUCFG register definitions into common header ## Impact Cosmetic ## Testing CI pass -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Support gdbstub kernal debugging [nuttx]

2023-12-15 Thread via GitHub
raiden00pl commented on PR #11350: URL: https://github.com/apache/nuttx/pull/11350#issuecomment-1857616156 > According to the ARM manual, when using swo/jtag for debugging, the internal DWT and FPB modules are disabled. Could you provide the source in manual ? Maybe this is a vendo

[PR] syslog/ramlog: improve ramlog performance [nuttx]

2023-12-15 Thread via GitHub
anchao opened a new pull request, #11402: URL: https://github.com/apache/nuttx/pull/11402 ## Summary syslog/ramlog: improve ramlog performance replace char copy to memcpy to improve the performance ## Impact N/A ## Testing ci-check -- This is an au

Re: [PR] Support gdbstub kernal debugging [nuttx]

2023-12-15 Thread via GitHub
raiden00pl commented on PR #11350: URL: https://github.com/apache/nuttx/pull/11350#issuecomment-1857578729 @anjiahao1 https://github.com/apache/nuttx/blob/9483729328d4aa2986a94aa38668495fbe113b93/arch/arm/src/armv7-m/arm_dbgmonitor.c#L95 this line resets all breakpoints set before

Re: [PR] net/netdev: Modify the logic for setting the IFF_RUNNING status of interfaces. [nuttx]

2023-12-15 Thread via GitHub
liqinhuixm commented on code in PR #11396: URL: https://github.com/apache/nuttx/pull/11396#discussion_r1427706473 ## arch/risc-v/src/esp32c3/esp32c3_wlan.c: ## @@ -1462,27 +1462,18 @@ static void wlan_softap_tx_done(uint8_t *data, uint16_t *len, bool status) #ifdef ESP32C3_WLA

Re: [PR] net/netdev: Modify the logic for setting the IFF_RUNNING status of interfaces. [nuttx]

2023-12-15 Thread via GitHub
liqinhuixm commented on code in PR #11396: URL: https://github.com/apache/nuttx/pull/11396#discussion_r1427701808 ## arch/xtensa/src/esp32s3/esp32s3_wlan.c: ## @@ -1452,27 +1452,18 @@ static void wlan_softap_tx_done(uint8_t *data, uint16_t *len, bool status) #ifdef ESP32S3_WLA

Re: [PR] net/netdev: Modify the logic for setting the IFF_RUNNING status of interfaces. [nuttx]

2023-12-15 Thread via GitHub
liqinhuixm commented on code in PR #11396: URL: https://github.com/apache/nuttx/pull/11396#discussion_r1427701808 ## arch/xtensa/src/esp32s3/esp32s3_wlan.c: ## @@ -1452,27 +1452,18 @@ static void wlan_softap_tx_done(uint8_t *data, uint16_t *len, bool status) #ifdef ESP32S3_WLA

Re: [PR] Support gdbstub kernal debugging [nuttx]

2023-12-15 Thread via GitHub
raiden00pl commented on PR #11350: URL: https://github.com/apache/nuttx/pull/11350#issuecomment-1857479846 @anjiahao1 `b-g431b-esc1` is also broken. Tested with JLink and STLink, SDW only. So it's possible that breakpoints for more upstream boards are broken now. -- This is an automat

Re: [PR] net/netdev: Modify the logic for setting the IFF_RUNNING status of interfaces. [nuttx]

2023-12-15 Thread via GitHub
xiaoxiang781216 commented on code in PR #11396: URL: https://github.com/apache/nuttx/pull/11396#discussion_r1427672639 ## arch/xtensa/src/esp32s3/esp32s3_wlan.c: ## @@ -1452,27 +1452,18 @@ static void wlan_softap_tx_done(uint8_t *data, uint16_t *len, bool status) #ifdef ESP32S