xiaoxiang781216 commented on issue #10912:
URL: https://github.com/apache/nuttx/issues/10912#issuecomment-1763284840
@davids5 is more familiar chip driver than me, do you have any suggestion?
@davids5 .
--
This is an automated message from the Apache Git Service.
To respond to the message
xiaoxiang781216 commented on code in PR #10602:
URL: https://github.com/apache/nuttx/pull/10602#discussion_r1359764221
##
libs/libc/stdio/lib_libfread_unlocked.c:
##
@@ -213,9 +215,9 @@ ssize_t lib_fread_unlocked(FAR void *ptr, size_t count, FAR
FILE *stream)
xiaoxiang781216 commented on code in PR #10911:
URL: https://github.com/apache/nuttx/pull/10911#discussion_r1359764037
##
arch/arm/src/imxrt/imxrt_serial.c:
##
@@ -60,6 +60,24 @@
#ifdef USE_SERIALDRIVER
+#if defined(SERIAL_HAVE_TXDMA)
Review Comment:
```suggestion
#i
xiaoxiang781216 commented on PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#issuecomment-1763269226
> > @TaiJuWu please squash the change into one patch.
>
> I prefer maintaining two commits of this PR. The reason is the first one
commit is implementations of rw lock. The
xiaoxiang781216 commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1359755758
##
sched/irq/irq_spinlock.c:
##
@@ -45,6 +45,17 @@ static volatile spinlock_t g_irq_spin = SP_UNLOCKED;
static volatile uint8_t g_irq_spin_count[CONFIG_SMP_N
danielappiagyei-bc commented on issue #10912:
URL: https://github.com/apache/nuttx/issues/10912#issuecomment-1763226964
I have a [PR](https://github.com/apache/nuttx/pull/10911) up which fixes the
overrun in `imxrt_dma_nextrx()`. The other half of the fix which I haven't
included in the PR
danielappiagyei-bc opened a new issue, #10912:
URL: https://github.com/apache/nuttx/issues/10912
## Bug description
When using the LPUART serial driver with DMA for RX, I am seeing several
dropped, missing, or otherwise incorrect bytes in the rxfifo (`g_lpuartXfifo`)
the DMA places bytes
danielappiagyei-bc opened a new pull request, #10911:
URL: https://github.com/apache/nuttx/pull/10911
## Summary
TODO
## Impact
TODO
## Testing
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new f3fefac8 Publishing web: 290961ea
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1359587912
##
sched/Kconfig:
##
@@ -318,6 +318,12 @@ config TICKET_SPINLOCK
endif # SPINLOCK
+config RW_SPINLOCK
+ bool "Support read-write Spinlocks"
+ default y
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1359587912
##
sched/Kconfig:
##
@@ -318,6 +318,12 @@ config TICKET_SPINLOCK
endif # SPINLOCK
+config RW_SPINLOCK
+ bool "Support read-write Spinlocks"
+ default y
TaiJuWu commented on PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#issuecomment-1763102461
> @TaiJuWu please squash the change into one patch.
I prefer to maintain two commits of this PR.
The reason is the first one commit is implementations of rw lock.
The second is
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 1b257137 Publishing web: 290961ea
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/master by this push:
new 290961ea Add ligd to contributors
2909
xiaoxiang781216 merged PR #101:
URL: https://github.com/apache/nuttx-website/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr..
xiaoxiang781216 merged PR #10910:
URL: https://github.com/apache/nuttx/pull/10910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 2be45a3391 Update Fix more generic for platfor
xiaoxiang781216 commented on PR #10496:
URL: https://github.com/apache/nuttx/pull/10496#issuecomment-1763059015
> This operation causes a deadlock because of the critical section of
[`esp32s3_phy_enable`](https://github.com/apache/nuttx/blob/1989749850eff1b57bf543983ddffbdc8307d071/arch/xten
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 095c32b0eb Add a stepper generic upperhalf driver Add a stepper A4988
lowerhalf driver
add 73ca090ab9 filemtd:
xiaoxiang781216 commented on PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#issuecomment-1763058232
@TaiJuWu please squash the change into one patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 merged PR #10909:
URL: https://github.com/apache/nuttx/pull/10909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
xiaoxiang781216 commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1359495720
##
include/nuttx/spinlock.h:
##
@@ -32,6 +32,14 @@
#include
+#ifdef CONFIG_RW_SPINLOCK
+#include
+typedef atomic_int rwlock_t;
Review Comment:
Ok
acassis commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1763033389
> > This way the drive will become more generic over the time and eventually
it will be easier to integrate both. I know the immediate thought is the driver
could become more complex over
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 095c32b0eb Add a stepper generic upperhalf drive
acassis merged PR #10902:
URL: https://github.com/apache/nuttx/pull/10902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
acassis closed issue #10903: Stepper control
URL: https://github.com/apache/nuttx/issues/10903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
GUIDINGLI commented on PR #8672:
URL: https://github.com/apache/nuttx/pull/8672#issuecomment-1762883632
@acassis
Hi,
What problem can this patch solve ? Maybe match my problems.
Can you give out the details, thanks.
--
This is an automated message from the Apache Git Service.
simbit18 commented on PR #10910:
URL: https://github.com/apache/nuttx/pull/10910#issuecomment-1762875724
@xiaoxiang781216 @acassis I updated #10905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
simbit18 commented on PR #10905:
URL: https://github.com/apache/nuttx/pull/10905#issuecomment-1762870805
Sorry, there was a mistake in this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
simbit18 closed pull request #10905: Fix more generic for platforms that do not
have execinfo.h
URL: https://github.com/apache/nuttx/pull/10905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
simbit18 opened a new pull request, #10910:
URL: https://github.com/apache/nuttx/pull/10910
Summary
Simulator build fails on non-GLIBC platform #5621 #5623.
On platforms where the execinfo.h file is missing, the Gnulib substitute
implementation is just a stub, and does nothing.
http
tmedicci commented on PR #10496:
URL: https://github.com/apache/nuttx/pull/10496#issuecomment-1762851740
> You can see that the problem is caused by mixed using `up_irq_save` and
`enter_critical_section`. Is this a permitted pattern?
>
> * if it is, then this PR is needed to fix up.
simbit18 commented on code in PR #10905:
URL: https://github.com/apache/nuttx/pull/10905#discussion_r1359325887
##
arch/sim/src/sim/posix/sim_hostmisc.c:
##
@@ -90,10 +90,10 @@ void host_abort(int status)
int host_backtrace(void** array, int size)
{
-#ifdef CONFIG_WINDOWS_CY
simbit18 commented on code in PR #10905:
URL: https://github.com/apache/nuttx/pull/10905#discussion_r1359325887
##
arch/sim/src/sim/posix/sim_hostmisc.c:
##
@@ -90,10 +90,10 @@ void host_abort(int status)
int host_backtrace(void** array, int size)
{
-#ifdef CONFIG_WINDOWS_CY
34 matches
Mail list logo
