[nuttx] branch master updated: refine: move BIT Macro to nuttx/bits.h

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 061be5f18e refine: move BIT Macro to nuttx/bit

Re: [PR] refine: move BIT Macro to nuttx/bits.h [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10892: URL: https://github.com/apache/nuttx/pull/10892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Opensbi 1.3.1 [nuttx]

2023-10-11 Thread via GitHub
eenurkka closed pull request #10900: Opensbi 1.3.1 URL: https://github.com/apache/nuttx/pull/10900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[PR] Opensbi 1.3.1 [nuttx]

2023-10-11 Thread via GitHub
eenurkka opened a new pull request, #10900: URL: https://github.com/apache/nuttx/pull/10900 ## Summary Update to OpenSBI 1.3.1 ## Impact src/mpfs_domain.c needs also the following flag: mpfs_domains[i].fw_region_inited = true; ## Testing Saluki-v2 with l

[nuttx] branch master updated (4967de8621 -> 602c644f4d)

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4967de8621 ramlog: remove sched_[un]lock and rl_nwaiters add 602c644f4d netdb: When set a dns nameserver, if th

Re: [PR] netdb: When set a dns nameserver which already exists, retrun OK [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10894: URL: https://github.com/apache/nuttx/pull/10894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] testing: Swith up_perf_xxx to perf_xxx [nuttx-apps]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on PR #2108: URL: https://github.com/apache/nuttx-apps/pull/2108#issuecomment-1758874882 ok, I incorporate your change into this pr. @pkarashchenko please review the change again. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] arm64: Add support for FIQ interrupts [nuttx]

2023-10-11 Thread via GitHub
hujun260 commented on PR #10888: URL: https://github.com/apache/nuttx/pull/10888#issuecomment-1758866487 > @hujun260 > > Can you add a qemu configuration to test this PR? ok，use this boards/arm64/qemu/qemu-armv8a/configs/nsh_fiq/defconfig -- This is an automated message from

Re: [PR] testing: Swith up_perf_xxx to perf_xxx [nuttx-apps]

2023-10-11 Thread via GitHub
TaiJuWu commented on PR #2108: URL: https://github.com/apache/nuttx-apps/pull/2108#issuecomment-1758861901 > > I found a bug about workqueue and already send a PR to your branch of this PR. Please review. Thanks a lot. > > where is it? https://github.com/xiaoxiang781216/incubat

Re: [PR] testing: Swith up_perf_xxx to perf_xxx [nuttx-apps]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on PR #2108: URL: https://github.com/apache/nuttx-apps/pull/2108#issuecomment-1758858341 > I found a bug about workqueue and already send a PR to your branch of this PR. Please review. Thanks a lot. where is it? -- This is an automated message from the Apa

Re: [PR] arm64: Add support for FIQ interrupts [nuttx]

2023-10-11 Thread via GitHub
hujun260 commented on PR #10888: URL: https://github.com/apache/nuttx/pull/10888#issuecomment-1758851407 > @hujun260 > > Can you add a qemu configuration to test this PR? To compile Arm64 NuttX, you can use the following command: ./tools/configure.sh -l qemu-armv8a:nsh

Re: [PR] testing: Swith up_perf_xxx to perf_xxx [nuttx-apps]

2023-10-11 Thread via GitHub
TaiJuWu commented on PR #2108: URL: https://github.com/apache/nuttx-apps/pull/2108#issuecomment-1758840050 I found a bug about workqueue and already send a PR to your branch of this PR. Please review. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] smp: irq_csection: enable irq to process the pending pause request [nuttx]

2023-10-11 Thread via GitHub
masayuki2009 commented on PR #10496: URL: https://github.com/apache/nuttx/pull/10496#issuecomment-1758833667 > The bad news is, with the change this issue can not be reproduced, although the change has been limit to minimum range. @chirping78 I think you should not use `up_putc()`

Re: [PR] osperf: replace up_perf_xx with perf_xx [nuttx-apps]

2023-10-11 Thread via GitHub
TaiJuWu closed pull request #2115: osperf: replace up_perf_xx with perf_xx URL: https://github.com/apache/nuttx-apps/pull/2115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] osperf: replace up_perf_xx with perf_xx [nuttx-apps]

2023-10-11 Thread via GitHub
TaiJuWu opened a new pull request, #2115: URL: https://github.com/apache/nuttx-apps/pull/2115 reference: https://github.com/apache/nuttx/pull/10834/commits ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond t

[nuttx-apps] branch master updated: dhcp6c: Add the renew6 command for dhcp6c.

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 79e872274 dhcp6c: Add the renew6 command

Re: [PR] dhcp6c: Add the renew6 command for dhcp6c. [nuttx-apps]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #2114: URL: https://github.com/apache/nuttx-apps/pull/2114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[nuttx] branch master updated (3d6e893215 -> 4967de8621)

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 3d6e893215 esp32s3: fix the halt issue when esp32s3 wlan has high-speed or long time data transmission. add 49

Re: [PR] ramlog: remove sched_[un]lock and rl_nwaiters [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10890: URL: https://github.com/apache/nuttx/pull/10890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] smp: irq_csection: enable irq to process the pending pause request [nuttx]

2023-10-11 Thread via GitHub
chirping78 commented on PR #10496: URL: https://github.com/apache/nuttx/pull/10496#issuecomment-1758804497 I tried to print the cpu/pid of the task which has disabled IRQ with following changed `up_irq_save`. Please note that: - the changed part is closed in `#if 1` and `#endif`

[nuttx] branch master updated (c166c98e0c -> 3d6e893215)

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c166c98e0c arch: x86_64: Fix idle stack assignment add 3d6e893215 esp32s3: fix the halt issue when esp32s3 wlan

Re: [PR] Fix the os halt issue when esp32s3 wlan has high-speed or long time d… [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10882: URL: https://github.com/apache/nuttx/pull/10882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[nuttx] branch master updated: arch: x86_64: Fix idle stack assignment

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c166c98e0c arch: x86_64: Fix idle stack assign

Re: [PR] arch: x86_64: Fix idle stack assignment [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10899: URL: https://github.com/apache/nuttx/pull/10899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[nuttx-website] branch asf-site updated: Publishing web: 07abea83aab63736f2895f109c448ae631509f46 docs: ef739161b7e2deceac55102b3600b7431060f1c9

2023-10-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 55e25b03 Publishing web: 07abea83

Re: [I] How to print filename and line by assert [nuttx]

2023-10-11 Thread via GitHub
SPRESENSE commented on issue #10416: URL: https://github.com/apache/nuttx/issues/10416#issuecomment-1758684786 I think that `assert()` should print the filename and line without `CONFIG_DEBUG`. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[PR] arch: x86_64: Fix idle stack assignment [nuttx]

2023-10-11 Thread via GitHub
spiriou opened a new pull request, #10899: URL: https://github.com/apache/nuttx/pull/10899 ## Summary `qemu-intel64` init does not work properly due to invalid stack initialization. `g_idle_topstack` is a variable, it's content must be moved to `rsp`. ## Impact Determ

[I] Adding signal handing for SEGV/BUS/... [nuttx]

2023-10-11 Thread via GitHub
nealef opened a new issue, #10898: URL: https://github.com/apache/nuttx/issues/10898 I have been investigating signal handling in NuttX for SEGV/BUS/… for armv7-m. I have got some PoC code written (for a backlevel NuttX) that, while I’m in the interrupt handler, will schedule a signal handl

Re: [PR] examples/sensor_fusion: Support for Madgwick Fusion lib and example [nuttx-apps]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #2113: URL: https://github.com/apache/nuttx-apps/pull/2113#discussion_r1355461856 ## examples/sensor_fusion/sensor_fusion_main.c: ## @@ -0,0 +1,157 @@ +/ + * apps/

Re: [PR] examples/sensor_fusion: Support for Madgwick Fusion lib and example [nuttx-apps]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on PR #2113: URL: https://github.com/apache/nuttx-apps/pull/2113#issuecomment-1758176682 @fdcavalcanti Mixed case could be ignored for the 3rd party library. But please fix other ci issue. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10885: URL: https://github.com/apache/nuttx/pull/10885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] arch/arm/src/mx8mp/Kconfig: Fix Kconfig style [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10897: URL: https://github.com/apache/nuttx/pull/10897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[nuttx] branch master updated: arch/arm/src/mx8mp/Kconfig: Fix Kconfig style

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f22cff9b0b arch/arm/src/mx8mp/Kconfig: Fix Kco

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1355420863 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

[nuttx] branch master updated (99eeaafd07 -> 9c59ee7c58)

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 99eeaafd07 lib_memfd: turn a runtime error into a linker error new 8ddaa3460d note: simplify the shced_note hea

[nuttx] 01/02: note: simplify the shced_note header file

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 8ddaa3460da7b42f7770cc339428444105b31d02 Author: yinshengkai AuthorDate: Tue Oct 10 22:45:01 2023 +0800 note: sim

Re: [PR] optimize note performance [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10840: URL: https://github.com/apache/nuttx/pull/10840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[nuttx] 02/02: note: optimize note performance and reduce lib_sprintf calls

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 9c59ee7c58f2407e7e039137644102e33dcb955f Author: yinshengkai AuthorDate: Tue Oct 10 22:45:02 2023 +0800 note: opt

[nuttx] branch master updated: lib_memfd: turn a runtime error into a linker error

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 99eeaafd07 lib_memfd: turn a runtime error int

Re: [PR] lib_memfd: turn a runtime error into a linker error [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10891: URL: https://github.com/apache/nuttx/pull/10891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] netdb: When set a dns nameserver which already exists, retrun OK [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on PR #10894: URL: https://github.com/apache/nuttx/pull/10894#issuecomment-1757981384 > Seems ok to me! Just a question: how to fix the issue when the resolve.conf is with incorrect DNS and that function returns -EEXIST ? -EEXIT is returned by dns_check_names

[nuttx] branch master updated: net: allow icmpv6 and udp to find the dev by the ifindex with s_boundto.

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3f08f32486 net: allow icmpv6 and udp to find t

Re: [PR] net: allow icmpv6 and udp to find the dev by the ifindex with s_boundto. [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10893: URL: https://github.com/apache/nuttx/pull/10893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] netdb: When set a dns nameserver which already exists, retrun OK [nuttx]

2023-10-11 Thread via GitHub
acassis commented on PR #10894: URL: https://github.com/apache/nuttx/pull/10894#issuecomment-1757808474 Seems ok to me! Just a question: how to fix the issue when the resolve.conf is with incorrect DNS and that function returns -EEXIST ? -- This is an automated message from the Apache Git

[PR] arch/arm/src/mx8mp/Kconfig: Fix Kconfig style [nuttx]

2023-10-11 Thread via GitHub
simbit18 opened a new pull request, #10897: URL: https://github.com/apache/nuttx/pull/10897 ## Summary Remove extra TABs Add comments ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[I] Multi-users support and Privilegies separation on NuttX [nuttx]

2023-10-11 Thread via GitHub
acassis opened a new issue, #10896: URL: https://github.com/apache/nuttx/issues/10896 NuttX currently supports functions related to multi-users like chown, chmod, etc, however we don't have yet multi-user support neither privileges separation for users (even in Protected or Kernel mode).

Re: [I] usleep accuracy [nuttx]

2023-10-11 Thread via GitHub
acassis commented on issue #8207: URL: https://github.com/apache/nuttx/issues/8207#issuecomment-1757751141 @maxikrie @xiaoxiang781216 I think there is a missing action here to submit a fix, correct? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] Photon P0 WiFi not functional [nuttx]

2023-10-11 Thread via GitHub
acassis commented on issue #8839: URL: https://github.com/apache/nuttx/issues/8839#issuecomment-1757747254 @TheCranston I think I missed your last comment. Yes, maybe the driver needs to have more improvements to work after the sleep/wake-up. BTW I suggest you closing this issue here (since

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1355036583 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1355026545 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354888374 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354880734 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,388 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354854525 ## boards/xtensa/esp32s3/esp32s3-eye/include/board.h: ## @@ -43,4 +43,10 @@ #define BOARD_NLEDS 1 +/* GPIO pins used by the GPIO Subsystem */ + +#defi

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on PR #10885: URL: https://github.com/apache/nuttx/pull/10885#issuecomment-1757538494 > please add commit message done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354851897 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,390 @@ +/ + * boards

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
casaroli commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354847635 ## boards/xtensa/esp32s3/esp32s3-eye/include/board.h: ## @@ -43,4 +43,10 @@ #define BOARD_NLEDS 1 +/* GPIO pins used by the GPIO Subsystem */ + +#defi

Re: [PR] ESP32S3-EYE: GPIO and button support [nuttx]

2023-10-11 Thread via GitHub
tmedicci commented on code in PR #10885: URL: https://github.com/apache/nuttx/pull/10885#discussion_r1354823843 ## boards/xtensa/esp32s3/esp32s3-eye/src/esp32s3_gpio.c: ## @@ -0,0 +1,390 @@ +/ + * boards

Re: [PR] arm64: Add support for FIQ interrupts [nuttx]

2023-10-11 Thread via GitHub
masayuki2009 commented on PR #10888: URL: https://github.com/apache/nuttx/pull/10888#issuecomment-1757493482 @hujun260 Can you add a qemu configuration to test this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] How to print filename and line by assert [nuttx]

2023-10-11 Thread via GitHub
anchao commented on issue #10416: URL: https://github.com/apache/nuttx/issues/10416#issuecomment-1757382171 I just check the config, `CONFIG_DEBUG_ASSERTIONS_FILENAME` is default y if enable `CONFIG_DEBUG_ASSERTIONS` , the assert file name could be printed if enable `CONFIG_DEBUG_ASSERTIO

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354649450 ## sched/irq/irq_spinlock.c: ## @@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock, irqstate_t flags) up_irq_restore(flags); } +#

[nuttx] branch master updated (66fa229fcc -> 79e5d88f97)

2023-10-11 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 66fa229fcc Fix some typos in comments add 79e5d88f97 feat(esp32s3-eye): wireless No new revisions were added b

Re: [PR] ESP32-S3-EYE: Wifi [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 merged PR #10883: URL: https://github.com/apache/nuttx/pull/10883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354294685 ## sched/irq/irq_spinlock.c: ## @@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock, irqstate_t flags) up_irq_restore(flags); } +#ifdef CO

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354294685 ## sched/irq/irq_spinlock.c: ## @@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock, irqstate_t flags) up_irq_restore(flags); } +#ifdef CO

Re: [PR] optimize note performance [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #10840: URL: https://github.com/apache/nuttx/pull/10840#discussion_r1354485430 ## drivers/note/noteram_driver.c: ## @@ -972,7 +972,44 @@ static int noteram_dump_one(FAR uint8_t *p, FAR struct lib_outstream_s *s, } }

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729 ## include/nuttx/spinlock.h: ## @@ -32,6 +32,14 @@ #include +#ifdef CONFIG_RW_SPINLOCK +#include +typedef atomic_int rwlock_t; Review Comment: It can't. T

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729 ## include/nuttx/spinlock.h: ## @@ -32,6 +32,14 @@ #include +#ifdef CONFIG_RW_SPINLOCK +#include +typedef atomic_int rwlock_t; Review Comment: It can't. T

Re: [PR] lib_memfd: turn a runtime error into a linker error [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #10891: URL: https://github.com/apache/nuttx/pull/10891#discussion_r1354476573 ## libs/libc/misc/lib_memfd.c: ## @@ -73,3 +74,4 @@ int memfd_create(FAR const char *name, unsigned int flags) return ret; #endif } +#endif Review Comment

Re: [I] How to print filename and line by assert [nuttx]

2023-10-11 Thread via GitHub
SPRESENSE commented on issue #10416: URL: https://github.com/apache/nuttx/issues/10416#issuecomment-1757166309 @xiaoxiang781216 @anchao How about this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] dhcp6c: Add the renew6 command for dhcp6c. [nuttx-apps]

2023-10-11 Thread via GitHub
liqinhuixm opened a new pull request, #2114: URL: https://github.com/apache/nuttx-apps/pull/2114 ## Summary Add the renew6 command for dhcp6c. The command can supports two mode Stateless and Stateful. The renew6 is used as follows: - Stateless: renew6 eth0 - Stateful: renew6 e

Re: [I] imxrt/lpi2c multibyte read broken following DMA addition [nuttx]

2023-10-11 Thread via GitHub
thebolt commented on issue #10853: URL: https://github.com/apache/nuttx/issues/10853#issuecomment-1757091866 Upstreaming that driver (and other local changes) is on my list, however at the moment a bit constrained by internal budget. If the issue cannot be resolved timely (and now the

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354294685 ## sched/irq/irq_spinlock.c: ## @@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock, irqstate_t flags) up_irq_restore(flags); } +#ifdef CO

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354294685 ## sched/irq/irq_spinlock.c: ## @@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock, irqstate_t flags) up_irq_restore(flags); } +#ifdef CO

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354294685 ## sched/irq/irq_spinlock.c: ## @@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock, irqstate_t flags) up_irq_restore(flags); } +#ifdef CO

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354295219 ## sched/semaphore/spinlock.c: ## @@ -36,6 +36,11 @@ # include #endif +#ifdef CONFIG_RW_SPINLOCK +# include +const static rwlock_t unlocked = RW_SP_UNLOCKED; R

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354294685 ## sched/irq/irq_spinlock.c: ## @@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock, irqstate_t flags) up_irq_restore(flags); } +#ifdef CO

Re: [PR] refine: move BIT Macro to nuttx/bits.h [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #10892: URL: https://github.com/apache/nuttx/pull/10892#discussion_r1354291443 ## include/nuttx/bits.h: ## @@ -26,46 +26,47 @@ / #include -#include -#includ

Re: [PR] refine: move BIT Macro to nuttx/bits.h [nuttx]

2023-10-11 Thread via GitHub
xiaoxiang781216 commented on code in PR #10892: URL: https://github.com/apache/nuttx/pull/10892#discussion_r1354291443 ## include/nuttx/bits.h: ## @@ -26,46 +26,47 @@ / #include -#include -#includ

Re: [PR] rw spinlock [nuttx]

2023-10-11 Thread via GitHub
TaiJuWu commented on code in PR #10776: URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729 ## include/nuttx/spinlock.h: ## @@ -32,6 +32,14 @@ #include +#ifdef CONFIG_RW_SPINLOCK +#include +typedef atomic_int rwlock_t; Review Comment: It can't. T