[GitHub] [nuttx] raiden00pl commented on pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
raiden00pl commented on PR #10092: URL: https://github.com/apache/nuttx/pull/10092#issuecomment-1667200461 Please reformat your PR and make one commit for board support, and separate commits for USB fix and I2C fix. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
raiden00pl commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285383916 ## boards/arm/nrf52/arduino-nano-33ble/CMakeLists.txt: ## @@ -0,0 +1,21 @@ +# ## Review

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
raiden00pl commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285381691 ## arch/arm/src/nrf52/nrf52_i2c.c: ## @@ -373,7 +374,9 @@ static int nrf52_i2c_transfer(struct i2c_master_s *dev, /* Write number of bytes in TXD buffer *

[GitHub] [nuttx] FASTSHIFT opened a new pull request, #10098: mm_heap: check heap member in advance

2023-08-06 Thread via GitHub
FASTSHIFT opened a new pull request, #10098: URL: https://github.com/apache/nuttx/pull/10098 ## Summary Block wrong address in advance before entering mempool. ## Impact None. ## Testing None. -- This is an automated message from the Apache Git Se

[GitHub] [nuttx] xucheng5 commented on pull request #10097: driver/mtdconfig_fs : return -ENOENT when delete non-existed key

2023-08-06 Thread via GitHub
xucheng5 commented on PR #10097: URL: https://github.com/apache/nuttx/pull/10097#issuecomment-1667146538 > Please remove special tag from commit message Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [nuttx] xucheng5 commented on pull request #10096: fs_open: add ioctl checkflag

2023-08-06 Thread via GitHub
xucheng5 commented on PR #10096: URL: https://github.com/apache/nuttx/pull/10096#issuecomment-1667145710 > Please remove special tag from commit message Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [nuttx] xucheng5 commented on pull request #10095: driver/mtd_config : add mtdconfig_register_by_path()

2023-08-06 Thread via GitHub
xucheng5 commented on PR #10095: URL: https://github.com/apache/nuttx/pull/10095#issuecomment-1667143884 > Please remove special tag from commit message: VELAPLATFO-6827 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [nuttx] anchao commented on pull request #10097: driver/mtdconfig_fs : return -ENOENT when delete non-existed key

2023-08-06 Thread via GitHub
anchao commented on PR #10097: URL: https://github.com/apache/nuttx/pull/10097#issuecomment-1667141245 Please remove special tag from commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [nuttx] anchao commented on pull request #10096: fs_open: add ioctl checkflag

2023-08-06 Thread via GitHub
anchao commented on PR #10096: URL: https://github.com/apache/nuttx/pull/10096#issuecomment-1667140958 Please remove special tag from commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [nuttx] anchao commented on pull request #10095: driver/mtd_config : add mtdconfig_register_by_path()

2023-08-06 Thread via GitHub
anchao commented on PR #10095: URL: https://github.com/apache/nuttx/pull/10095#issuecomment-1667139960 Please remove special tag from commit message: VELAPLATFO-6827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[nuttx] branch master updated (d55e0cce9c -> 98fba71998)

2023-08-06 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from d55e0cce9c Documentation: Add documentation about sim:alsa defconfig new fe6b0619f9 usbdev: Use composite devices

[nuttx] 02/04: composite: return ok when host send a duplicate setconfig message

2023-08-06 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit f52f04e131e7463704a2e008b8304b4ee9b3fd7e Author: zhangyuan21 AuthorDate: Fri Aug 4 14:19:57 2023 +0800 composite: re

[nuttx] 04/04: usbadb: add usbadb boardctl

2023-08-06 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 98fba7199836e617516ee076ca75997212a87a7e Author: zhangyuan21 AuthorDate: Sat Jul 29 16:05:16 2023 +0800 usbadb: add

[nuttx] 03/04: adb: Use composite devices as universal devices

2023-08-06 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 419207d23dbb21bbb411cf59b4648ddd7a107e97 Author: zhangyuan21 AuthorDate: Thu Jul 6 03:17:30 2023 +0800 adb: Use comp

[nuttx] 01/04: usbdev: Use composite devices as universal devices

2023-08-06 Thread archer
This is an automated email from the ASF dual-hosted git repository. archer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fe6b0619f9f06e3692eac7187984ee528a4e541f Author: zhangyuan21 AuthorDate: Wed Jul 5 09:23:26 2023 +0800 usbdev: Use c

[GitHub] [nuttx] anchao merged pull request #10085: usb: add adb boardctl

2023-08-06 Thread via GitHub
anchao merged PR #10085: URL: https://github.com/apache/nuttx/pull/10085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[GitHub] [nuttx] zyfeier commented on pull request #10084: usb: Use composite equipment codes as universal codes for enumeration

2023-08-06 Thread via GitHub
zyfeier commented on PR #10084: URL: https://github.com/apache/nuttx/pull/10084#issuecomment-1667123474 > I don't think coupling USB device class logic with composite device logic is a good idea. These are two separate functionalities, and device class logic should not depend on composite l

[GitHub] [nuttx] xucheng5 opened a new pull request, #10097: driver/mtdconfig_fs : return -ENOENT when delete non-existed key

2023-08-06 Thread via GitHub
xucheng5 opened a new pull request, #10097: URL: https://github.com/apache/nuttx/pull/10097 VELAPLATFO-10121 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nuttx] xucheng5 opened a new pull request, #10096: fs_open: add ioctl checkflag

2023-08-06 Thread via GitHub
xucheng5 opened a new pull request, #10096: URL: https://github.com/apache/nuttx/pull/10096 VELAPLATFO-6198 fixed open error when driver not implement write ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To r

[GitHub] [nuttx] xucheng5 opened a new pull request, #10095: driver/mtd_config : add mtdconfig_register_by_path()

2023-08-06 Thread via GitHub
xucheng5 opened a new pull request, #10095: URL: https://github.com/apache/nuttx/pull/10095 VELAPLATFO-6827 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[nuttx] branch master updated (7884c18620 -> d55e0cce9c)

2023-08-06 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7884c18620 Don't call lib_free in the kernel code add d55e0cce9c Documentation: Add documentation about sim:als

[GitHub] [nuttx] xiaoxiang781216 merged pull request #10093: Documentation: Add documentation about sim:alsa defconfig

2023-08-06 Thread via GitHub
xiaoxiang781216 merged PR #10093: URL: https://github.com/apache/nuttx/pull/10093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[nuttx-website] branch asf-site updated: Publishing web: 07abea83aab63736f2895f109c448ae631509f46 docs: 7884c186208346cf989d28241e4c0eb032c98198

2023-08-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ef388de7 Publishing web: 07abea83

[GitHub] [nuttx] lupyuen opened a new pull request, #10094: boards/risc-v: Add support for PINE64 Star64 JH7110 SBC

2023-08-06 Thread via GitHub
lupyuen opened a new pull request, #10094: URL: https://github.com/apache/nuttx/pull/10094 ## Summary This PR adds support for PINE64 Star64 64-bit RISC-V SBC, based on StarFive JH7110 SoC. Most of the code is derived from NuttX for QEMU RISC-V (Kernel Mode). [The source files are ex

[GitHub] [nuttx] tmedicci opened a new pull request, #10093: Documentation: Add documentation about sim:alsa defconfig

2023-08-06 Thread via GitHub
tmedicci opened a new pull request, #10093: URL: https://github.com/apache/nuttx/pull/10093 ## Summary Add documentation referring to sim:alsa defconfig, about how to mount host system files in the simulator using `hostfs` and playing them using the ALSA adapter. ## Impact

[GitHub] [nuttx] pkarashchenko commented on pull request #10066: Don't call lib_free in the kernel code

2023-08-06 Thread via GitHub
pkarashchenko commented on PR #10066: URL: https://github.com/apache/nuttx/pull/10066#issuecomment-1666924434 There are many places like it. I have changes stashed somewhere and will push change for review soon -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] brian-doherty commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
brian-doherty commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285232524 ## arch/arm/src/nrf52/hardware/nrf52_twi.h: ## @@ -154,7 +154,7 @@ #define TWIM_FREQUENCY_100KBPS (0x0198) /* 100 kbps */ #define TWIM_FREQUE

[GitHub] [nuttx] brian-doherty commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
brian-doherty commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285231902 ## boards/arm/nrf52/arduino-nano-33ble/CMakeLists.txt: ## @@ -0,0 +1,21 @@ +# ## Rev

[GitHub] [nuttx] brian-doherty commented on pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
brian-doherty commented on PR #10092: URL: https://github.com/apache/nuttx/pull/10092#issuecomment-1666893615 > OK I have squashed commits. I have also addressed some of your comments and I have one question. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10066: Don't call lib_free in the kernel code

2023-08-06 Thread via GitHub
xiaoxiang781216 commented on PR #10066: URL: https://github.com/apache/nuttx/pull/10066#issuecomment-1666891642 @acassis esp use the wrong function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [nuttx] brian-doherty commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
brian-doherty commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285230235 ## boards/arm/nrf52/arduino-nano-33ble/scripts/flash_config.ld: ## @@ -0,0 +1,106 @@ +/***

[GitHub] [nuttx] brian-doherty commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
brian-doherty commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285229615 ## arch/arm/src/nrf52/hardware/nrf52_twi.h: ## @@ -154,7 +154,7 @@ #define TWIM_FREQUENCY_100KBPS (0x0198) /* 100 kbps */ #define TWIM_FREQUE

[GitHub] [nuttx] brian-doherty commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
brian-doherty commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285229157 ## arch/arm/src/nrf52/nrf52_i2c.c: ## @@ -373,7 +374,9 @@ static int nrf52_i2c_transfer(struct i2c_master_s *dev, /* Write number of bytes in TXD buffe

[GitHub] [nuttx] mu578 commented on pull request #10066: Don't call lib_free in the kernel code

2023-08-06 Thread via GitHub
mu578 commented on PR #10066: URL: https://github.com/apache/nuttx/pull/10066#issuecomment-1666874313 Speaking of which: https://github.com/apache/nuttx/blob/7884c186208346cf989d28241e4c0eb032c98198/arch/xtensa/src/esp32s3/esp32s3_libc_stubs.c#L146 there is a use of plain mallo

[GitHub] [nuttx] xiaoxiang781216 closed pull request #10017: Use `lib_free` for the memory buffer allocated via `strdup` in `net/procfs/net_procfs.c`

2023-08-06 Thread via GitHub
xiaoxiang781216 closed pull request #10017: Use `lib_free` for the memory buffer allocated via `strdup` in `net/procfs/net_procfs.c` URL: https://github.com/apache/nuttx/pull/10017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [nuttx] acassis merged pull request #10066: Don't call lib_free in the kernel code

2023-08-06 Thread via GitHub
acassis merged PR #10066: URL: https://github.com/apache/nuttx/pull/10066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

[nuttx] branch master updated: Don't call lib_free in the kernel code

2023-08-06 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7884c18620 Don't call lib_free in the kernel cod

[GitHub] [nuttx] pkarashchenko merged pull request #10086: sched: Define sched_getcpu return 0 when CONFIG_SMP equals n

2023-08-06 Thread via GitHub
pkarashchenko merged PR #10086: URL: https://github.com/apache/nuttx/pull/10086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated: sched: Define sched_getcpu return 0 when CONFIG_SMP equals n

2023-08-06 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6289205104 sched: Define sched_getcpu retu

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
raiden00pl commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285180233 ## boards/arm/nrf52/arduino-nano-33ble/scripts/flash_config.ld: ## @@ -0,0 +1,106 @@ +/ +

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
raiden00pl commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285180630 ## boards/arm/nrf52/arduino-nano-33ble/CMakeLists.txt: ## @@ -0,0 +1,21 @@ +# ## Review

[GitHub] [nuttx] raiden00pl commented on a diff in pull request #10092: Board port to Arduino Nano 33 BLE

2023-08-06 Thread via GitHub
raiden00pl commented on code in PR #10092: URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285176464 ## arch/arm/src/nrf52/nrf52_i2c.c: ## @@ -373,7 +374,9 @@ static int nrf52_i2c_transfer(struct i2c_master_s *dev, /* Write number of bytes in TXD buffer *

[GitHub] [nuttx] raiden00pl commented on pull request #10077: sesnor:optimize bmi160 sensor adapt to uorb.

2023-08-06 Thread via GitHub
raiden00pl commented on PR #10077: URL: https://github.com/apache/nuttx/pull/10077#issuecomment-1666771759 I agree that simultaneous support for sensors as char device and with uorb would be ideal. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [nuttx-apps] yamt opened a new pull request, #1897: toywasm: bump the version to v31

2023-08-06 Thread via GitHub
yamt opened a new pull request, #1897: URL: https://github.com/apache/nuttx-apps/pull/1897 ## Summary toywasm: bump the version to v31 ## Impact ## Testing tested on sim/macos/amd64 -- This is an automated message from the Apache Git Service. To respond to the messa