[GitHub] [nuttx] pussuw commented on pull request #9577: riscv/fpu: Implement correct lazy-FPU functionality (attempt #2)

2023-06-20 Thread via GitHub
pussuw commented on PR #9577: URL: https://github.com/apache/nuttx/pull/9577#issuecomment-1600262300 @masayuki2009 Thanks for testing. I think I need to make icicle smp capable so I can test it myself. Is it possible to provide me with the .elf file so I can see where EPC points to (the ill

[GitHub] [nuttx] michallenc commented on pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
michallenc commented on PR #9578: URL: https://github.com/apache/nuttx/pull/9578#issuecomment-1600244437 > But I can't understand why need reset the cache info if only one zoneinfo file exist. Our application has one generic zoneinfo file stored in flash memory. This file can be any

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
xiaoxiang781216 commented on PR #9578: URL: https://github.com/apache/nuttx/pull/9578#issuecomment-1600106669 > ## Summary > Current implementation discards any updates if current timezone name is the same as new timezone name. This works well if every timezone name is different (`Europe

[GitHub] [nuttx] masayuki2009 opened a new pull request, #9582: drivers: virtio: Use one dscriptor for RX in virtio-mmio-net.c

2023-06-20 Thread via GitHub
masayuki2009 opened a new pull request, #9582: URL: https://github.com/apache/nuttx/pull/9582 ## Summary - In this implementation, only one descriptor is used for RX. - NOTE: we still use two descriptors for TX ## Impact - None ## Testing - Tested with qe

[nuttx] branch master updated (9b8eedd218 -> dd0f967798)

2023-06-20 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9b8eedd218 lib_strftime: Also fix %l to avoid printing 0:xx AM/PM add dd0f967798 usrsock_server:fix incompl

[GitHub] [nuttx] pkarashchenko merged pull request #9581: usrsock_server:fix incomplete received data error

2023-06-20 Thread via GitHub
pkarashchenko merged PR #9581: URL: https://github.com/apache/nuttx/pull/9581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[nuttx] branch master updated (1a06f7a2c9 -> 9b8eedd218)

2023-06-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 1a06f7a2c9 libc: memfd_create should create /tmp/memfd/ before creating file new 95f131c3c2 lib_strftime: Fix

[nuttx] 02/02: lib_strftime: Also fix %l to avoid printing 0:xx AM/PM

2023-06-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 9b8eedd2186345b08e55960f1d2e048af4cd4736 Author: Alan Carvalho de Assis AuthorDate: Tue Jun 20 21:36:48 2023 -0300

[nuttx] 01/02: lib_strftime: Fix %I to avoid printing 00:xx AM/PM

2023-06-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 95f131c3c25c10f9a864ba72a7b1586bb31f5df3 Author: Alan Carvalho de Assis AuthorDate: Tue Jun 20 20:35:05 2023 -0300

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9580: lib_strftime: Fix %I to avoid printing 00:xx AM/PM

2023-06-20 Thread via GitHub
xiaoxiang781216 merged PR #9580: URL: https://github.com/apache/nuttx/pull/9580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] wangchen61698 opened a new pull request, #9581: usrsock_server:fix incomplete received data error

2023-06-20 Thread via GitHub
wangchen61698 opened a new pull request, #9581: URL: https://github.com/apache/nuttx/pull/9581 ## Summary usrsock received wrong message to stop receiving the data, however there is remaining data that has not been retrieved. when usrsock receiving data , it checks number of bytes ava

[GitHub] [nuttx] masayuki2009 commented on pull request #9297: virtio: add virtio framework in NuttX

2023-06-20 Thread via GitHub
masayuki2009 commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1599858814 @CV-Bowen BTW, I noticed that mount command failed for the vfat. ``` /home/ishikawa/opensource/QEMU/qemu-7.1/build/qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -m

[GitHub] [nuttx] masayuki2009 commented on pull request #9297: virtio: add virtio framework in NuttX

2023-06-20 Thread via GitHub
masayuki2009 commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1599811267 @CV-Bowen I found the root cause of the issue, my build script removed CONFIG_DEBUG_INFO=y automatically for the test which caused a performance penalty. I'm still not sure why thi

[GitHub] [nuttx] acassis commented on a diff in pull request #9576: sendfile: Fixed behavior of sendfile when count is set to zero.

2023-06-20 Thread via GitHub
acassis commented on code in PR #9576: URL: https://github.com/apache/nuttx/pull/9576#discussion_r1236026431 ## fs/vfs/fs_sendfile.c: ## @@ -244,6 +244,11 @@ static ssize_t copyfile(FAR struct file *outfile, FAR struct file *infile, ssize_t file_sendfile(FAR struct file *outfi

[nuttx-website] branch asf-site updated: Publishing web: bedd222ce647cc428f1f896ea77db286eb1bfbce docs: 1a06f7a2c9d738a146f2f5f28d91e2229707df7d

2023-06-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 9aacb146 Publishing web: bedd222c

[GitHub] [nuttx] acassis commented on pull request #9580: lib_strftime: Fix %I to avoid printing 00:xx AM/PM

2023-06-20 Thread via GitHub
acassis commented on PR #9580: URL: https://github.com/apache/nuttx/pull/9580#issuecomment-1599742223 Fun thing: https://www.theverge.com/2019/6/25/18693533/metric-system-measurement-us-conversion-act-verge-science -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [nuttx] acassis opened a new pull request, #9580: lib_strftime: Fix %I to avoid printing 00:xx AM/PM

2023-06-20 Thread via GitHub
acassis opened a new pull request, #9580: URL: https://github.com/apache/nuttx/pull/9580 ## Summary Currently strftime is print 00:00 AM and 00:00 PM instead of 12:00 AM and 12:00 PM when using %I. This commit fixes this issue ## Impact Users will get time format correct in USA (

[GitHub] [nuttx] acassis commented on pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
acassis commented on PR #9578: URL: https://github.com/apache/nuttx/pull/9578#issuecomment-1599741488 Fixed! https://github.com/apache/nuttx/pull/9580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [nuttx] masayuki2009 commented on pull request #9577: riscv/fpu: Implement correct lazy-FPU functionality (attempt #2)

2023-06-20 Thread via GitHub
masayuki2009 commented on PR #9577: URL: https://github.com/apache/nuttx/pull/9577#issuecomment-1599727907 @pussuw Hmm, ostest with maix-bit:smp (board) still crashes. ``` End of test memory usage: VARIABLE BEFORE AFTER arena 1fb990

[GitHub] [nuttx] acassis commented on pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
acassis commented on PR #9578: URL: https://github.com/apache/nuttx/pull/9578#issuecomment-1599718486 @michallenc talking about time and timezone, I think I found an issue on NuttX, it is generating 00:00 AM/PM (for US people 00:00 never exists, it is always 12:00 AM/PM). I'm using s

[GitHub] [nuttx] fjpanag commented on pull request #9497: libc/fdcheck: add fdcheck module

2023-06-20 Thread via GitHub
fjpanag commented on PR #9497: URL: https://github.com/apache/nuttx/pull/9497#issuecomment-1599562628 @hujun260 Here is what I think it happens: 1. `select()` is called, and uses `fdcheck_restore()`. 2. `select()` is calling `poll()` internally. 3. `poll()` calls `poll_setup()`.

[GitHub] [nuttx] michallenc commented on a diff in pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
michallenc commented on code in PR #9578: URL: https://github.com/apache/nuttx/pull/9578#discussion_r1235805731 ## libs/libc/time/lib_localtime.c: ## @@ -2801,6 +2801,11 @@ void tzset(void) nxrmutex_unlock(&g_lcl_lock); } +void tzreset(void) +{ + strlcpy(g_lcl_tzname, "",

[GitHub] [nuttx] michallenc commented on a diff in pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
michallenc commented on code in PR #9578: URL: https://github.com/apache/nuttx/pull/9578#discussion_r1235803377 ## libs/libc/time/lib_localtime.c: ## @@ -2801,6 +2801,11 @@ void tzset(void) nxrmutex_unlock(&g_lcl_lock); } +void tzreset(void) Review Comment: Where do we

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
pkarashchenko commented on code in PR #9578: URL: https://github.com/apache/nuttx/pull/9578#discussion_r1235720105 ## libs/libc/time/lib_localtime.c: ## @@ -2801,6 +2801,11 @@ void tzset(void) nxrmutex_unlock(&g_lcl_lock); } +void tzreset(void) Review Comment: This see

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
xiaoxiang781216 commented on code in PR #9578: URL: https://github.com/apache/nuttx/pull/9578#discussion_r1235714814 ## libs/libc/time/lib_localtime.c: ## @@ -2801,6 +2801,11 @@ void tzset(void) nxrmutex_unlock(&g_lcl_lock); } +void tzreset(void) +{ + strlcpy(g_lcl_tzname

[nuttx] 01/02: libc: Prefer to implement memfd on top of shm

2023-06-20 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 43f9abf84f7c2b19b74fd0a37b2b5855f1c31136 Author: Xiang Xiao AuthorDate: Mon Jun 12 00:03:55 2023 +0800 libc:

[nuttx] branch master updated (f930b4f6f5 -> 1a06f7a2c9)

2023-06-20 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from f930b4f6f5 Fix Kconfig style new 43f9abf84f libc: Prefer to implement memfd on top of shm new 1a06f7a2

[nuttx] 02/02: libc: memfd_create should create /tmp/memfd/ before creating file

2023-06-20 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 1a06f7a2c9d738a146f2f5f28d91e2229707df7d Author: Xiang Xiao AuthorDate: Sun Jun 11 23:55:51 2023 +0800 libc:

[nuttx-apps] branch master updated: Fix Kconfig style

2023-06-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 83bddd86c Fix Kconfig style 83bddd86c is

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1799: Fix Kconfig style

2023-06-20 Thread via GitHub
xiaoxiang781216 merged PR #1799: URL: https://github.com/apache/nuttx-apps/pull/1799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[nuttx] branch master updated: Fix Kconfig style

2023-06-20 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new f930b4f6f5 Fix Kconfig style f930b4f6f5 is descr

[GitHub] [nuttx] acassis merged pull request #9579: Fix Kconfig style

2023-06-20 Thread via GitHub
acassis merged PR #9579: URL: https://github.com/apache/nuttx/pull/9579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx-apps] simbit18 opened a new pull request, #1799: Fix Kconfig style

2023-06-20 Thread via GitHub
simbit18 opened a new pull request, #1799: URL: https://github.com/apache/nuttx-apps/pull/1799 ## Summary Remove TABs from Kconfig files Add comments ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [nuttx] acassis commented on pull request #9566: sched/pthread: Use pthread_kill for asynchronous cancellation

2023-06-20 Thread via GitHub
acassis commented on PR #9566: URL: https://github.com/apache/nuttx/pull/9566#issuecomment-1598816593 There is a Deprecated message breaking the CI: ``` Collecting MarkupSafe>=0.9.2 (from Mako->alembic==1.5.5->CodeChecker) Downloading MarkupSafe-2.1.3-cp310-cp310-macosx_10_9_x86_64

[GitHub] [nuttx] simbit18 opened a new pull request, #9579: Fix Kconfig style

2023-06-20 Thread via GitHub
simbit18 opened a new pull request, #9579: URL: https://github.com/apache/nuttx/pull/9579 ## Summary Remove TABs from Kconfig files Replace help => ---help--- Add comments ## Impact none ## Testing -- This is an automated message from the Apache Git Service. To re

[GitHub] [nuttx] anjiahao1 commented on a diff in pull request #9568: Debug:support python script auto debug nuttx kernel

2023-06-20 Thread via GitHub
anjiahao1 commented on code in PR #9568: URL: https://github.com/apache/nuttx/pull/9568#discussion_r1235205136 ## tools/gdb/lists.py: ## @@ -0,0 +1,244 @@ + +# tools/gdb/lists.py +# +# Licensed to the Ap

[GitHub] [nuttx] CV-Bowen commented on pull request #9297: virtio: add virtio framework in NuttX

2023-06-20 Thread via GitHub
CV-Bowen commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1598642473 @masayuki2009 Here are my elfs with qemu-armv8a:netnsh: [arm64_netnsh_test.zip](https://github.com/apache/nuttx/files/11800075/arm64_netnsh_test.zip) In the zip, `arm64_netnsh` and `arm6

[GitHub] [nuttx] CV-Bowen commented on pull request #9297: virtio: add virtio framework in NuttX

2023-06-20 Thread via GitHub
CV-Bowen commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1598643261 Just rebase to the last. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [nuttx] masayuki2009 commented on pull request #9577: riscv/fpu: Implement correct lazy-FPU functionality (attempt #2)

2023-06-20 Thread via GitHub
masayuki2009 commented on PR #9577: URL: https://github.com/apache/nuttx/pull/9577#issuecomment-1598610454 >I think the smp issue is now fixed, but I don't own an smp capable board to test it on actual hardware. On rv-virt FPU works both in SMP and non-SMP. @pussuw Thanks for the

[GitHub] [nuttx] michallenc opened a new pull request, #9578: localtime: add tzreset function to force zone file reload

2023-06-20 Thread via GitHub
michallenc opened a new pull request, #9578: URL: https://github.com/apache/nuttx/pull/9578 ## Summary Current implementation discards any updates if current timezone name is the same as new timezone name. This works well if every timezone name is different (Europe/Prague, Mexico/General

[GitHub] [nuttx] pryan1k69 commented on issue #9428: Configuration error

2023-06-20 Thread via GitHub
pryan1k69 commented on issue #9428: URL: https://github.com/apache/nuttx/issues/9428#issuecomment-1598571339 Thanks @TimJTi for the advice on using a similar board and making changes using `make menuconfig`. Thanks to this, I was able to add my board to Nuttx. The problem is solved.

[GitHub] [nuttx] pryan1k69 closed issue #9428: Configuration error

2023-06-20 Thread via GitHub
pryan1k69 closed issue #9428: Configuration error URL: https://github.com/apache/nuttx/issues/9428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [nuttx] pussuw commented on pull request #9577: riscv/fpu: Implement correct lazy-FPU functionality (attempt #2)

2023-06-20 Thread via GitHub
pussuw commented on PR #9577: URL: https://github.com/apache/nuttx/pull/9577#issuecomment-1598547168 I think the smp issue is now fixed, but I don't own an smp capable board to test it on actual hardware. On rv-virt FPU works both in SMP and non-SMP. -- This is an automated message from t

[GitHub] [nuttx] pussuw commented on pull request #9577: riscv/fpu: Implement correct lazy-FPU functionality (attempt #2)

2023-06-20 Thread via GitHub
pussuw commented on PR #9577: URL: https://github.com/apache/nuttx/pull/9577#issuecomment-1598494645 @masayuki2009 The last commit fixes the ksmp64 crash but I cannot verify the FPU test because I do not own an FPU capable board. I noticed that rv-virt has FPU disabled, is this somet

[GitHub] [nuttx] pussuw opened a new pull request, #9577: riscv/fpu: Implement correct lazy-FPU functionality (attempt #2)

2023-06-20 Thread via GitHub
pussuw opened a new pull request, #9577: URL: https://github.com/apache/nuttx/pull/9577 Second attempt at this: https://github.com/apache/nuttx/pull/9486 There are two issues with smp mode: - Context restore routine in up_cpu_paused did not restore the correct address environmen

[GitHub] [nuttx] masayuki2009 commented on pull request #9297: virtio: add virtio framework in NuttX

2023-06-20 Thread via GitHub
masayuki2009 commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1598325694 >I've tried qemu-armv8a:netnsh on my local QEMU 7.2.2, but got different result: @CV-Bowen Can you attach the nuttx which you built? -- This is an automated message from t