[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9564: Compute the heap info more accuracy(2)

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9564: URL: https://github.com/apache/nuttx/pull/9564#discussion_r1233542436 ## mm/mm_heap/mm_memdump.c: ## @@ -70,14 +70,15 @@ static void memdump_handler(FAR struct mm_allocnode_s *node, FAR void *arg) nodesize, MM_PTR

[GitHub] [nuttx] mu578 commented on pull request #9546: stm32_tickless: Software prescaller proof-of-concept.

2023-06-18 Thread via GitHub
mu578 commented on PR #9546: URL: https://github.com/apache/nuttx/pull/9546#issuecomment-1596521465 @fjpanag what happens if more than two tasks are falling in the same gap ? it doesn't solve any reordering priority ; the only way would way would be to swap period to most eligible runner me

[GitHub] [nuttx] mu578 commented on a diff in pull request #9552: drivers/net/netdev: improve granularity of 'quota' locking

2023-06-18 Thread via GitHub
mu578 commented on code in PR #9552: URL: https://github.com/apache/nuttx/pull/9552#discussion_r1233529670 ## include/nuttx/net/netdev_lowerhalf.h: ## @@ -61,10 +62,8 @@ #define NETPKT_BUFLEN CONFIG_IOB_BUFSIZE -#if defined(CONFIG_OPENAMP) || \ -(defined(__STDC_VERSIO

[GitHub] [nuttx] mu578 commented on a diff in pull request #9552: drivers/net/netdev: improve granularity of 'quota' locking

2023-06-18 Thread via GitHub
mu578 commented on code in PR #9552: URL: https://github.com/apache/nuttx/pull/9552#discussion_r1233529670 ## include/nuttx/net/netdev_lowerhalf.h: ## @@ -61,10 +62,8 @@ #define NETPKT_BUFLEN CONFIG_IOB_BUFSIZE -#if defined(CONFIG_OPENAMP) || \ -(defined(__STDC_VERSIO

[GitHub] [nuttx] mu578 commented on a diff in pull request #9552: drivers/net/netdev: improve granularity of 'quota' locking

2023-06-18 Thread via GitHub
mu578 commented on code in PR #9552: URL: https://github.com/apache/nuttx/pull/9552#discussion_r1233529670 ## include/nuttx/net/netdev_lowerhalf.h: ## @@ -61,10 +62,8 @@ #define NETPKT_BUFLEN CONFIG_IOB_BUFSIZE -#if defined(CONFIG_OPENAMP) || \ -(defined(__STDC_VERSIO

[GitHub] [nuttx] eenurkka commented on a diff in pull request #9548: risc-v/mpfs: add CoreMMC support

2023-06-18 Thread via GitHub
eenurkka commented on code in PR #9548: URL: https://github.com/apache/nuttx/pull/9548#discussion_r1233509365 ## arch/risc-v/src/mpfs/mpfs_coremmc.c: ## @@ -0,0 +1,2406 @@ +/ + * arch/risc-v/src/mpfs/mpf

[nuttx] branch master updated: esp32-devkitc/wamr_wasi_debug: Bump WAMR version

2023-06-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new e9738cd906 esp32-devkitc/wamr_wasi_debug:

[GitHub] [nuttx] pkarashchenko merged pull request #9567: esp32-devkitc/wamr_wasi_debug: Bump WAMR version

2023-06-18 Thread via GitHub
pkarashchenko merged PR #9567: URL: https://github.com/apache/nuttx/pull/9567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9569: sched/sched/sched_idletask: fix typo

2023-06-18 Thread via GitHub
pkarashchenko commented on code in PR #9569: URL: https://github.com/apache/nuttx/pull/9569#discussion_r1233495343 ## sched/sched/sched_idletask.c: ## @@ -50,7 +50,7 @@ * None * * Returned Value: - * true if the calling task is and IDLE thread. + * true if the callin

[GitHub] [nuttx] TaiJuWu opened a new pull request, #9569: sched/sched/sched_idletask: fix typo

2023-06-18 Thread via GitHub
TaiJuWu opened a new pull request, #9569: URL: https://github.com/apache/nuttx/pull/9569 ## Summary Fix typo of sched_idletask ## Impact None ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r1233491154 ## libs/libc/misc/Kconfig: ## @@ -81,9 +81,27 @@ config LIBC_FTOK_VFS_PATH ---help--- The relative path to where ftok will exist in the ro

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9564: Compute the heap info more accuracy(2)

2023-06-18 Thread via GitHub
pkarashchenko commented on code in PR #9564: URL: https://github.com/apache/nuttx/pull/9564#discussion_r1233490546 ## mm/mm_heap/mm_memdump.c: ## @@ -70,14 +70,15 @@ static void memdump_handler(FAR struct mm_allocnode_s *node, FAR void *arg) nodesize, MM_PTR_F

[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1797: Remove the unnecessary cast from pid_t to int

2023-06-18 Thread via GitHub
xiaoxiang781216 opened a new pull request, #1797: URL: https://github.com/apache/nuttx-apps/pull/1797 ## Summary from the comment: https://github.com/apache/nuttx/pull/9564#discussion_r1233425912 ## Impact minor ## Testing ci -- This is an automated mess

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9562: stm32f777zit6-meadow: Fix external RAM pinout and add board profile

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9562: URL: https://github.com/apache/nuttx/pull/9562#discussion_r1233483504 ## boards/arm/stm32f7/stm32f777zit6-meadow/src/stm32_usb.c: ## @@ -0,0 +1,335 @@ +/ +

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9564: Compute the heap info more accuracy(2)

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9564: URL: https://github.com/apache/nuttx/pull/9564#discussion_r1233481003 ## mm/mempool/mempool.c: ## @@ -460,55 +462,55 @@ mempool_info_task(FAR struct mempool_s *pool, void mempool_memdump(FAR struct mempool_s *pool,

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9565: esp32s3: Add usbnsh for all ESP32S3 boards

2023-06-18 Thread via GitHub
xiaoxiang781216 merged PR #9565: URL: https://github.com/apache/nuttx/pull/9565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (b3fead9d28 -> bb84b08735)

2023-06-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from b3fead9d28 openamp: add OPENAMP_DEBUG config to enable/disable openamp debug add 985e2beae0 esp32s3-devkit: Ad

[GitHub] [nuttx] anjiahao1 opened a new pull request, #9568: Debug:support python script auto debug nuttx kernel

2023-06-18 Thread via GitHub
anjiahao1 opened a new pull request, #9568: URL: https://github.com/apache/nuttx/pull/9568 This patch add an example and pyhton base modules: 1.add memdump.py is an example to analyze memory usage by python script. 2.add The most basic data structure analysis, like list, etc.

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9564: Compute the heap info more accuracy(2)

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9564: URL: https://github.com/apache/nuttx/pull/9564#discussion_r1233455083 ## mm/tlsf/mm_tlsf.c: ## @@ -404,33 +399,31 @@ static void memdump_handler(FAR void *ptr, size_t size, int used, FAR void *user) {

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9564: Compute the heap info more accuracy(2)

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9564: URL: https://github.com/apache/nuttx/pull/9564#discussion_r1233455020 ## mm/mempool/mempool.c: ## @@ -460,55 +462,55 @@ mempool_info_task(FAR struct mempool_s *pool, void mempool_memdump(FAR struct mempool_s *pool,

[GitHub] [nuttx] yamt opened a new pull request, #9567: esp32-devkitc/wamr_wasi_debug: Bump WAMR version

2023-06-18 Thread via GitHub
yamt opened a new pull request, #9567: URL: https://github.com/apache/nuttx/pull/9567 ## Summary esp32-devkitc/wamr_wasi_debug: Bump WAMR version ## Impact ## Testing tested on esp32-devkitc -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nuttx] zyfeier opened a new pull request, #9566: sched/pthread: Use pthread_kill for asynchronous cancellation

2023-06-18 Thread via GitHub
zyfeier opened a new pull request, #9566: URL: https://github.com/apache/nuttx/pull/9566 ## Summary Fixed ltp_interfaces_pthread_attr_init_3_1 test issue: When performing asynchronous cancellation, if an exit operation is executed, a deadlock problem may occur when pthread_can

[GitHub] [nuttx] hujun260 commented on pull request #9497: libc/fdcheck: add fdcheck module

2023-06-18 Thread via GitHub
hujun260 commented on PR #9497: URL: https://github.com/apache/nuttx/pull/9497#issuecomment-1596368428 > It seems that only `select()` is affected by this. > The other failures that I see are something else, probably introduced in the late @fjpanag I am currently unable to analyze

[GitHub] [nuttx] hujun260 commented on pull request #9497: libc/fdcheck: add fdcheck module

2023-06-18 Thread via GitHub
hujun260 commented on PR #9497: URL: https://github.com/apache/nuttx/pull/9497#issuecomment-1596350439 > > But select already contain the code to restore: > > https://github.com/apache/nuttx/blob/master/fs/vfs/fs_select.c#L105 > > @xiaoxiang781216 The `fdcheck_protect()` is implemen

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9564: Compute the heap info more accuracy(2)

2023-06-18 Thread via GitHub
pkarashchenko commented on code in PR #9564: URL: https://github.com/apache/nuttx/pull/9564#discussion_r1233425723 ## mm/mempool/mempool.c: ## @@ -460,55 +462,55 @@ mempool_info_task(FAR struct mempool_s *pool, void mempool_memdump(FAR struct mempool_s *pool,

[nuttx-website] branch asf-site updated: Publishing web: bedd222ce647cc428f1f896ea77db286eb1bfbce docs: b3fead9d28e177f0140e595dfdd7aaf1366de996

2023-06-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 3c554745 Publishing web: bedd222c

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9552: drivers/net/netdev: improve granularity of 'quota' locking

2023-06-18 Thread via GitHub
pkarashchenko commented on code in PR #9552: URL: https://github.com/apache/nuttx/pull/9552#discussion_r1233340292 ## include/nuttx/net/netdev_lowerhalf.h: ## @@ -61,10 +62,8 @@ #define NETPKT_BUFLEN CONFIG_IOB_BUFSIZE -#if defined(CONFIG_OPENAMP) || \ -(defined(__STD

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
pkarashchenko commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r129453 ## libs/libc/misc/Kconfig: ## @@ -81,9 +81,27 @@ config LIBC_FTOK_VFS_PATH ---help--- The relative path to where ftok will exist in the root

[GitHub] [nuttx] fjpanag commented on pull request #9546: stm32_tickless: Software prescaller proof-of-concept.

2023-06-18 Thread via GitHub
fjpanag commented on PR #9546: URL: https://github.com/apache/nuttx/pull/9546#issuecomment-1596166909 > But adding a tick only if the requested timer period is very small is unpredictable. > If you time such a system, the actual delay may be [requested - 1] - [requested], or maybe [reque

[GitHub] [nuttx] fjpanag commented on pull request #9546: stm32_tickless: Software prescaller proof-of-concept.

2023-06-18 Thread via GitHub
fjpanag commented on PR #9546: URL: https://github.com/apache/nuttx/pull/9546#issuecomment-1596164629 I understand that the actual delay may be more than the requested. This sounds logical and correct. Adding 1 tick to the delay period is OK, as long as it allows us to satisfy our timing gu

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9564: Compute the heap info more accuracy(2)

2023-06-18 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9564: URL: https://github.com/apache/nuttx/pull/9564 ## Summary Continue the work https://github.com/apache/nuttx/pull/9561 - mm/mempool: Count the backtrace overhead in mempool_[dump|info[_task]] - mm/mempool: Count the expend blo

[nuttx] branch master updated (9b6cd96671 -> b3fead9d28)

2023-06-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 9b6cd96671 mm: Rename PID_MM_INVALID to PID_MM_LEAK new fa94317447 openamp/Kconfig: add config to enable/di

[nuttx] 01/02: openamp/Kconfig: add config to enable/disable the cache feature

2023-06-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit fa94317447bf34ce3a8e90c026ca055f2c59f125 Author: wangbowen6 AuthorDate: Sat May 27 13:36:47 2023 +0800 openam

[nuttx] 02/02: openamp: add OPENAMP_DEBUG config to enable/disable openamp debug

2023-06-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit b3fead9d28e177f0140e595dfdd7aaf1366de996 Author: wangbowen6 AuthorDate: Thu Jun 1 18:40:24 2023 +0800 openamp

[GitHub] [nuttx] pkarashchenko merged pull request #9553: Openamp/Kconfig: add cache and debug config for openamp

2023-06-18 Thread via GitHub
pkarashchenko merged PR #9553: URL: https://github.com/apache/nuttx/pull/9553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[nuttx] branch master updated: mm: Rename PID_MM_INVALID to PID_MM_LEAK

2023-06-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9b6cd96671 mm: Rename PID_MM_INVALID to PI

[GitHub] [nuttx] pkarashchenko merged pull request #9563: mm: Rename PID_MM_INVALID to PID_MM_LEAK

2023-06-18 Thread via GitHub
pkarashchenko merged PR #9563: URL: https://github.com/apache/nuttx/pull/9563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
pkarashchenko commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r1233244812 ## libs/libc/misc/Kconfig: ## @@ -81,9 +81,27 @@ config LIBC_FTOK_VFS_PATH ---help--- The relative path to where ftok will exist in the root

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r1233241382 ## libs/libc/misc/Kconfig: ## @@ -81,9 +81,27 @@ config LIBC_FTOK_VFS_PATH ---help--- The relative path to where ftok will exist in the ro

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r1233241382 ## libs/libc/misc/Kconfig: ## @@ -81,9 +81,27 @@ config LIBC_FTOK_VFS_PATH ---help--- The relative path to where ftok will exist in the ro

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
pkarashchenko commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r1233235097 ## libs/libc/misc/Kconfig: ## @@ -81,9 +81,27 @@ config LIBC_FTOK_VFS_PATH ---help--- The relative path to where ftok will exist in the root

[GitHub] [nuttx] CV-Bowen commented on a diff in pull request #9553: Openamp/Kconfig: add cache and debug config for openamp

2023-06-18 Thread via GitHub
CV-Bowen commented on code in PR #9553: URL: https://github.com/apache/nuttx/pull/9553#discussion_r1233225379 ## openamp/Kconfig: ## @@ -11,4 +11,19 @@ config OPENAMP if OPENAMP +config OPENAMP_CACHE + bool "Enable OpenAmp cache support" Review Comment: Done ##

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r1233222815 ## libs/libc/misc/lib_memfd.c: ## @@ -32,20 +33,30 @@ * Pre-processor Definitions

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9513: libc: Prefer to implement memfd on top of shm

2023-06-18 Thread via GitHub
xiaoxiang781216 commented on code in PR #9513: URL: https://github.com/apache/nuttx/pull/9513#discussion_r1233222477 ## libs/libc/misc/lib_memfd.c: ## @@ -32,20 +33,30 @@ * Pre-processor Definitions

[GitHub] [nuttx] raiden00pl commented on issue #6012: Low priority tasks interrupt high priority threads

2023-06-18 Thread via GitHub
raiden00pl commented on issue #6012: URL: https://github.com/apache/nuttx/issues/6012#issuecomment-1596014011 @pkarashchenko here is the context to this issue: https://lists.apache.org/thread/g7n5hvb2d33mqdf21v5j9hqtcthol9wk A brief summary of what I remember: 1. we have 2 thre

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9563: mm: Rename PID_MM_INVALID to PID_MM_LEAK

2023-06-18 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9563: URL: https://github.com/apache/nuttx/pull/9563 ## Summary to express the intent more clear ## Impact code refactor only ## Testing sim:adb and sim:kasan -- This is an automated message from the Apache Git