[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9543: netdev/upper: Optimize on quota related operations

2023-06-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9543: URL: https://github.com/apache/nuttx/pull/9543#discussion_r1232981535 ## include/nuttx/net/netdev_lowerhalf.h: ## @@ -234,6 +258,21 @@ void netdev_lower_rxready(FAR struct netdev_lowerhalf_s *dev); void netdev_lower_txdone(FAR s

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9552: drivers/net/netdev: improve granularity of 'quota' locking

2023-06-16 Thread via GitHub
xiaoxiang781216 commented on code in PR #9552: URL: https://github.com/apache/nuttx/pull/9552#discussion_r1232980525 ## include/nuttx/net/netdev_lowerhalf.h: ## @@ -61,10 +62,8 @@ #define NETPKT_BUFLEN CONFIG_IOB_BUFSIZE -#if defined(CONFIG_OPENAMP) || \ -(defined(__S

[GitHub] [nuttx] CV-Bowen opened a new pull request, #9554: Rptun: rptun and rptun_dump bug fix

2023-06-16 Thread via GitHub
CV-Bowen opened a new pull request, #9554: URL: https://github.com/apache/nuttx/pull/9554 ## Summary Commit 1: rptun: init the semtx before the thread/workqueue created If the rptun driver set auto start, the smetx may has been used in rptun_notify_wait() but not inited.

[GitHub] [nuttx] CV-Bowen opened a new pull request, #9553: Openamp/Kconfig: add more cache and debug config for openamp

2023-06-16 Thread via GitHub
CV-Bowen opened a new pull request, #9553: URL: https://github.com/apache/nuttx/pull/9553 ## Summary Commit 1: openamp/Kconfig: add config to enable/disable the cache feature Commit 2: openamp: add OPENAMP_DEBUG config to enable/disable openamp debug ## Impact None

[GitHub] [nuttx] CV-Bowen commented on pull request #9297: virtio: add virtio framework in NuttX

2023-06-16 Thread via GitHub
CV-Bowen commented on PR #9297: URL: https://github.com/apache/nuttx/pull/9297#issuecomment-1595643095 @masayuki2009 We optimize the iperf performance in smp case by changing the `rx/tx quota` lock from spin_lock to atomic, see https://github.com/apache/nuttx/pull/9543. Could you take a loo

[nuttx] branch master updated: semaphore: Optimize priority inheritance with only one holder

2023-06-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 514e77b75e semaphore: Optimize priority in

[GitHub] [nuttx] pkarashchenko merged pull request #8743: nxmutex: mutex priority inheritance optimization

2023-06-16 Thread via GitHub
pkarashchenko merged PR #8743: URL: https://github.com/apache/nuttx/pull/8743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] no1wudi closed pull request #9537: tools: Implement CC_CHECK_VERSION to detect compiler version

2023-06-16 Thread via GitHub
no1wudi closed pull request #9537: tools: Implement CC_CHECK_VERSION to detect compiler version URL: https://github.com/apache/nuttx/pull/9537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[nuttx-website] branch asf-site updated: Publishing web: bedd222ce647cc428f1f896ea77db286eb1bfbce docs: 8f25329260c5b34f413d3ac331e3a8a54a7b20c6

2023-06-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 1db8fe17 Publishing web: bedd222c

[GitHub] [nuttx] pkarashchenko commented on pull request #8743: nxmutex: mutex priority inheritance optimization

2023-06-16 Thread via GitHub
pkarashchenko commented on PR #8743: URL: https://github.com/apache/nuttx/pull/8743#issuecomment-1595314683 In general I do not have objections on this PR. @davids5 could you please also take a look and approve if all your questions are addressed? -- This is an automated message from the

[GitHub] [nuttx-apps] pkarashchenko commented on pull request #1796: toywasm: disable tail call

2023-06-16 Thread via GitHub
pkarashchenko commented on PR #1796: URL: https://github.com/apache/nuttx-apps/pull/1796#issuecomment-1595284517 Could you please update commit message of a second commit with few more words (it seems to be too laconic to me)? -- This is an automated message from the Apache Git Service. T

[GitHub] [nuttx] pkarashchenko commented on pull request #9543: netdev/upper: Optimize on quota related operations

2023-06-16 Thread via GitHub
pkarashchenko commented on PR #9543: URL: https://github.com/apache/nuttx/pull/9543#issuecomment-1595276423 @wengzhe could you please try https://github.com/apache/nuttx/pull/9552 ? It seems to be natural to me, but I do not have an ability to test it. -- This is an automated message fr

[GitHub] [nuttx] pkarashchenko opened a new pull request, #9552: drivers/net/netdev: improve granularity of 'quota' locking

2023-06-16 Thread via GitHub
pkarashchenko opened a new pull request, #9552: URL: https://github.com/apache/nuttx/pull/9552 ## Summary There is no need to use global spinlock to protect netdev specific data counters. Allocate per-netdev specific spinlock to get better locking granularity. Move C/C++ atomic suppor

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9543: netdev/upper: Optimize on quota related operations

2023-06-16 Thread via GitHub
pkarashchenko commented on code in PR #9543: URL: https://github.com/apache/nuttx/pull/9543#discussion_r1232704568 ## include/nuttx/net/netdev_lowerhalf.h: ## @@ -234,6 +258,21 @@ void netdev_lower_rxready(FAR struct netdev_lowerhalf_s *dev); void netdev_lower_txdone(FAR str

[GitHub] [nuttx] acassis merged pull request #9549: xtensa/esp32s3: SPI support quad I/O mode

2023-06-16 Thread via GitHub
acassis merged PR #9549: URL: https://github.com/apache/nuttx/pull/9549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated: xtensa/esp32s3: SPI support quad I/O mode

2023-06-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8f25329260 xtensa/esp32s3: SPI support quad I/O

[GitHub] [nuttx] tmedicci merged pull request #9551: boards/xtensa/esp32s3-devkit: Revert NSH defconfig deletion

2023-06-16 Thread via GitHub
tmedicci merged PR #9551: URL: https://github.com/apache/nuttx/pull/9551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[nuttx] branch master updated: boards/xtensa/esp32s3-devkit: Revert NSH defconfig deletion

2023-06-16 Thread tmedicci
This is an automated email from the ASF dual-hosted git repository. tmedicci pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new fa5db655cd boards/xtensa/esp32s3-devkit: Revert

[nuttx] branch master updated: fs/fdcheck: Let FDCHECK depend on SCHED_HAVE_PARENT

2023-06-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 14e5bcaf6e fs/fdcheck: Let FDCHECK depend

[GitHub] [nuttx] pkarashchenko merged pull request #9550: fs/fdcheck: Let FDCHECK depend on SCHED_HAVE_PARENT

2023-06-16 Thread via GitHub
pkarashchenko merged PR #9550: URL: https://github.com/apache/nuttx/pull/9550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] patacongo commented on pull request #9546: stm32_tickless: Software prescaller proof-of-consept.

2023-06-16 Thread via GitHub
patacongo commented on PR #9546: URL: https://github.com/apache/nuttx/pull/9546#issuecomment-1594784976 > [USER] Schedule task A in 10 ms. > [USER] Schedule task B in 11 ms. > [OS] My next context switch will be in 10 ms. Set tickless timer for 10ms. > [Nature] 1

[GitHub] [nuttx] mu578 commented on pull request #9546: stm32_tickless: Software prescaller proof-of-consept.

2023-06-16 Thread via GitHub
mu578 commented on PR #9546: URL: https://github.com/apache/nuttx/pull/9546#issuecomment-1594748829 @fjpanag now, I understand the skew logic (idle period, and preemptive issue on context switching), so then, your period drifting idea of rescheduling (a tiny bit ahead), meanwhile, it is sti

[GitHub] [nuttx-apps] yamt opened a new pull request, #1796: toywasm: disable tail call

2023-06-16 Thread via GitHub
yamt opened a new pull request, #1796: URL: https://github.com/apache/nuttx-apps/pull/1796 ## Summary toywasm: disable tail call ## Impact ## Testing Tested on esp32-devkitc -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [nuttx] lucasssvaz opened a new pull request, #9551: boards/xtensa/esp32s3-devkit: Revert NSH defconfig deletion

2023-06-16 Thread via GitHub
lucasssvaz opened a new pull request, #9551: URL: https://github.com/apache/nuttx/pull/9551 ## Summary Restore the NSH defconfig that was mistakenly deleted. ## Impact Restore base config for ESP32-S2. ## Testing ESP32-S3-DevKit -- This is an automated me

[GitHub] [nuttx] fjpanag commented on pull request #9546: stm32_tickless: Software prescaller proof-of-consept.

2023-06-16 Thread via GitHub
fjpanag commented on PR #9546: URL: https://github.com/apache/nuttx/pull/9546#issuecomment-1594471464 I haven't studied NuttX tickless code in depth yet, but based on my general knowledge of tickless systems, and by seeing how the watchdogs work now, let me provide you with an example of th

[GitHub] [nuttx] fjpanag commented on pull request #9546: stm32_tickless: Software prescaller proof-of-consept.

2023-06-16 Thread via GitHub
fjpanag commented on PR #9546: URL: https://github.com/apache/nuttx/pull/9546#issuecomment-1594458129 To begin with, this is just an example of code that happens to solve the issue. It is here only for demonstration purposes, illustrating my recommendation. That being said, my or

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9547: libc/fdcheck: Fix undefined reference to `getppid'

2023-06-16 Thread via GitHub
xiaoxiang781216 commented on PR #9547: URL: https://github.com/apache/nuttx/pull/9547#issuecomment-1594450639 here is the patch: https://github.com/apache/nuttx/pull/9550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9550: fs/fdcheck: Let FDCHECK depend on SCHED_HAVE_PARENT

2023-06-16 Thread via GitHub
xiaoxiang781216 opened a new pull request, #9550: URL: https://github.com/apache/nuttx/pull/9550 ## Summary since the implementation of fdcheck call getppid ## Impact fdcheck ## Testing sim:kasan -- This is an automated message from the Apache Git Ser

[GitHub] [nuttx] fjpanag commented on pull request #9547: libc/fdcheck: Fix undefined reference to `getppid'

2023-06-16 Thread via GitHub
fjpanag commented on PR #9547: URL: https://github.com/apache/nuttx/pull/9547#issuecomment-1594412513 Thank you for this. But the original issue is still standing. Shouldn't `FDCHECK` also `select SCHED_HAVE_PARENT`? I think we shall make configuration simpler than introducin

[GitHub] [nuttx] donghengqaz opened a new pull request, #9549: xtensa/esp32s3: SPI support quad I/O mode

2023-06-16 Thread via GitHub
donghengqaz opened a new pull request, #9549: URL: https://github.com/apache/nuttx/pull/9549 ## Summary 1. SPI master quad I/O driver 2. SPI slave supports quad I/O 3. SPI2 and SPI3 can use DMA mode ## Impact ## Testing -- This is an automated message fro