[GitHub] [nuttx] realprocrastinator commented on issue #8857: use after free in `poll()` implementation

2023-03-24 Thread via GitHub
realprocrastinator commented on issue #8857: URL: https://github.com/apache/nuttx/issues/8857#issuecomment-1483744418 > @realprocrastinator good catch! Do you think it is possible to create a testing application to demonstrate this issue? Sure, I will have a try! :-) -- This is an

[GitHub] [nuttx] xiaoxiang781216 commented on issue #8898: Remove configurable assignment of signal numbers.

2023-03-24 Thread via GitHub
xiaoxiang781216 commented on issue #8898: URL: https://github.com/apache/nuttx/issues/8898#issuecomment-1483739791 Yes, I think so: the configurable signal number make the thing more complex, but the benefit is very small. -- This is an automated message from the Apache Git Service. To re

[GitHub] [nuttx] adamfeuer commented on pull request #8840: make userleds work on Arduino Due

2023-03-24 Thread via GitHub
adamfeuer commented on PR #8840: URL: https://github.com/apache/nuttx/pull/8840#issuecomment-1483710964 @pkarashchenko I made the fixes, and also got the `arm05` check to pass- this is a green build now and ready to merge. Or- do you want me to rebase and squash the commits? -- Thi

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: d60dee4a650f8f84e47703e8cd90aa084b2f48b0

2023-03-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0342f68d Publishing web: b50f5ca4

[nuttx] branch master updated (c9b917bcee -> d60dee4a65)

2023-03-24 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from c9b917bcee assert.h: Replace NULL with 0 to avoid including stddef.h add d60dee4a65 sched/clock_gettime:Rem

[GitHub] [nuttx] pkarashchenko merged pull request #8897: sched/clock_gettime:Remove output log

2023-03-24 Thread via GitHub
pkarashchenko merged PR #8897: URL: https://github.com/apache/nuttx/pull/8897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] patacongo commented on issue #8898: Remove configurable assignment of signal numbers.

2023-03-24 Thread via GitHub
patacongo commented on issue #8898: URL: https://github.com/apache/nuttx/issues/8898#issuecomment-1483378229 Configurable signal numbers should be removed because the feature is useless. But removing configurable signal numbers has another benefit. We can, for example, greatly simplify lo

[GitHub] [nuttx] patacongo opened a new issue, #8898: Remove configurable assignment of signal numbers.

2023-03-24 Thread via GitHub
patacongo opened a new issue, #8898: URL: https://github.com/apache/nuttx/issues/8898 Currently there are 31 possible signals. Zero is the NULL signal, Signals 1-29 are all of the standard signals, and 30-31 are available for real time signals. Applications may only allocate signals from

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147982846 ## include/limits.h: ## @@ -146,8 +146,8 @@ /* Required for sigqueue */ -#define _POSIX_RTSIG_MAX 2/* Number of reserved realtime signals */ -#define

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147980597 ## include/limits.h: ## @@ -146,8 +146,8 @@ /* Required for sigqueue */ -#define _POSIX_RTSIG_MAX 2/* Number of reserved realtime signals */ -#define

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147980597 ## include/limits.h: ## @@ -146,8 +146,8 @@ /* Required for sigqueue */ -#define _POSIX_RTSIG_MAX 2/* Number of reserved realtime signals */ -#define

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147979487 ## include/limits.h: ## @@ -146,8 +146,8 @@ /* Required for sigqueue */ -#define _POSIX_RTSIG_MAX 2/* Number of reserved realtime signals */ -#define

[GitHub] [nuttx] hartmannathan commented on a diff in pull request #8867: Optimize implementation of strsignal()

2023-03-24 Thread via GitHub
hartmannathan commented on code in PR #8867: URL: https://github.com/apache/nuttx/pull/8867#discussion_r1147977064 ## libs/libc/string/lib_strsignal.c: ## @@ -22,53 +22,24 @@ * Included Files / +#i

[nuttx] branch master updated: assert.h: Replace NULL with 0 to avoid including stddef.h

2023-03-24 Thread gnutt
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new c9b917bcee assert.h: Replace NULL with 0 to avoid

[GitHub] [nuttx] patacongo merged pull request #8878: assert.h: Replace NULL with 0 to avoid including stddef.h

2023-03-24 Thread via GitHub
patacongo merged PR #8878: URL: https://github.com/apache/nuttx/pull/8878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

[GitHub] [nuttx] patacongo commented on pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
patacongo commented on PR #8885: URL: https://github.com/apache/nuttx/pull/8885#issuecomment-1483257090 Status Update: Every builds correctly. Beginning testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [nuttx-apps] patacongo opened a new pull request, #1682: Changes to apps needed by nutts PR 8885

2023-03-24 Thread via GitHub
patacongo opened a new pull request, #1682: URL: https://github.com/apache/nuttx-apps/pull/1682 ## Summary ostest contains some logic that depends on internal implementation of signal sets and ostest must be updated to match those changes. This PR will not pass CI because it de

[GitHub] [nuttx] raiden00pl commented on pull request #8804: arch/nrf53: add ADC support

2023-03-24 Thread via GitHub
raiden00pl commented on PR #8804: URL: https://github.com/apache/nuttx/pull/8804#issuecomment-1483220488 Could we merge this one and https://github.com/apache/nuttx/pull/8793 ? I have more PRs for NRF53 which I want to submit at the weekend -- This is an automated message from the Apache

[GitHub] [nuttx] acassis commented on issue #8857: use after free in `poll()` implementation

2023-03-24 Thread via GitHub
acassis commented on issue #8857: URL: https://github.com/apache/nuttx/issues/8857#issuecomment-1483220696 @realprocrastinator good catch! Do you think it is possible to create a testing application to demonstrate this issue? -- This is an automated message from the Apache Git Service. To

[GitHub] [nuttx] acassis commented on issue #8886: Loading ELFs which contain a global offset table.

2023-03-24 Thread via GitHub
acassis commented on issue #8886: URL: https://github.com/apache/nuttx/issues/8886#issuecomment-1483217808 I think @masayuki2009 worked on improving ELF support some time ago. Maybe he has more information and could help about it. I think support to GOT is welcome. -- This is an automate

[nuttx-apps] 02/05: apps/wireless/ieee802154/libutils/Makefile: fix nxstyle

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit ef7e2a863698b416cde453523b14c3086f4a01aa Author: simbit18 <101105604+simbi...@users.noreply.github.com> AuthorDate:

[nuttx-apps] 04/05: apps/system/ymodem/Make.defs: fix nxstyle

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 1adc70fe4326c8fb5f3acc986869a98a0bf0d516 Author: simbit18 <101105604+simbi...@users.noreply.github.com> AuthorDate:

[nuttx-apps] 05/05: apps/system/ymodem/Makefile: fix nxstyle

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 386e0775259c1a2e43c069f89f01141cd90edd24 Author: simbit18 <101105604+simbi...@users.noreply.github.com> AuthorDate:

[nuttx-apps] 01/05: apps/wireless/wapi/src/Make.defs: fix nxstyle

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 6766327cde15115369cef5b25d68915f22da4fa4 Author: simbit18 <101105604+simbi...@users.noreply.github.com> AuthorDate:

[nuttx-apps] 03/05: apps/testing/smart_test/Makefile: fix nxstyle

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit e533df52ccb109e24d8c22e11f19c3e8bc67aa2c Author: simbit18 <101105604+simbi...@users.noreply.github.com> AuthorDate:

[nuttx-apps] branch master updated (0ed95bbe9 -> 386e07752)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 0ed95bbe9 tools/mkimport: Allow additions LDELFFLAGS from exported Nuttx builds. new 6766327cd apps/wireles

[GitHub] [nuttx-apps] acassis merged pull request #1680: apps: fix nxstyle violations

2023-03-24 Thread via GitHub
acassis merged PR #1680: URL: https://github.com/apache/nuttx-apps/pull/1680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

[GitHub] [nuttx-apps] acassis commented on pull request #1680: apps: fix nxstyle violations

2023-03-24 Thread via GitHub
acassis commented on PR #1680: URL: https://github.com/apache/nuttx-apps/pull/1680#issuecomment-1483210954 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[nuttx-apps] branch master updated: tools/mkimport: Allow additions LDELFFLAGS from exported Nuttx builds.

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 0ed95bbe9 tools/mkimport: Allow additions L

[GitHub] [nuttx-apps] acassis merged pull request #1677: tools/mkimport: Allow additions LDELFFLAGS from exported Nuttx builds.

2023-03-24 Thread via GitHub
acassis merged PR #1677: URL: https://github.com/apache/nuttx-apps/pull/1677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.a

[nuttx] branch master updated (7ce78dd66a -> 6a357797cd)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 7ce78dd66a Revert "driver/uart_rpmsg: Passthrough data by default" add 6a357797cd tools/export: Add LDELFFLAGS to

[GitHub] [nuttx] acassis merged pull request #8870: tools/export: Add LDELFFLAGS to mkexport.sh.

2023-03-24 Thread via GitHub
acassis merged PR #8870: URL: https://github.com/apache/nuttx/pull/8870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] acassis commented on pull request #8870: tools/export: Add LDELFFLAGS to mkexport.sh.

2023-03-24 Thread via GitHub
acassis commented on PR #8870: URL: https://github.com/apache/nuttx/pull/8870#issuecomment-1483208451 @g2gps very nice! I noticed that we don't have any documentation about it, please consider adding it. Thank you :-) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8840: make userleds work on Arduino Due

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8840: URL: https://github.com/apache/nuttx/pull/8840#discussion_r1147907492 ## boards/arm/sam34/arduino-due/src/sam_bringup.c: ## @@ -116,6 +124,18 @@ int sam_bringup(void) } #endif - UNUSED(ret); +#ifdef HAVE_LEDS + board_userled

[GitHub] [nuttx] raiden00pl commented on pull request #8892: rndis: do not configure endpoints from Kconfig when composite enabled

2023-03-24 Thread via GitHub
raiden00pl commented on PR #8892: URL: https://github.com/apache/nuttx/pull/8892#issuecomment-1483205196 Yes, we have to merge https://github.com/apache/nuttx/pull/8893 first. It depends on https://github.com/apache/nuttx/pull/8893/commits/9c62b0509ff380c4f3e279226f312fc77cd3d4b9 I submi

[nuttx] branch master updated (3428d15d04 -> 7ce78dd66a)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 3428d15d04 libc/math: rename libc/math.csv to libm/libm.csv add 7ce78dd66a Revert "driver/uart_rpmsg: Passthrough

[GitHub] [nuttx] acassis merged pull request #8860: Revert "driver/uart_rpmsg: Passthrough data by default"

2023-03-24 Thread via GitHub
acassis merged PR #8860: URL: https://github.com/apache/nuttx/pull/8860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] adamfeuer commented on a diff in pull request #8840: make userleds work on Arduino Due

2023-03-24 Thread via GitHub
adamfeuer commented on code in PR #8840: URL: https://github.com/apache/nuttx/pull/8840#discussion_r1147906048 ## boards/arm/sam34/arduino-due/src/sam_bringup.c: ## @@ -117,5 +125,19 @@ int sam_bringup(void) #endif UNUSED(ret); Review Comment: Thanks for catching- fixe

[nuttx] branch master updated (87852e8cbe -> 3428d15d04)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 87852e8cbe arch/arm/src/stm32/hardware: Fix register define add 3428d15d04 libc/math: rename libc/math.csv to lib

[GitHub] [nuttx] acassis merged pull request #8874: libc/math: rename libc/math.csv to libm/libm.csv

2023-03-24 Thread via GitHub
acassis merged PR #8874: URL: https://github.com/apache/nuttx/pull/8874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] acassis commented on pull request #8874: libc/math: rename libc/math.csv to libm/libm.csv

2023-03-24 Thread via GitHub
acassis commented on PR #8874: URL: https://github.com/apache/nuttx/pull/8874#issuecomment-1483201022 Doing to merge! Probably frameworks and ecosystems based on NuttX needs to be updated, i.e. PX4 (@davids5), Meadow, Vela, etc -- This is an automated message from the Apache Git Service.

[GitHub] [nuttx] acassis merged pull request #8880: Fixed stm32 rcc and tim

2023-03-24 Thread via GitHub
acassis merged PR #8880: URL: https://github.com/apache/nuttx/pull/8880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] 02/02: arch/arm/src/stm32/hardware: Fix register define

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 87852e8cbec3b2d312589ef84defd87c8087c120 Author: liuxuanfu AuthorDate: Thu Mar 23 20:13:15 2023 +0800 arch/arm/src/

[nuttx] 01/02: arch/arm/src/stm32/hardware: Add stm32g4 rcc apb1 timer enable compatibility

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 945e4c6d81d309b070ee7246bb49ef0a6a13754c Author: liuxuanfu AuthorDate: Thu Mar 23 20:07:21 2023 +0800 arch/arm/src/

[nuttx] branch master updated (50cf84c99a -> 87852e8cbe)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 50cf84c99a usbdev-composite: ep0 submit should be send only once for the composite class new 945e4c6d81 arch/arm

[GitHub] [nuttx] acassis commented on pull request #8880: Fixed stm32 rcc and tim

2023-03-24 Thread via GitHub
acassis commented on PR #8880: URL: https://github.com/apache/nuttx/pull/8880#issuecomment-1483197249 Thank you @super-porter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[nuttx] 02/02: usbdev-composite: ep0 submit should be send only once for the composite class

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 50cf84c99adef2210a107b88a48604919774a6ae Author: raiden00pl AuthorDate: Thu Mar 23 17:21:25 2023 +0100 usbdev-compo

[nuttx] branch master updated (17e8163b6e -> 50cf84c99a)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 17e8163b6e boards/spresense: add rndis composite support new d014b9d384 rndis: use composite_ep0submit to send th

[nuttx] 01/02: rndis: use composite_ep0submit to send the ep0 when composite

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit d014b9d38440f0a2a6fae0c941995774f9883899 Author: raiden00pl AuthorDate: Thu Mar 23 11:45:44 2023 +0100 rndis: use c

[GitHub] [nuttx] acassis merged pull request #8883: usbdev/composite: composite should send only one request for USB_REQ_SETCONFIGURATION

2023-03-24 Thread via GitHub
acassis merged PR #8883: URL: https://github.com/apache/nuttx/pull/8883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated (6caa9317f6 -> 17e8163b6e)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6caa9317f6 usbmsc: do not send deferred response if we are part of the composite device add 17e8163b6e boards/sp

[GitHub] [nuttx] acassis merged pull request #8888: boards/spresense: add rndis composite support

2023-03-24 Thread via GitHub
acassis merged PR #: URL: https://github.com/apache/nuttx/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[nuttx] branch master updated (a1aecd7369 -> 6caa9317f6)

2023-03-24 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from a1aecd7369 {stm32/stm32l4/stm32f7/stm32h7/efm32}/otgdev: remove invalid use of the priv field for EP add 6caa931

[GitHub] [nuttx] acassis merged pull request #8889: usbmsc: do not sent deferred response if USBMSC_COMPOSITE=y

2023-03-24 Thread via GitHub
acassis merged PR #8889: URL: https://github.com/apache/nuttx/pull/8889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] acassis commented on pull request #8892: rndis: do not configure endpoints from Kconfig when composite enabled

2023-03-24 Thread via GitHub
acassis commented on PR #8892: URL: https://github.com/apache/nuttx/pull/8892#issuecomment-1483193036 I think it introduced some small issues: ``` usbdev/rndis.c: In function 'usbdev_rndis_get_composite_devdesc': Error: usbdev/rndis.c:3033:52: error: 'RNDIS_EPINTIN_ADDR' undeclared (

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147888433 ## include/signal.h: ## @@ -37,20 +37,28 @@ /* Signal set management definitions and macros. */ -#define NULL_SIGNAL_SET ((sigset_t)0x) -#define ALL_SI

[GitHub] [nuttx] crafcat7 opened a new pull request, #8897: sched/clock_gettime:Remove output log

2023-03-24 Thread via GitHub
crafcat7 opened a new pull request, #8897: URL: https://github.com/apache/nuttx/pull/8897 ## Summary Calling syslog to print logs in clock_gettime will cause the system to have recursive output, i.e., clock_gettime->sinfo->syslog->clock_gettime, with the consequences of stack overflo

[GitHub] [nuttx] crafcat7 opened a new pull request, #8896: fs/fs_initialize.c:Sync fs in system restart callback

2023-03-24 Thread via GitHub
crafcat7 opened a new pull request, #8896: URL: https://github.com/apache/nuttx/pull/8896 ## Summary sync will be performed only when SYS_RESTART/SYS_DOWN situation occurs, avoiding unpredictable results caused by handling locks or semaphores in interrupts. ## Impact ##

[GitHub] [nuttx-apps] crafcat7 opened a new pull request, #1681: nshlib/nsh_fscmds.c:Add whether or not to pass in empty arguments when rm -r

2023-03-24 Thread via GitHub
crafcat7 opened a new pull request, #1681: URL: https://github.com/apache/nuttx-apps/pull/1681 ## Summary When rm -r is passed with no address specified, it will automatically recursively unlink all files under the root path ('/') until unlinking to the mounted folder causes the unli

[GitHub] [nuttx] patacongo commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
patacongo commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147824823 ## include/limits.h: ## @@ -146,8 +146,8 @@ /* Required for sigqueue */ -#define _POSIX_RTSIG_MAX 2/* Number of reserved realtime signals */ -#define _PO

[GitHub] [nuttx] patacongo commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
patacongo commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147818884 ## sched/signal/sig_timedwait.c: ## @@ -260,8 +261,9 @@ int nxsig_timedwait(FAR const sigset_t *set, FAR struct siginfo *info, * signals in the pending signal set

[GitHub] [nuttx] patacongo commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
patacongo commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147810762 ## include/signal.h: ## @@ -37,20 +37,28 @@ /* Signal set management definitions and macros. */ -#define NULL_SIGNAL_SET ((sigset_t)0x) -#define ALL_SIGNAL

[GitHub] [nuttx] raiden00pl commented on pull request #8891: {stm32,stm32l4,stm32f0l0g0}/otg: move STM32_NENDPOINTS to the header file

2023-03-24 Thread via GitHub
raiden00pl commented on PR #8891: URL: https://github.com/apache/nuttx/pull/8891#issuecomment-1483065083 Yeah, some problems with `stm32.h` and mess with including it everywhere instead of including the headers that are really needed by files. -- This is an automated message from the Apac

[nuttx] branch master updated (0b4b35c80a -> a1aecd7369)

2023-03-24 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 0b4b35c80a include/nuttx/usb/usbmsc.h: fix compiler error when USBMSC_COMPOSITE=y add a1aecd7369 {stm32/stm32l4/

[GitHub] [nuttx] davids5 merged pull request #8882: stm32/otgdev: remove invalid use of the priv field for EP

2023-03-24 Thread via GitHub
davids5 merged PR #8882: URL: https://github.com/apache/nuttx/pull/8882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] raiden00pl commented on pull request #8882: stm32/otgdev: remove invalid use of the priv field for EP

2023-03-24 Thread via GitHub
raiden00pl commented on PR #8882: URL: https://github.com/apache/nuttx/pull/8882#issuecomment-1483059955 I haven't met any problems with it yet. It works with CDCACM, RNDIS and USBMSC. After this change, the field is managed and used only by class drivers. The controller logic has nothing t

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147772565 ## include/signal.h: ## @@ -37,20 +37,28 @@ /* Signal set management definitions and macros. */ -#define NULL_SIGNAL_SET ((sigset_t)0x) -#define ALL_SI

[GitHub] [nuttx] patacongo commented on a diff in pull request #8885: Increase the number of real time signals. Two is not enough.

2023-03-24 Thread via GitHub
patacongo commented on code in PR #8885: URL: https://github.com/apache/nuttx/pull/8885#discussion_r1147765176 ## include/signal.h: ## @@ -386,7 +394,11 @@ */ #ifndef __SIGSET_T_DEFINED -typedef uint32_t sigset_t; /* Bit set of 32 signals */ +struct sigset_s Review Comme

[nuttx] branch master updated: include/nuttx/usb/usbmsc.h: fix compiler error when USBMSC_COMPOSITE=y

2023-03-24 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0b4b35c80a include/nuttx/usb/usbmsc.h: fix

[GitHub] [nuttx] pkarashchenko merged pull request #8887: include/nuttx/usb/usbmsc.h: fix compiler error when USBMSC_COMPOSITE=y

2023-03-24 Thread via GitHub
pkarashchenko merged PR #8887: URL: https://github.com/apache/nuttx/pull/8887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] davids5 commented on pull request #8891: {stm32,stm32l4,stm32f0l0g0}/otg: move STM32_NENDPOINTS to the header file

2023-03-24 Thread via GitHub
davids5 commented on PR #8891: URL: https://github.com/apache/nuttx/pull/8891#issuecomment-1482983349 @raiden00pl CI found some issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[nuttx] branch master updated: {stm32f7,stm32h7}/otg: fix compilation for USBDEV when USB_DEBUG=y

2023-03-24 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 13a96c7eb7 {stm32f7,stm32h7}/otg: fix compilatio

[GitHub] [nuttx] davids5 merged pull request #8890: {stm32f7,stm32h7}/otg: fix compilation for USBDEV when USB_DEBUG=y

2023-03-24 Thread via GitHub
davids5 merged PR #8890: URL: https://github.com/apache/nuttx/pull/8890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8893: rndis: various fixes for composite

2023-03-24 Thread via GitHub
pkarashchenko commented on code in PR #8893: URL: https://github.com/apache/nuttx/pull/8893#discussion_r1147717790 ## drivers/usbdev/rndis.c: ## @@ -2052,27 +2060,35 @@ static int16_t usbclass_mkcfgdesc(FAR uint8_t *buf, */ totallen = sizeof(g_rndis_cfgdesc); - memcpy(

[GitHub] [nuttx] lucasssvaz opened a new pull request, #8895: Documentation: Improve pages for ESP boards and SOCs

2023-03-24 Thread via GitHub
lucasssvaz opened a new pull request, #8895: URL: https://github.com/apache/nuttx/pull/8895 ## Summary This MR aims to fix broken and deprecated configs, fix documentation compilation warnings and improve documentation pages for ESP boards and SOCs. ## Impact Better user

[GitHub] [nuttx] lucasssvaz opened a new pull request, #8894: boards/xtensa/esp32s2-kaluga-1: Add touch pad support

2023-03-24 Thread via GitHub
lucasssvaz opened a new pull request, #8894: URL: https://github.com/apache/nuttx/pull/8894 ## Summary Add full touch pad support for the ESP32-S2-Kaluga-1 board through the ESP-LyraP-TouchA expansion board. ## Impact Support for the ESP-LyraP-TouchA expansion board.

[GitHub] [nuttx] raiden00pl opened a new pull request, #8893: rndis: various fixes for composite

2023-03-24 Thread via GitHub
raiden00pl opened a new pull request, #8893: URL: https://github.com/apache/nuttx/pull/8893 ## Summary Various fixes that makes RNDIS composite functional on stm32 otg: - rndis: refactor usbdev_rndis_get_composite_devdesc to make it more like in other composite drivers - rndis:

[GitHub] [nuttx] raiden00pl opened a new pull request, #8892: rndis: do not configure endpoints from Kconfig when composite enabled

2023-03-24 Thread via GitHub
raiden00pl opened a new pull request, #8892: URL: https://github.com/apache/nuttx/pull/8892 ## Summary - rndis: do not configure endpoints from Kconfig when composite enabled - rndis: move private definitions from a public header to the source file ## Impact Possible breaking

[GitHub] [nuttx] raiden00pl opened a new pull request, #8891: {stm32,stm32l4,stm32f0l0g0}/otg: move STM32_NENDPOINTS to the header file

2023-03-24 Thread via GitHub
raiden00pl opened a new pull request, #8891: URL: https://github.com/apache/nuttx/pull/8891 ## Summary - {stm32,stm32l4,stm32f0l0g0}/otg: move STM32_NENDPOINTS definitions to header files This value is useful for users when initializing a USB composite device in a board-specific l

[GitHub] [nuttx] raiden00pl opened a new pull request, #8890: {stm32f7,stm32h7}/otg: fix compilation for USBDEV when USB_DEBUG=y

2023-03-24 Thread via GitHub
raiden00pl opened a new pull request, #8890: URL: https://github.com/apache/nuttx/pull/8890 ## Summary - {stm32f7,stm32h7}/otg: fix compilation for USBDEV when USB_DEBUG=y ## Impact ## Testing ci -- This is an automated message from the Apache Git Service. To re

[GitHub] [nuttx] raiden00pl opened a new pull request, #8889: usbmsc: do not sent deferred response if USBMSC_COMPOSITE=y

2023-03-24 Thread via GitHub
raiden00pl opened a new pull request, #8889: URL: https://github.com/apache/nuttx/pull/8889 ## Summary - usbmsc: do not send deferred response if we are part of the composite device EP0 is owned by the composite class so it shouldn't be directly accessed by usbmsc ## Impact

[GitHub] [nuttx] raiden00pl opened a new pull request, #8888: boards/spresense: add rndis composite support

2023-03-24 Thread via GitHub
raiden00pl opened a new pull request, #: URL: https://github.com/apache/nuttx/pull/ ## Summary boards/spresense: add rndis composite support ## Impact ## Testing spresense rndis + cdcacm, rndis + usbmsc, cdcacm + usbmsc -- This is an automated message from the A

[GitHub] [nuttx] raiden00pl opened a new pull request, #8887: include/nuttx/usb/usbmsc.h: fix compiler error when USBMSC_COMPOSITE=y

2023-03-24 Thread via GitHub
raiden00pl opened a new pull request, #8887: URL: https://github.com/apache/nuttx/pull/8887 ## Summary - include/nuttx/usb/usbmsc.h: fix compiler error when USBMSC_COMPOSITE=y ``` usbdev/usbmsc.c:1758:5: error: conflicting types for 'usbmsc_classobject'; have 'int(void *, st

[GitHub] [nuttx] TimJTi commented on pull request #8789: Add Broadcom APDS9922 ambient light and proximity sensor

2023-03-24 Thread via GitHub
TimJTi commented on PR #8789: URL: https://github.com/apache/nuttx/pull/8789#issuecomment-1482484276 > Hi @TimJTi is it done or still WIP? Please fix the commit messages, you did the interactive rebase but forgot to fix the messages Done - hopefully just changed the name of the final

[GitHub] [nuttx] raiden00pl commented on pull request #8882: stm32/otgdev: remove invalid use of the priv field for EP

2023-03-24 Thread via GitHub
raiden00pl commented on PR #8882: URL: https://github.com/apache/nuttx/pull/8882#issuecomment-1482464901 EP structure definition states that this field is for use by class driver: https://github.com/apache/nuttx/blob/5651715486ed50df92ad3348da92833ac127153c/include/nuttx/usb/usbdev.h#L297

[GitHub] [nuttx] davids5 commented on pull request #8882: stm32/otgdev: remove invalid use of the priv field for EP

2023-03-24 Thread via GitHub
davids5 commented on PR #8882: URL: https://github.com/apache/nuttx/pull/8882#issuecomment-1482433906 @raiden00pl How did this manifest as a problem? Why Is `priv->epin[EP0].ep.priv = priv` being the control not correct? -- This is an automated message from the Apache Git Service.