[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8704: libc/stream: unify stream return behavior

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8704: URL: https://github.com/apache/nuttx/pull/8704#discussion_r1124127114 ## libs/libc/stream/lib_stdinstream.c: ## @@ -72,10 +72,6 @@ static int stdinstream_gets(FAR struct lib_instream_s *this, { this->nget += nread;

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8706: tools/ci: skip sim/wamr from ci build

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8706: URL: https://github.com/apache/nuttx/pull/8706#discussion_r1124124970 ## tools/ci/testlist/sim-02.dat: ## @@ -15,3 +15,6 @@ # Do not build Windows configs -,sim:windows + +# Skip WebAssembly Micro Runtime +-,sim:wamr Review Com

[GitHub] [nuttx] no1wudi opened a new pull request, #8707: arch/imx6: Fix a compilation error with UBSan

2023-03-02 Thread via GitHub
no1wudi opened a new pull request, #8707: URL: https://github.com/apache/nuttx/pull/8707 ## Summary Workaround for: chip/imx_gpio.c:545:7: error: case label does not reduce to an integer constant 545 | case GPIO_PERIPH: | ^~~~

[nuttx] branch master updated (392eebf5e2 -> 44857ab30e)

2023-03-02 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 392eebf5e2 arch/armv7-a: fixed scu cpu tagram mask define issue add 44857ab30e driver/serial: Echo only det

[GitHub] [nuttx] pkarashchenko merged pull request #8705: driver/serial: Echo only determined by ECHO flag with termios enabled

2023-03-02 Thread via GitHub
pkarashchenko merged PR #8705: URL: https://github.com/apache/nuttx/pull/8705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] anchao opened a new pull request, #8706: tools/ci: skip sim/wamr from ci build

2023-03-02 Thread via GitHub
anchao opened a new pull request, #8706: URL: https://github.com/apache/nuttx/pull/8706 ## Summary tools/ci: skip sim/wamr from ci build ## Impact N/A ## Testing ci-check -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [nuttx] no1wudi opened a new pull request, #8705: driver/serial: Echo only determined by ECHO flag with termios enabled

2023-03-02 Thread via GitHub
no1wudi opened a new pull request, #8705: URL: https://github.com/apache/nuttx/pull/8705 ## Summary Fix a bug that can not disable echo even if termios is enabled. Note: If you want to disable echo for console, you can only do it by termios. ## Impact serial driver ## T

[GitHub] [nuttx-apps] masayuki2009 commented on pull request #1608: readline: Don't echo input except VT100 command

2023-03-02 Thread via GitHub
masayuki2009 commented on PR #1608: URL: https://github.com/apache/nuttx-apps/pull/1608#issuecomment-1452973850 >@masayuki2009 Sorry, This PR should works whti https://github.com/apache/nuttx/pull/8691, but it merged late. Thanks for the information. I confirmed that the issue has

[GitHub] [nuttx-apps] no1wudi commented on pull request #1608: readline: Don't echo input except VT100 command

2023-03-02 Thread via GitHub
no1wudi commented on PR #1608: URL: https://github.com/apache/nuttx-apps/pull/1608#issuecomment-1452972493 > @masayuki2009 Sorry, This PR should works whti https://github.com/apache/nuttx/pull/8691, but it merged late. -- This is an automated message from the Apache Git Service. T

[GitHub] [nuttx-apps] masayuki2009 commented on pull request #1608: readline: Don't echo input except VT100 command

2023-03-02 Thread via GitHub
masayuki2009 commented on PR #1608: URL: https://github.com/apache/nuttx-apps/pull/1608#issuecomment-1452962688 @no1wudi I noticed that nsh does not show input characters when tested with qemu (e.g. rv-virt:smp64) If I revert this PR, it works again. -- This is an automated mes

[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8704: libc/stream: unify stream return behavior

2023-03-02 Thread via GitHub
Gary-Hobson opened a new pull request, #8704: URL: https://github.com/apache/nuttx/pull/8704 ## Summary Unified Stream behavior Return the error code when all gets occur when an error is wrong, and return immediately when obtaining any valid data ## Impact ## Testing

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8685: libc/stream: Implement gets/puts for all streams

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8685: URL: https://github.com/apache/nuttx/pull/8685#discussion_r1124000318 ## libs/libc/stream/lib_stdsistream.c: ## @@ -52,6 +52,29 @@ static int stdsistream_getc(FAR struct lib_sistream_s *this) return ret; } +/**

[nuttx] branch master updated: arch/armv7-a: fixed scu cpu tagram mask define issue

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 392eebf5e2 arch/armv7-a: fixed scu cpu tagram

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8703: arch/armv7-a: fixed scu cpu tagram mask define issue

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8703: URL: https://github.com/apache/nuttx/pull/8703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated: drivers/serial: Echo input in driver layer

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 68384e9db4 drivers/serial: Echo input in drive

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8691: drivers/serial: Echo input in driver layer

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8691: URL: https://github.com/apache/nuttx/pull/8691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8619: Implement the trace function and add tracepoints for the startup process

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8619: URL: https://github.com/apache/nuttx/pull/8619#discussion_r112399 ## Kconfig: ## @@ -2006,6 +2006,65 @@ config FRAME_POINTER endmenu # Debug Options +menuconfig TRACE + bool "Enable tracepoints" + default n +

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8658: Fix error: '%s' directive output may be truncated

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on PR #8658: URL: https://github.com/apache/nuttx/pull/8658#issuecomment-1452902655 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8619: Implement the trace function and add tracepoints for the startup process

2023-03-02 Thread via GitHub
Gary-Hobson commented on code in PR #8619: URL: https://github.com/apache/nuttx/pull/8619#discussion_r1123980469 ## Kconfig: ## @@ -2006,6 +2006,65 @@ config FRAME_POINTER endmenu # Debug Options +menuconfig TRACE + bool "Enable tracepoints" + default n +

[GitHub] [nuttx-apps] anchao commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
anchao commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1123980053 ## interpreters/wamr/Toolchain.defs: ## @@ -0,0 +1,148 @@ + +# apps/interpreters/wamr/Tool

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8656: fs: Undefine CONFIG_FS_LARGEFILE if compiler doesn't support long long

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8656: URL: https://github.com/apache/nuttx/pull/8656#discussion_r1123976323 ## include/nuttx/compiler.h: ## @@ -944,6 +944,10 @@ #endif +#ifndef CONFIG_HAVE_LONG_LONG +# undef CONFIG_FS_LARGEFILE +#endif + Review Comment: Can no

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
no1wudi commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1123968035 ## interpreters/wamr/Toolchain.defs: ## @@ -0,0 +1,148 @@ + +# apps/interpreters/wamr/Too

[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
no1wudi commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1123968035 ## interpreters/wamr/Toolchain.defs: ## @@ -0,0 +1,148 @@ + +# apps/interpreters/wamr/Too

[GitHub] [nuttx] no1wudi commented on a diff in pull request #8696: libc/stdio: Implement lib_get_stream

2023-03-02 Thread via GitHub
no1wudi commented on code in PR #8696: URL: https://github.com/apache/nuttx/pull/8696#discussion_r1123954229 ## libs/libc/stdio/lib_libgetstreams.c: ## @@ -57,4 +57,18 @@ FAR struct streamlist *lib_get_streams(void) return &info->ta_streamlist; } +/

[nuttx-website] branch asf-site updated: Publishing web: b50f5ca4ed22743959c1160aab5dcc9ae18b3eff docs: 74ffdb0b4930142f3995a998e12fb18cd300cd2e

2023-03-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 37fc74fc Publishing web: b50f5ca4

[GitHub] [nuttx] no1wudi commented on a diff in pull request #8691: drivers/serial: Echo input in driver layer

2023-03-02 Thread via GitHub
no1wudi commented on code in PR #8691: URL: https://github.com/apache/nuttx/pull/8691#discussion_r1123947648 ## drivers/serial/serial.c: ## @@ -886,6 +888,53 @@ static ssize_t uart_read(FAR struct file *filep, *buffer++ = ch; recvd++; + + if (dev

[GitHub] [nuttx] zyfeier opened a new pull request, #8703: arch/armv7-a: fixed scu cpu tagram mask define issue

2023-03-02 Thread via GitHub
zyfeier opened a new pull request, #8703: URL: https://github.com/apache/nuttx/pull/8703 ## Summary Fixed scu cpu tagram mask define issue. ## Impact NA ## Testing sabre-6quad:smp -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [nuttx] no1wudi commented on a diff in pull request #8691: drivers/serial: Echo input in driver layer

2023-03-02 Thread via GitHub
no1wudi commented on code in PR #8691: URL: https://github.com/apache/nuttx/pull/8691#discussion_r1123947648 ## drivers/serial/serial.c: ## @@ -886,6 +888,53 @@ static ssize_t uart_read(FAR struct file *filep, *buffer++ = ch; recvd++; + + if (dev

[nuttx] 01/02: arch/nrf52: use the lates SoftDevice release (v2.3.0)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit eda99e35bb7f7f0778cc2c62dca237548887536d Author: raiden00pl AuthorDate: Wed Mar 1 19:27:36 2023 +0100 arch/nrf52:

[nuttx] 02/02: boards/nrf52: update sdc configs

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 74ffdb0b4930142f3995a998e12fb18cd300cd2e Author: raiden00pl AuthorDate: Thu Mar 2 18:06:32 2023 +0100 boards/nrf5

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8702: arch/nrf52: use the lates SoftDevice release (v2.3.0)

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8702: URL: https://github.com/apache/nuttx/pull/8702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (66c5f86018 -> 74ffdb0b49)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 66c5f86018 sched: Disable stdio api by default when DEFAULT_SMALL equals y new eda99e35bb arch/nrf52: use the

[GitHub] [nuttx] zyfeier commented on pull request #8645: mutex: move nxmutex to sched and add mutex_ interface for userspace

2023-03-02 Thread via GitHub
zyfeier commented on PR #8645: URL: https://github.com/apache/nuttx/pull/8645#issuecomment-1452804573 > I'm still not sure about this change. I know that some time in the past I drafter something similar, but after re-thinking I'm looking into a next direction: there is already one mutex la

[GitHub] [nuttx] hartmannathan commented on pull request #8658: Fix error: '%s' directive output may be truncated

2023-03-02 Thread via GitHub
hartmannathan commented on PR #8658: URL: https://github.com/apache/nuttx/pull/8658#issuecomment-1452803543 > Yes. Maybe we can decrease buffer size in `gpio_pin_register` instead of increasing it in `gpio_pin_register_byname`? Right. How many GPIO pins could we possibly have? If the

[GitHub] [nuttx-apps] masayuki2009 commented on pull request #1610: nsh: Improve performance of `help` by line buffer

2023-03-02 Thread via GitHub
masayuki2009 commented on PR #1610: URL: https://github.com/apache/nuttx-apps/pull/1610#issuecomment-1452707073 ``` Configuration/Tool: sim/vpnkit --

[nuttx-apps] branch master updated: Remove the tail space char from all files

2023-03-02 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 21bc466a2 Remove the tail space char

[GitHub] [nuttx-apps] pkarashchenko merged pull request #1599: Remove the tail space char from all files

2023-03-02 Thread via GitHub
pkarashchenko merged PR #1599: URL: https://github.com/apache/nuttx-apps/pull/1599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[nuttx] branch master updated: sched: Disable stdio api by default when DEFAULT_SMALL equals y

2023-03-02 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 66c5f86018 sched: Disable stdio api by def

[GitHub] [nuttx] pkarashchenko merged pull request #4819: sched: Disable stdio api by default when DEFAULT_SMALL equals y

2023-03-02 Thread via GitHub
pkarashchenko merged PR #4819: URL: https://github.com/apache/nuttx/pull/4819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8696: libc/stdio: Implement lib_get_stream

2023-03-02 Thread via GitHub
pkarashchenko commented on code in PR #8696: URL: https://github.com/apache/nuttx/pull/8696#discussion_r1123776469 ## libs/libc/stdio/lib_libgetstreams.c: ## @@ -57,4 +57,18 @@ FAR struct streamlist *lib_get_streams(void) return &info->ta_streamlist; } +/**

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8656: fs: Undefine CONFIG_FS_LARGEFILE if compiler doesn't support long long

2023-03-02 Thread via GitHub
pkarashchenko commented on code in PR #8656: URL: https://github.com/apache/nuttx/pull/8656#discussion_r1123773541 ## include/nuttx/compiler.h: ## @@ -944,6 +944,10 @@ #endif +#ifndef CONFIG_HAVE_LONG_LONG +# undef CONFIG_FS_LARGEFILE +#endif + Review Comment: Why not

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8684: Feature imxrt1064 mcuboot

2023-03-02 Thread via GitHub
pkarashchenko commented on code in PR #8684: URL: https://github.com/apache/nuttx/pull/8684#discussion_r1123766543 ## boards/arm/imxrt/imxrt1064-evk/src/imxrt_progmem.c: ## @@ -0,0 +1,255 @@ +/ + * board

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8685: libc/stream: Implement gets/puts for all streams

2023-03-02 Thread via GitHub
pkarashchenko commented on code in PR #8685: URL: https://github.com/apache/nuttx/pull/8685#discussion_r1123759291 ## libs/libc/stream/lib_stdsistream.c: ## @@ -52,6 +52,29 @@ static int stdsistream_getc(FAR struct lib_sistream_s *this) return ret; } +/

[GitHub] [nuttx] pkarashchenko commented on pull request #8645: mutex: move nxmutex to sched and add mutex_ interface for userspace

2023-03-02 Thread via GitHub
pkarashchenko commented on PR #8645: URL: https://github.com/apache/nuttx/pull/8645#issuecomment-1452594215 I'm still not sure about this change. I know that some time in the past I drafter something similar, but after re-thinking I'm looking into a next direction: there is already one mute

[GitHub] [nuttx] pkarashchenko commented on pull request #8658: Fix error: '%s' directive output may be truncated

2023-03-02 Thread via GitHub
pkarashchenko commented on PR #8658: URL: https://github.com/apache/nuttx/pull/8658#issuecomment-1452588679 Yes. Maybe we can decrease buffer size in `gpio_pin_register` instead of increasing it in `gpio_pin_register_byname`? -- This is an automated message from the Apache Git Service. To

[GitHub] [nuttx] hartmannathan commented on pull request #8658: Fix error: '%s' directive output may be truncated

2023-03-02 Thread via GitHub
hartmannathan commented on PR #8658: URL: https://github.com/apache/nuttx/pull/8658#issuecomment-1452500505 The only bad thing about increasing the sizes of stacked strings is that eventually we have to increase task stack sizes too, or we will face stack overflows. I don't know what to sug

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1603: Application: fix multiple main target mismatch during incremental compile

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #1603: URL: https://github.com/apache/nuttx-apps/pull/1603#discussion_r1123561483 ## Application.mk: ## @@ -202,17 +202,31 @@ else MAINNAME := $(addsuffix _main,$(PROGNAME)) +define getentryindex Review Comment: ```suggestion d

[nuttx] 01/02: boards/nrf52832-dk: add sdc examples

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 16a711c1e25d701fe79542c2462d166dd1bafbec Author: raiden00pl AuthorDate: Wed Dec 29 11:55:29 2021 +0100 boards/nrf

[nuttx] 02/02: boards/nrf52840-dk: add sdc examples

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 535df527cb0ae0feaa2d81477e09e094ab758914 Author: raiden00pl AuthorDate: Wed Dec 29 11:55:53 2021 +0100 boards/nrf

[nuttx] branch master updated (205ca26556 -> 535df527cb)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 205ca26556 libc/streams: Implement gets/puts for all streams new 16a711c1e2 boards/nrf52832-dk: add sdc example

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8688: boards/nrf52: sdc examples

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8688: URL: https://github.com/apache/nuttx/pull/8688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] raiden00pl opened a new pull request, #8702: arch/nrf52: use the lates SoftDevice release (v2.3.0)

2023-03-02 Thread via GitHub
raiden00pl opened a new pull request, #8702: URL: https://github.com/apache/nuttx/pull/8702 ## Summary arch/nrf52: use the lates SoftDevice release (v2.3.0) depends on https://github.com/apache/nuttx/pull/8688 ## Impact A list of breaking changes: - SoftDevice libraries

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8645: mutex: move nxmutex to sched and add mutex_ interface for userspace

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8645: URL: https://github.com/apache/nuttx/pull/8645#discussion_r1123468782 ## include/mutex.h: ## @@ -0,0 +1,577 @@ +/ + * include/mutex.h Review Comment: mu

[nuttx] branch master updated (6e35a51feb -> 205ca26556)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6e35a51feb note: optimize noteram_add, copy as much content as possible at a time add 205ca26556 libc/streams:

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8685: libc/stream: Implement gets/puts for all streams

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8685: URL: https://github.com/apache/nuttx/pull/8685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated: note: optimize noteram_add, copy as much content as possible at a time

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6e35a51feb note: optimize noteram_add, copy as

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8697: note: optimize noteram_add, copy as much content as possible at a time

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8697: URL: https://github.com/apache/nuttx/pull/8697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx-apps] davids5 commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
davids5 commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1123227117 ## benchmarks/coremark/Makefile: ## @@ -105,4 +105,8 @@ STACKSIZE += $(CONFIG_COREMARK_STACKSIZE) MAINSRC += core_main.c +# Build with WebAssembly Review Comme

[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #8685: libc/stream: Implement gets/puts for all streams

2023-03-02 Thread via GitHub
Gary-Hobson commented on code in PR #8685: URL: https://github.com/apache/nuttx/pull/8685#discussion_r1123224821 ## libs/libc/stream/lib_stdsostream.c: ## @@ -63,6 +63,42 @@ static void stdsostream_putc(FAR struct lib_sostream_s *this, int ch) while (get_errno() == EINTR);

[nuttx] branch master updated: iMXRT MCUboot support

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 081b04f05e iMXRT MCUboot support 081b04f05e is

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8684: Feature imxrt1064 mcuboot

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8684: URL: https://github.com/apache/nuttx/pull/8684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8685: libc/stream: Implement gets/puts for all streams

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8685: URL: https://github.com/apache/nuttx/pull/8685#discussion_r1123183807 ## libs/libc/stream/lib_stdoutstream.c: ## @@ -64,6 +65,43 @@ static void stdoutstream_putc(FAR struct lib_outstream_s *this, int ch) while (get_errno() == EI

[GitHub] [nuttx-apps] no1wudi commented on pull request #1610: nsh: Improve performance of `help` by line buffer

2023-03-02 Thread via GitHub
no1wudi commented on PR #1610: URL: https://github.com/apache/nuttx-apps/pull/1610#issuecomment-1451969383 @masayuki2009 Before commit 2: https://user-images.githubusercontent.com/9030616/222459070-a819004c-1049-49e3-bc8c-db5a41c38bd4.mp4 After: https://user-ima

[nuttx] branch master updated: clear i2c ints before the transfer starts

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new aeddec2ec5 clear i2c ints before the transfer

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8701: mpfs:clear i2c ints before the transfer starts

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8701: URL: https://github.com/apache/nuttx/pull/8701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx-apps] branch master updated: lvgl: silent download and unpack

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new cf9dd1c65 lvgl: silent download and unpac

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1588: lvgl: silent download and unpack

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #1588: URL: https://github.com/apache/nuttx-apps/pull/1588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1610: nsh: Improve performance of `help` by line buffer

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #1610: URL: https://github.com/apache/nuttx-apps/pull/1610#discussion_r1123176932 ## nshlib/nsh_command.c: ## @@ -650,22 +652,32 @@ static inline void help_cmdlist(FAR struct nsh_vtbl_s *vtbl) for (i = 0; i < ncmdrows; i++) { -

[nuttx-apps] branch master updated (ca403ffaf -> 832b160cb)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from ca403ffaf lvgl/port: optimize fbdev buffer sync algorithm add 832b160cb bluetooth/nimble: update to bc782

[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1611: bluetooth/nimble: update to bc7828341226d860429c63994065f8f1b8b8d7b0

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #1611: URL: https://github.com/apache/nuttx-apps/pull/1611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8698: boards: initial support for nrf5340-dk

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8698: URL: https://github.com/apache/nuttx/pull/8698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[nuttx] branch master updated (6ba906691a -> da76aa71aa)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 6ba906691a clear spi int before the transfer starts add 055a21b2fe nrf5340-audio-dk/README.txt: correct board n

[nuttx] branch master updated (ab5d6d759a -> 6ba906691a)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from ab5d6d759a arch/arm/src/stm32f7/stm32_i2c.c: Driver cleanup add 6ba906691a clear spi int before the transfer st

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8700: clear spi int before the transfer starts

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8700: URL: https://github.com/apache/nuttx/pull/8700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8691: drivers/serial: Echo input in driver layer

2023-03-02 Thread via GitHub
xiaoxiang781216 commented on code in PR #8691: URL: https://github.com/apache/nuttx/pull/8691#discussion_r1123136673 ## drivers/serial/serial.c: ## @@ -886,6 +888,53 @@ static ssize_t uart_read(FAR struct file *filep, *buffer++ = ch; recvd++; + +

[nuttx] branch master updated (dfc70b1ddb -> ab5d6d759a)

2023-03-02 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from dfc70b1ddb libc/stdio: Implement lib_get_stream add ab5d6d759a arch/arm/src/stm32f7/stm32_i2c.c: Driver cleanup

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8699: arch/arm/src/stm32f7/stm32_i2c.c: Driver cleanup

2023-03-02 Thread via GitHub
xiaoxiang781216 merged PR #8699: URL: https://github.com/apache/nuttx/pull/8699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [nuttx-apps] anchao commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
anchao commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1123115024 ## benchmarks/coremark/Makefile: ## @@ -105,4 +105,8 @@ STACKSIZE += $(CONFIG_COREMARK_STACKSIZE) MAINSRC += core_main.c +# Build with WebAssembly Review Commen

[GitHub] [nuttx] jnippula opened a new pull request, #8701: clear i2c ints before the transfer starts

2023-03-02 Thread via GitHub
jnippula opened a new pull request, #8701: URL: https://github.com/apache/nuttx/pull/8701 ## Summary In some state values the transfer is restarted in irq handler and the interrupts are disabled in the end of the function after the transfer is started. This may cause early interrupts to

[GitHub] [nuttx] jnippula opened a new pull request, #8700: clear spi int before the transfer starts

2023-03-02 Thread via GitHub
jnippula opened a new pull request, #8700: URL: https://github.com/apache/nuttx/pull/8700 ## Summary In mpfs spi_irq handler the data is written into txfifo and transfer is started before the TXDONE interrupt is cleared. If the bus/memory access is in some cases delayed, the SPI transfer

[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1611: bluetooth/nimble: update to bc7828341226d860429c63994065f8f1b8b8d7b0

2023-03-02 Thread via GitHub
raiden00pl opened a new pull request, #1611: URL: https://github.com/apache/nuttx-apps/pull/1611 ## Summary bluetooth/nimble: update to bc7828341226d860429c63994065f8f1b8b8d7b0 which fix https://github.com/apache/mynewt-nimble/pull/1472 ## Impact ## Testing -- T

[GitHub] [nuttx] jnippula opened a new pull request, #8699: arch/arm/src/stm32f7/stm32_i2c.c: Driver cleanup

2023-03-02 Thread via GitHub
jnippula opened a new pull request, #8699: URL: https://github.com/apache/nuttx/pull/8699 ## Summary Remove unnecessary heap memory allocation by relocating ops inside private data struct ## Impact This makes code execution faster and reduces possibility to have memory leaks

[GitHub] [nuttx] raiden00pl opened a new pull request, #8698: boards: initial support for nrf5340-dk

2023-03-02 Thread via GitHub
raiden00pl opened a new pull request, #8698: URL: https://github.com/apache/nuttx/pull/8698 ## Summary boards: initial support for nrf5340-dk ## Impact ## Testing nrf5340-dk/nsh on the APP core -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [nuttx-apps] davids5 commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
davids5 commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1122979081 ## benchmarks/coremark/Makefile: ## @@ -105,4 +105,8 @@ STACKSIZE += $(CONFIG_COREMARK_STACKSIZE) MAINSRC += core_main.c +# Build with WebAssembly Review Comme

[GitHub] [nuttx-apps] anchao commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
anchao commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1122972650 ## benchmarks/coremark/Makefile: ## @@ -105,4 +105,8 @@ STACKSIZE += $(CONFIG_COREMARK_STACKSIZE) MAINSRC += core_main.c +# Build with WebAssembly + +WASM_BUILD

[GitHub] [nuttx-apps] no1wudi commented on pull request #1610: nsh: Improve performance of `help` by line buffer

2023-03-02 Thread via GitHub
no1wudi commented on PR #1610: URL: https://github.com/apache/nuttx-apps/pull/1610#issuecomment-1451617475 > I think so too. Can you add a new commit to this PR? Yes, Ill' try to optimize it by merge multiple nsh_output into one. -- This is an automated message from the Apache Git S

[GitHub] [nuttx-apps] masayuki2009 commented on pull request #1610: nsh: Improve performance of `help` by line buffer

2023-03-02 Thread via GitHub
masayuki2009 commented on PR #1610: URL: https://github.com/apache/nuttx-apps/pull/1610#issuecomment-1451610590 @no1wudi I confirmed that this PR fixes the help command issue. >BTW, maybe the ps command meet the same issue. I think so too. Can you add a new commit to

[GitHub] [nuttx-apps] no1wudi commented on pull request #1610: nsh: Improve performance of `help` by line buffer

2023-03-02 Thread via GitHub
no1wudi commented on PR #1610: URL: https://github.com/apache/nuttx-apps/pull/1610#issuecomment-1451583079 @masayuki2009 This PR improve the performance of help command without NET_TCP_WRITE_BUFFER. BTW, maybe the `ps` command meet the same issue. https://user-images.githubuse

[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1610: nsh: Improve performance of `help` by line buffer

2023-03-02 Thread via GitHub
no1wudi opened a new pull request, #1610: URL: https://github.com/apache/nuttx-apps/pull/1610 ## Summary This change reduce the usage of `printf`, which will improve both CPU usage and IO performance. ## Impact help command ## Testing esp32c3 and telnet

[GitHub] [nuttx-apps] davids5 commented on a diff in pull request #1609: interpreters/wamr: add compile role of WebAssembly

2023-03-02 Thread via GitHub
davids5 commented on code in PR #1609: URL: https://github.com/apache/nuttx-apps/pull/1609#discussion_r1122824771 ## benchmarks/coremark/Makefile: ## @@ -105,4 +105,8 @@ STACKSIZE += $(CONFIG_COREMARK_STACKSIZE) MAINSRC += core_main.c +# Build with WebAssembly + +WASM_BUILD

[GitHub] [nuttx] no1wudi commented on pull request #8641: stdio: Implement simple buffered out stream for vdprintf

2023-03-02 Thread via GitHub
no1wudi commented on PR #8641: URL: https://github.com/apache/nuttx/pull/8641#issuecomment-1451544154 @masayuki2009 I'll try to optimize the performance of these nsh builtin commands -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[nuttx] branch master updated: libc/stdio: Implement lib_get_stream

2023-03-02 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new dfc70b1ddb libc/stdio: Implement lib_get_stream

[GitHub] [nuttx] jerpelea merged pull request #8696: libc/stdio: Implement lib_get_stream

2023-03-02 Thread via GitHub
jerpelea merged PR #8696: URL: https://github.com/apache/nuttx/pull/8696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[nuttx] branch master updated: sim/wamr: add example of WAMR(WebAssembly Micro Runtime)

2023-03-02 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new b01b93cb54 sim/wamr: add example of WAMR(WebAss

[GitHub] [nuttx] jerpelea merged pull request #8695: sim/wamr: add example of WAMR(WebAssembly Micro Runtime)

2023-03-02 Thread via GitHub
jerpelea merged PR #8695: URL: https://github.com/apache/nuttx/pull/8695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[GitHub] [nuttx] Gary-Hobson commented on pull request #8697: note: optimize noteram_add, copy as much content as possible at a time

2023-03-02 Thread via GitHub
Gary-Hobson commented on PR #8697: URL: https://github.com/apache/nuttx/pull/8697#issuecomment-1451496540 > please add a commit description have updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[nuttx] branch master updated (d2d954f691 -> 92b2f1bd3d)

2023-03-02 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from d2d954f691 arm64: ARMv8-r(Cortex-R82) support( add FVP platform ) add 92b2f1bd3d fs: Undefine CONFIG_FS_LARGEFIL

[GitHub] [nuttx] jerpelea merged pull request #8656: fs: Undefine CONFIG_FS_LARGEFILE if compiler doesn't support long long

2023-03-02 Thread via GitHub
jerpelea merged PR #8656: URL: https://github.com/apache/nuttx/pull/8656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apach

[GitHub] [nuttx] Gary-Hobson opened a new pull request, #8697: note: optimize noteram_add, copy as much content as possible at a time

2023-03-02 Thread via GitHub
Gary-Hobson opened a new pull request, #8697: URL: https://github.com/apache/nuttx/pull/8697 ## Summary optimize noteram_add, copy as much content as possible at a time ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the