anchao commented on code in PR #7890:
URL: https://github.com/apache/nuttx/pull/7890#discussion_r1051880874
##
mm/iob/iob_initialize.c:
##
@@ -117,25 +118,18 @@ sem_t g_qentry_sem = SEM_INITIALIZER(CONFIG_IOB_NCHAINS);
void iob_initialize(void)
{
int i;
- uintptr_t buf;
-
anchao commented on code in PR #7890:
URL: https://github.com/apache/nuttx/pull/7890#discussion_r1051880735
##
mm/iob/iob_initialize.c:
##
@@ -52,11 +51,13 @@
*/
#ifdef IOB_SECTION
-static uint8_t g_iob_buffer[IOB_BUFFER_SIZE] locate_data(IOB_SECTION);
+static uint8_t g_iob
anchao opened a new pull request, #7920:
URL: https://github.com/apache/nuttx/pull/7920
## Summary
mm/iob: revert "modify iob to support header padding and alignment features"
we don't need to implement l2 isolation through io_head, iob offload will
use io_offset
```
anchao commented on code in PR #7914:
URL: https://github.com/apache/nuttx/pull/7914#discussion_r1051783495
##
net/tcp/tcp_recvwindow.c:
##
@@ -163,7 +165,29 @@ uint32_t tcp_get_recvwindow(FAR struct net_driver_s *dev,
tailroom = 0;
}
+ /* Get the number of buffer
anchao commented on code in PR #7914:
URL: https://github.com/apache/nuttx/pull/7914#discussion_r1051783080
##
net/tcp/tcp_recvwindow.c:
##
@@ -163,7 +165,29 @@ uint32_t tcp_get_recvwindow(FAR struct net_driver_s *dev,
tailroom = 0;
}
+ /* Get the number of buffer
xiaoxiang781216 commented on code in PR #1461:
URL: https://github.com/apache/nuttx-apps/pull/1461#discussion_r1051746309
##
interpreters/quickjs/qjsmini.c:
##
@@ -168,14 +168,14 @@ static void *js_trace_malloc(JSMallocState *s, size_t
size)
assert(size != 0);
- if (unl
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 4d2794250f net/local: Support the abstract path
add 9eea82a61d Doc: Explain how to rebase and squash PR's commi
xiaoxiang781216 merged PR #7918:
URL: https://github.com/apache/nuttx/pull/7918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
gustavonihei commented on PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#issuecomment-1356997839
Thanks for the contribution, @halyssonJr!
Tomorrow I’ll do a full review of the PR, for now I just made one change
request that caught my attention.
--
This is an automated messa
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1051740166
##
boards/Kconfig:
##
@@ -370,7 +370,16 @@ config ARCH_BOARD_ESP32S2_SAOLA_1
select ARCH_HAVE_IRQBUTTONS if ESP32S2_GPIO_IRQ
---help---
lupyuen opened a new pull request, #7919:
URL: https://github.com/apache/nuttx/pull/7919
## Summary
This PR adds the driver for TCON0 (Timing Controller) on Allwinner A64 SoC.
The TCON0 Driver will be used by the upcoming Display Driver for PINE64
PinePhone.
### Modified Files
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 51d63155 Publishing web: 4b401e13
acassis opened a new pull request, #7918:
URL: https://github.com/apache/nuttx/pull/7918
## Summary
Explain how to rebase and squash PR's commits
## Impact
It will be easier to new contributors understand how to squash the commits
## Testing
N/A
--
This is an automated m
raiden00pl commented on PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#issuecomment-1356857642
@pkarashchenko thanks for the review. I fixed most of the issues, but in
some places I prefer old code (zeroed variables and brackets for long math
expressions)
--
This is an aut
raiden00pl commented on code in PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051650601
##
logging/nxscope/nxscope_pser.c:
##
@@ -0,0 +1,297 @@
+/
+ * apps/logging/nxscope/nx
raiden00pl commented on code in PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051650505
##
logging/nxscope/nxscope_iser.c:
##
@@ -0,0 +1,248 @@
+/
+ * apps/logging/nxscope/nx
raiden00pl commented on code in PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051650350
##
logging/nxscope/nxscope.c:
##
@@ -0,0 +1,1142 @@
+/
+ * apps/logging/nxscope/nxscop
raiden00pl commented on code in PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051650150
##
logging/nxscope/nxscope_pser.c:
##
@@ -0,0 +1,297 @@
+/
+ * apps/logging/nxscope/nx
raiden00pl commented on code in PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051650002
##
logging/nxscope/nxscope.c:
##
@@ -0,0 +1,1142 @@
+/
+ * apps/logging/nxscope/nxscop
raiden00pl commented on code in PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051649667
##
logging/nxscope/nxscope_pser.c:
##
@@ -0,0 +1,297 @@
+/
+ * apps/logging/nxscope/nx
raiden00pl commented on code in PR #1460:
URL: https://github.com/apache/nuttx-apps/pull/1460#discussion_r1051649113
##
logging/nxscope/nxscope_chan.c:
##
@@ -0,0 +1,1564 @@
+/
+ * apps/logging/nxscope/n
pkarashchenko commented on code in PR #1461:
URL: https://github.com/apache/nuttx-apps/pull/1461#discussion_r1051644241
##
interpreters/quickjs/qjsmini.c:
##
@@ -168,14 +168,14 @@ static void *js_trace_malloc(JSMallocState *s, size_t
size)
assert(size != 0);
- if (unlik
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 6f15b32e34 net/tcp: rename NET_TCP_RECV_CONTIG to NET_TCP_RECV_PACK
add aea8f8175a net/local: Return -EINVA
pkarashchenko merged PR #7912:
URL: https://github.com/apache/nuttx/pull/7912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.
xiaoxiang781216 commented on code in PR #1461:
URL: https://github.com/apache/nuttx-apps/pull/1461#discussion_r1051639810
##
system/spi/spitool.h:
##
@@ -177,7 +177,7 @@ ssize_t spitool_exchange(FAR struct spitool_s *spitool,
FAR const void *outbuffer,
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 794adc5814 net/tcp: contig received data to reducing iob consumption
add 4f239e145e Revert "mm/iob/contig: enha
xiaoxiang781216 merged PR #7916:
URL: https://github.com/apache/nuttx/pull/7916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
anchao commented on code in PR #7890:
URL: https://github.com/apache/nuttx/pull/7890#discussion_r1051628737
##
include/nuttx/mm/iob.h:
##
@@ -114,6 +114,14 @@ struct iob_s
#endif
unsigned int io_pktlen; /* Total length of the packet */
+#ifdef CONFIG_IOB_SHARED
+ /* Point
pkarashchenko commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1051626933
##
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bringup.c:
##
@@ -0,0 +1,278 @@
+/*
halyssonJr opened a new pull request, #7917:
URL: https://github.com/apache/nuttx/pull/7917
## Summary
Add new board ESP32S2 Franzininho WiFi
## Impact
New feature
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the messa
anchao commented on code in PR #7916:
URL: https://github.com/apache/nuttx/pull/7916#discussion_r1051623857
##
net/tcp/tcp_callback.c:
##
@@ -258,12 +258,15 @@ uint16_t tcp_datahandler(FAR struct net_driver_s *dev,
iob_concat(conn->readahead, iob);
}
-#ifdef CONFIG
pkarashchenko commented on code in PR #1461:
URL: https://github.com/apache/nuttx-apps/pull/1461#discussion_r1051623160
##
system/spi/spitool.h:
##
@@ -177,7 +177,7 @@ ssize_t spitool_exchange(FAR struct spitool_s *spitool,
FAR const void *outbuffer, si
xiaoxiang781216 commented on code in PR #7916:
URL: https://github.com/apache/nuttx/pull/7916#discussion_r1051622758
##
net/tcp/tcp_callback.c:
##
@@ -258,12 +258,15 @@ uint16_t tcp_datahandler(FAR struct net_driver_s *dev,
iob_concat(conn->readahead, iob);
}
-#ifd
anchao opened a new pull request, #7916:
URL: https://github.com/apache/nuttx/pull/7916
## Summary
1. net/tcp: rename NET_TCP_RECV_CONTIG to NET_TCP_RECV_PACK
2. Revert "mm/iob/contig: enhance iob contig to support iob chain"
use iob_pack instead of iob_contig
## I
xiaoxiang781216 opened a new pull request, #1461:
URL: https://github.com/apache/nuttx-apps/pull/1461
Signed-off-by: Xiang Xiao
## Summary
align with other macro naming style, need merge with
https://github.com/apache/nuttx/pull/7915
## Impact
format specifiler
##
xiaoxiang781216 opened a new pull request, #7915:
URL: https://github.com/apache/nuttx/pull/7915
## Summary
align with other macro naming style
## Impact
format specifier
## Testing
local
--
This is an automated message from the Apache Git Service.
To respond
pkarashchenko commented on code in PR #1446:
URL: https://github.com/apache/nuttx-apps/pull/1446#discussion_r1051610975
##
testing/himem_test/himem_chardev_test.c:
##
@@ -0,0 +1,437 @@
+/
+ * apps/testin
pkarashchenko commented on PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#issuecomment-1356806998
@acassis would you please merge the PR if you are ok with the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
xiaoxiang781216 commented on code in PR #7890:
URL: https://github.com/apache/nuttx/pull/7890#discussion_r1051601118
##
mm/iob/iob_initialize.c:
##
@@ -52,11 +51,13 @@
*/
#ifdef IOB_SECTION
-static uint8_t g_iob_buffer[IOB_BUFFER_SIZE] locate_data(IOB_SECTION);
+static uint
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051603845
##
net/local/local_connect.c:
##
@@ -238,7 +238,9 @@ int psock_local_connect(FAR struct socket *psock,
{
FAR struct local_conn_s *client;
FAR struct sockaddr
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051603845
##
net/local/local_connect.c:
##
@@ -238,7 +238,9 @@ int psock_local_connect(FAR struct socket *psock,
{
FAR struct local_conn_s *client;
FAR struct sockaddr
xiaoxiang781216 commented on code in PR #7914:
URL: https://github.com/apache/nuttx/pull/7914#discussion_r1051600356
##
net/tcp/tcp_recvwindow.c:
##
@@ -163,7 +165,29 @@ uint32_t tcp_get_recvwindow(FAR struct net_driver_s *dev,
tailroom = 0;
}
+ /* Get the number
xiaoxiang781216 commented on code in PR #7913:
URL: https://github.com/apache/nuttx/pull/7913#discussion_r1051600150
##
include/nuttx/mm/iob.h:
##
@@ -562,12 +562,12 @@ FAR struct iob_s *iob_pack(FAR struct iob_s *iob);
* Name: iob_contig
*
* Description:
- * Ensure that
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from da9a2b9770 compiler.h: Add fopen_like and popen_like macro
add 56a4e90dc4 mm/iob/contig: enhance iob contig to
xiaoxiang781216 merged PR #7913:
URL: https://github.com/apache/nuttx/pull/7913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nutt
xiaoxiang781216 commented on code in PR #7890:
URL: https://github.com/apache/nuttx/pull/7890#discussion_r1051592644
##
mm/iob/iob_initialize.c:
##
@@ -52,11 +51,13 @@
*/
#ifdef IOB_SECTION
-static uint8_t g_iob_buffer[IOB_BUFFER_SIZE] locate_data(IOB_SECTION);
+static uint
acassis commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051594340
##
net/local/local_connect.c:
##
@@ -238,7 +238,9 @@ int psock_local_connect(FAR struct socket *psock,
{
FAR struct local_conn_s *client;
FAR struct sockaddr_un *u
acassis commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051594340
##
net/local/local_connect.c:
##
@@ -238,7 +238,9 @@ int psock_local_connect(FAR struct socket *psock,
{
FAR struct local_conn_s *client;
FAR struct sockaddr_un *u
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from 6e66603da5 arch/sim: Disable interrupt in up_interrupt_context for SMP
add e1f45857e3 compiler.h: Add malloc_like
acassis merged PR #7859:
URL: https://github.com/apache/nuttx/pull/7859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051591178
##
net/local/local_connect.c:
##
@@ -238,7 +238,9 @@ int psock_local_connect(FAR struct socket *psock,
{
FAR struct local_conn_s *client;
FAR struct sockaddr
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051589720
##
net/local/local_bind.c:
##
@@ -52,49 +52,47 @@ int psock_local_bind(FAR struct socket *psock,
FAR struct local_conn_s *conn;
FAR const struct sockaddr_un *
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051589331
##
net/local/local_bind.c:
##
@@ -52,49 +52,47 @@ int psock_local_bind(FAR struct socket *psock,
FAR struct local_conn_s *conn;
FAR const struct sockaddr_un *
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051589090
##
net/local/local_bind.c:
##
@@ -52,49 +52,47 @@ int psock_local_bind(FAR struct socket *psock,
FAR struct local_conn_s *conn;
FAR const struct sockaddr_un *
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051589090
##
net/local/local_bind.c:
##
@@ -52,49 +52,47 @@ int psock_local_bind(FAR struct socket *psock,
FAR struct local_conn_s *conn;
FAR const struct sockaddr_un *
xiaoxiang781216 commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051589021
##
net/local/local_bind.c:
##
@@ -55,46 +55,44 @@ int psock_local_bind(FAR struct socket *psock,
int namelen;
DEBUGASSERT(psock != NULL && psock->s_conn !
xiaoxiang781216 commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051588651
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051588481
##
net/local/local_bind.c:
##
@@ -55,46 +55,44 @@ int psock_local_bind(FAR struct socket *psock,
int namelen;
DEBUGASSERT(psock != NULL && psock->s_conn !=
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051587831
##
net/local/local_bind.c:
##
@@ -55,46 +55,44 @@ int psock_local_bind(FAR struct socket *psock,
int namelen;
DEBUGASSERT(psock != NULL && psock->s_conn !=
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051587560
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &&
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051587560
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &&
xiaoxiang781216 commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051587234
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051586990
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &&
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051586990
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &&
xiaoxiang781216 commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051586712
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051586316
##
net/local/local_sockif.c:
##
@@ -380,11 +380,12 @@ static int local_getsockname(FAR struct socket *psock,
*addrlen = sizeof(sa_family_t);
}
anchao opened a new pull request, #7914:
URL: https://github.com/apache/nuttx/pull/7914
## Summary
net/tcp: reserve NIC iob from advertise window
The iob occupied by the nic should be removed when calculating the advertise
window
Signed-off-by: chao an
## Impact
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051571488
##
net/local/local_bind.c:
##
@@ -58,43 +58,43 @@ int psock_local_bind(FAR struct socket *psock,
unaddr != NULL && unaddr->sun_family == AF_LOCAL &&
xiaoxiang781216 commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051570647
##
net/local/local_connect.c:
##
@@ -238,7 +238,9 @@ int psock_local_connect(FAR struct socket *psock,
{
FAR struct local_conn_s *client;
FAR struct sockad
anchao opened a new pull request, #7913:
URL: https://github.com/apache/nuttx/pull/7913
## Summary
1. net/tcp: contig received data to reducing iob consumption
Fragmentation of network data will intensify iob consumption, if
the device receives a message storm of fragmented p
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051560015
##
net/local/local_sockif.c:
##
@@ -384,7 +384,8 @@ static int local_getsockname(FAR struct socket *psock,
{
/* Get the full length of the socke
pkarashchenko commented on code in PR #7912:
URL: https://github.com/apache/nuttx/pull/7912#discussion_r1051559141
##
net/local/local_sockif.c:
##
@@ -399,8 +400,15 @@ static int local_getsockname(FAR struct socket *psock,
/* Copy the path into the user address stru
xiaoxiang781216 opened a new pull request, #7912:
URL: https://github.com/apache/nuttx/pull/7912
## Summary
And other minor change:
- net/local: Return -EINVAL if the address length passed to local_bind is
too small
- net/local: Remove LOCAL_TYPE_UNTYPED
## Impact
loca
73 matches
Mail list logo
