[GitHub] [incubator-nuttx-apps] Junbo-Zheng commented on pull request #1380: README.md: remove inaccessible links

2022-10-23 Thread GitBox
Junbo-Zheng commented on PR #1380: URL: https://github.com/apache/incubator-nuttx-apps/pull/1380#issuecomment-1288494281 > Note that the NuttX Porting Guide is currently in the CWIKI: https://cwiki.apache.org/confluence/display/NUTTX/Porting+Guide > > It would perhaps be better to up

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7409: boards/arm/gcc: disable coverage analysis temporarily

2022-10-23 Thread GitBox
pkarashchenko commented on PR #7409: URL: https://github.com/apache/incubator-nuttx/pull/7409#issuecomment-1288482951 Anyway I still think that we are too fast with toolchain upgrade, but I'm more conservative. Do we have a significant gain in optimisation with new compiler? Or what is the

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7409: boards/arm/gcc: disable coverage analysis temporarily

2022-10-23 Thread GitBox
anchao opened a new pull request, #7409: URL: https://github.com/apache/incubator-nuttx/pull/7409 ## Summary boards/arm/gcc: disable coverage analysis temporarily **Please revert this change if arm resolved this issue in the next release** ARM GNU toolchain 11.3.Rel1

[GitHub] [incubator-nuttx] SPRESENSE commented on a diff in pull request #7402: drivers/modem/alt1250: Fix poll function

2022-10-23 Thread GitBox
SPRESENSE commented on code in PR #7402: URL: https://github.com/apache/incubator-nuttx/pull/7402#discussion_r1002896707 ## drivers/modem/alt1250/alt1250.c: ## @@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev, nxmutex_unlock(&dev->evtmap

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7408: drivers/modem/alt1250: Change return type of bool function

2022-10-23 Thread GitBox
SPRESENSE opened a new pull request, #7408: URL: https://github.com/apache/incubator-nuttx/pull/7408 ## Summary Changed the return type to bool pointed out in the review comments for https://github.com/apache/incubator-nuttx/pull/7402. ## Impact None ## Testing

[incubator-nuttx] branch master updated (2fd7e18a16 -> 306029e6e4)

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 2fd7e18a16 include/sys: fix style issues in queue.h add 306029e6e4 lte: Include nuttx/fs/ioctl.h inst

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7403: lte: Include nuttx/fs/ioctl.h instead of wireless.h

2022-10-23 Thread GitBox
xiaoxiang781216 merged PR #7403: URL: https://github.com/apache/incubator-nuttx/pull/7403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7402: drivers/modem/alt1250: Fix poll function

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7402: URL: https://github.com/apache/incubator-nuttx/pull/7402#discussion_r1002886204 ## drivers/modem/alt1250/alt1250.c: ## @@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct alt1250_dev_s *dev, nxmutex_unlock(&dev->ev

[incubator-nuttx] branch master updated (33f903178e -> 2fd7e18a16)

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 33f903178e drivers/modem/alt1250: Fix poll function add a742ff arch/risc-v/src/mpfs/hardware: fix

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7396: Style fixes

2022-10-23 Thread GitBox
xiaoxiang781216 merged PR #7396: URL: https://github.com/apache/incubator-nuttx/pull/7396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated (8c1036b7a1 -> 33f903178e)

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 8c1036b7a1 tools/ci/docker/linux/Dockerfile: Keep the installation in alphabetical order add 33f9031

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7402: drivers/modem/alt1250: Fix poll function

2022-10-23 Thread GitBox
xiaoxiang781216 merged PR #7402: URL: https://github.com/apache/incubator-nuttx/pull/7402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] W-Mai commented on a diff in pull request #7407: ci/docker: copy `clang-extdef-mapping` to clang-arm

2022-10-23 Thread GitBox
W-Mai commented on code in PR #7407: URL: https://github.com/apache/incubator-nuttx/pull/7407#discussion_r1002869309 ## tools/ci/docker/linux/Dockerfile: ## @@ -308,6 +308,7 @@ ENV PATH="/tools/rust/cargo/bin:$PATH" # ARM toolchain COPY --from=nuttx-toolchain-arm /tools/clan

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7407: ci/docker: copy `clang-extdef-mapping` to clang-arm

2022-10-23 Thread GitBox
xiaoxiang781216 commented on code in PR #7407: URL: https://github.com/apache/incubator-nuttx/pull/7407#discussion_r1002869097 ## tools/ci/docker/linux/Dockerfile: ## @@ -308,6 +308,7 @@ ENV PATH="/tools/rust/cargo/bin:$PATH" # ARM toolchain COPY --from=nuttx-toolchain-arm /

[GitHub] [incubator-nuttx] W-Mai opened a new pull request, #7407: ci/docker: copy `clang-extdef-mapping` to clang-arm

2022-10-23 Thread GitBox
W-Mai opened a new pull request, #7407: URL: https://github.com/apache/incubator-nuttx/pull/7407 ## Summary Clang relies on clang-extdef-mapping for ctu checking. But clang-arm doesn't provide this file A tweaking way to support this feature is copy a `clang-extdef-mapping` from

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
xiaoxiang781216 merged PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated: Fixed compiler warnings.

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new d251d12f6 Fixed compiler warnin

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#issuecomment-1288384476 Let's ignore the know ci broken issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288380466 @anchao is looking this problem, look like the toolchain compile libgcov with the wrong config. Anyway, if we can't fix the problem soon, we can temp disable gcov option f

[GitHub] [incubator-nuttx-apps] SPRESENSE opened a new pull request, #1383: wireless: gs2200m: Change usrsock xid from uint64_t to uint32_t

2022-10-23 Thread GitBox
SPRESENSE opened a new pull request, #1383: URL: https://github.com/apache/incubator-nuttx-apps/pull/1383 ## Summary Fix the type to match usrsock.h has been changed by https://github.com/apache/incubator-nuttx/pull/6893 ## Impact ## Testing -- This is an automate

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7406: arch: cxd56xx: Fix stall bulk xfer when sending 512 byte data

2022-10-23 Thread GitBox
SPRESENSE opened a new pull request, #7406: URL: https://github.com/apache/incubator-nuttx/pull/7406 ## Summary Remove hardware zero length packet enhancement because of driver logic already processed the ZLP correctly. It is unnecessary and cause of IN interrupt lost. ## Impact

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7405: arch: cxd56xx: Fix deadlock by using GNSS CEP file on SPI-Flash

2022-10-23 Thread GitBox
SPRESENSE opened a new pull request, #7405: URL: https://github.com/apache/incubator-nuttx/pull/7405 ## Summary If you specify a file path on SPI-Flash in CONFIG_CXD56_GNSS_CEP_FILENAME, it causes a deadlock issue in the inter-CPU communication. To resolve it, introduce a new CONFIG_CXD5

[GitHub] [incubator-nuttx] Donny9 opened a new pull request, #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS

2022-10-23 Thread GitBox
Donny9 opened a new pull request, #7404: URL: https://github.com/apache/incubator-nuttx/pull/7404 ## Summary The default size of file cache is size of a sector, it may not be good size for optimizing read speed in physical device. So we can set the config according to speed test

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7401: URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1288336647 please rebase the change to fix the ci error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288336313 @tito97sp please rebase the change to the last mainline to fix the ci error. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7403: lte: Include nuttx/fs/ioctl.h instead of wireless.h

2022-10-23 Thread GitBox
SPRESENSE opened a new pull request, #7403: URL: https://github.com/apache/incubator-nuttx/pull/7403 ## Summary lte command definitions are separated from wireless ioctl. ## Impact No ## Testing spresense lte works well. -- This is an automated message from the A

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7402: drivers/modem/alt1250: Fix poll function

2022-10-23 Thread GitBox
SPRESENSE opened a new pull request, #7402: URL: https://github.com/apache/incubator-nuttx/pull/7402 ## Summary Notify only when there are available events. ## Impact modem/alt1250 only ## Testing spresense lte works well. -- This is an automated message from the

[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7383: CI: add example to sim

2022-10-23 Thread GitBox
ttnie commented on code in PR #7383: URL: https://github.com/apache/incubator-nuttx/pull/7383#discussion_r1002815874 ## tools/ci/testrun/script/test_example/test_example.py: ## @@ -0,0 +1,44 @@ +#!/usr/bin/python3 +# encoding: utf-8 +import pytest + +pytestmark = [pytest.mark.co

[incubator-nuttx-website] branch asf-site updated: Publishing web: d696c67810809c3f81a4dd87b09d9e940db854b4 docs: 8c1036b7a1a7971fead89f070974fc8c60a6ad18

2022-10-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new a03f468 Publishing web

[incubator-nuttx] 02/02: tools/ci/docker/linux/Dockerfile: Keep the installation in alphabetical order

2022-10-23 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8c1036b7a1a7971fead89f070974fc8c60a6ad18 Author: Xiang Xiao AuthorDate: Mon Oct 24 01:05:13 2022 +0800 t

[incubator-nuttx] branch master updated (4aad964d48 -> 8c1036b7a1)

2022-10-23 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 4aad964d48 Fix sam4s_nand.c:152:3: error: this 'while' clause does not guard... [-Werror=misleading-indent

[incubator-nuttx] 01/02: tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image

2022-10-23 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit d922119f0acc69debd775379ee2a73d97032b8dc Author: Xiang Xiao AuthorDate: Mon Oct 24 00:44:20 2022 +0800 t

[GitHub] [incubator-nuttx] btashton merged pull request #7399: tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image

2022-10-23 Thread GitBox
btashton merged PR #7399: URL: https://github.com/apache/incubator-nuttx/pull/7399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@n

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002779246 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void board_la

[GitHub] [incubator-nuttx] tito97sp closed pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp closed pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c URL: https://github.com/apache/incubator-nuttx/pull/7400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002779246 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void board_la

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773918 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void boa

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void board_la

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773744 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void boa

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void board_la

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void board_la

[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
fjpanag commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002769220 ## netutils/webclient/webclient.c: ## @@ -797,6 +798,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx, int offset; int nd

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
pkarashchenko commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288197425 @xiaoxiang781216 seems like the new toolchain has an issue with `gcov`: ``` rm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libarch.a(rp2040_start.o): in funct

[incubator-nuttx] branch master updated (ee82f7b5ca -> 4aad964d48)

2022-10-23 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from ee82f7b5ca Fix error: proxies/PROXY_socketpair.c:9:55: error: argument 4 of type 'int *' declared as

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
pkarashchenko merged PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002768208 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface

2022-10-23 Thread GitBox
pkarashchenko opened a new pull request, #7401: URL: https://github.com/apache/incubator-nuttx/pull/7401 ## Summary This PR contain few fixes for stm32h7 flash interface: - Fix cache invalidation before reading flash data after flash erase operation - Fix `stm32h7_israngeerased` ope

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002766985 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void board_la

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002764169 ## netutils/webclient/webclient.c: ## @@ -965,6 +968,7 @@ static inline int wget_parsechunktrailer(struct webclient_context *ctx, int offset;

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002763737 ## boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c: ## @@ -86,7 +86,7 @@ void stm32_boardinitialize(void) #ifdef CONFIG_BOARD_LATE_INITIALIZE void boa

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002762069 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flu

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002761824 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /

[GitHub] [incubator-nuttx] tito97sp opened a new pull request, #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

2022-10-23 Thread GitBox
tito97sp opened a new pull request, #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400 Signed-off-by: Andrés Sánchez Pascual ## Summary `stm32_bringup()` not reachable. Fix CONFIG_LIB_BOARDCTL build cap in `board_late_initialize()` function ## Impact

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
xiaoxiang781216 commented on code in PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002751126 ## arch/arm/src/sam34/sam4s_nand.c: ## @@ -149,7 +149,11 @@ static int nand_wait_ready(struct sam_nandcs_s *priv) /* The ready/busy (R/nB) signal o

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002749169 ## arch/arm/src/sam34/sam4s_nand.c: ## @@ -149,7 +149,11 @@ static int nand_wait_ready(struct sam_nandcs_s *priv) /* The ready/busy (R/nB) signal of

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002748381 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flu

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002748381 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flu

[GitHub] [incubator-nuttx] tito97sp commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
tito97sp commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288164142 PR blocked by https://github.com/apache/incubator-nuttx/pull/7398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7391: tools/ci/testlist: Switch half build to clang

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7391: URL: https://github.com/apache/incubator-nuttx/pull/7391#issuecomment-1288157867 depend on https://github.com/apache/incubator-nuttx/pull/7399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[incubator-nuttx-apps] branch master updated: industry/foc/foc_ident: make the Ki resistance measurement parameter configurable

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 8d61a10a7 industry/foc/foc_iden

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1375: foc_ident: make the Ki resistance measurement parameter configurable

2022-10-23 Thread GitBox
xiaoxiang781216 merged PR #1375: URL: https://github.com/apache/incubator-nuttx-apps/pull/1375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1375: foc_ident: make the Ki resistance measurement parameter configurable

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #1375: URL: https://github.com/apache/incubator-nuttx-apps/pull/1375#issuecomment-1288157528 let's ignore the ci broken and merge this simple change directly -- This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-nuttx-apps] 06/07: Revert "Revert "examples/foc: fix description in Kconfig""

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 0fe45a4c7320207da0d578197ae139518e367149 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:08:16 202

[incubator-nuttx-apps] 04/07: Revert "Revert "nshlib: fix possible out of bounds array access""

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit ec1c5f92739e8ec15751cfb04be11c057a96e594 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:07:54 202

[incubator-nuttx-apps] 05/07: Revert "Revert "examples/timer_gpio: fix initialization of timer notification""

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 9368b659a763faa4e45b657ea71922b651751aa5 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:08:03 202

[incubator-nuttx-apps] 07/07: netutils/thttpd: remove MIN and MAX definitions from libhttpd.c

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 5862b9d15cbaf570a2e8166b440bb0044f45c443 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:09:04 202

[incubator-nuttx-apps] branch master updated (9ba5c86bc -> 5862b9d15)

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 9ba5c86bc README.md: remove inaccessible links new 7c8f0e41f Revert "Revert "include/canutils/le

[incubator-nuttx-apps] 03/07: Revert "Revert "system/spi: improve alignment in array initialization""

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 7bf9025f28c68d0cdab67a0429c24f718ef5ff59 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:07:18 202

[incubator-nuttx-apps] 01/07: Revert "Revert "include/canutils/lely: fix file path in comment header""

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 7c8f0e41fc2ade4a57ef3e0788e9002d0c3e4f62 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:06:52 202

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1381: Minor fixes

2022-10-23 Thread GitBox
xiaoxiang781216 merged PR #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] 02/07: Revert "Revert "system/libuv: minor style fixes in Makefile""

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 513662732d060b2094e67edb4190a5edcd7853e6 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:07:06 202

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7399: tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image

2022-10-23 Thread GitBox
xiaoxiang781216 opened a new pull request, #7399: URL: https://github.com/apache/incubator-nuttx/pull/7399 ## Summary and keep the installation in alphabetical order ## Impact Required by arm clang toolchain, reported here: https://github.com/apache/incubator-nuttx/actions/ru

[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
fjpanag commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002740169 ## netutils/webclient/webclient.c: ## @@ -1873,7 +1877,7 @@ int webclient_perform(FAR struct webclient_context *ctx) DEBUGASSERT(bytes_to

[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
fjpanag commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002740068 ## netutils/webclient/webclient.c: ## @@ -904,6 +906,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx, static inline int wget_

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002735010 ## netutils/webclient/webclient.c: ## @@ -904,6 +906,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx, static inline int

[GitHub] [incubator-nuttx] btashton commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
btashton commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288148091 > It's hard to compile all config in the local machine. It's more simple that ci use the new docker image(instead the old) run all config if the patch change Dockerfile. @btashto

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288146490 It's hard to compile all config in the local machine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-nuttx-apps] fjpanag opened a new pull request, #1382: Fixed compiler warnings.

2022-10-23 Thread GitBox
fjpanag opened a new pull request, #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382 ## Summary Fixes a couple of compiler warnings. ## Impact N/A ## Testing Build test. -- This is an automated message from the Apache Git Service. T

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
pkarashchenko commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288141729 > > Still some other errors remain > > Fix here: https://github.com/apache/incubator-nuttx/pull/7398/commits/8b78bcc9649d26b27a82394e7f6a19c68a386553 > The new gcc

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288138643 > Still some other errors remain Fix here: https://github.com/apache/incubator-nuttx/pull/7398/commits/8b78bcc9649d26b27a82394e7f6a19c68a386553 The new gcc versio

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
pkarashchenko commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288130247 Still some other errors remain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002714821 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002712991 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flu

[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002712991 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
xiaoxiang781216 commented on code in PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002710219 ## drivers/mmcsd/mmcsd_sdio.c: ## @@ -2659,6 +2659,8 @@ static int mmcsd_read_csd(FAR struct mmcsd_state_s *priv) return -EPERM; } + mems

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002708020 ## drivers/mmcsd/mmcsd_sdio.c: ## @@ -2659,6 +2659,8 @@ static int mmcsd_read_csd(FAR struct mmcsd_state_s *priv) return -EPERM; } + memset

[GitHub] [incubator-nuttx-apps] hartmannathan commented on pull request #1380: README.md: remove inaccessible links

2022-10-23 Thread GitBox
hartmannathan commented on PR #1380: URL: https://github.com/apache/incubator-nuttx-apps/pull/1380#issuecomment-1288098689 Note that the NuttX Porting Guide is currently in the CWIKI: https://cwiki.apache.org/confluence/display/NUTTX/Porting+Guide It would perhaps be better to update

[incubator-nuttx-apps] branch master updated (2962af6fe -> 9ba5c86bc)

2022-10-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 2962af6fe Fix fatal error: array: No such file or directory add 9ba5c86bc README.md: remove inac

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1380: README.md: remove inaccessible links

2022-10-23 Thread GitBox
xiaoxiang781216 merged PR #1380: URL: https://github.com/apache/incubator-nuttx-apps/pull/1380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1380: README.md: remove inaccessible links

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #1380: URL: https://github.com/apache/incubator-nuttx-apps/pull/1380#issuecomment-1288094660 Let's ignore the build error introduced by new version of toolchain for this simple change. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1381: Minor fixes

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381#issuecomment-1288094503 The build error is fixed here: https://github.com/apache/incubator-nuttx/pull/7398 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]

2022-10-23 Thread GitBox
xiaoxiang781216 opened a new pull request, #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398 ## Summary since new version gcc toolchain make more check. ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002684613 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7396: Style fixes

2022-10-23 Thread GitBox
pkarashchenko commented on PR #7396: URL: https://github.com/apache/incubator-nuttx/pull/7396#issuecomment-1288079113 > @pkarashchenko please fix the style warning: https://github.com/apache/incubator-nuttx/actions/runs/3304682303/jobs/5454270761 done -- This is an automated messag

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1381: Minor fixes

2022-10-23 Thread GitBox
pkarashchenko commented on PR #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381#issuecomment-1288077505 @xiaoxiang781216 here is the correct PR. In previously I accidentally removed `MIN` and `MAX` from `libhttpd.h` instead of `libhttpd.c`. Let's wait CI to pass -- Th

[GitHub] [incubator-nuttx-apps] pkarashchenko opened a new pull request, #1381: Minor fixes

2022-10-23 Thread GitBox
pkarashchenko opened a new pull request, #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381 ## Summary Multiple minor fixes ## Impact Fix possible memory overflow ## Testing Pass CI -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288059705 @tito97sp please remove the empty patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288059592 Do the following: ``` git remote add apache g...@github.com:apache/incubator-nuttx.git git fetch apache git rebase apahce/master git push -f origin ``` -

[GitHub] [incubator-nuttx] tito97sp commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
tito97sp commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288057639 > > > > @tito97sp could you rebase your patch which may fix the download problem. > > > > > > Hi @xiaoxiang781216 I have deleted the patch branch that w

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation

2022-10-23 Thread GitBox
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288055788 > > @tito97sp could you rebase your patch which may fix the download problem. > > Hi @xiaoxiang781216 I have deleted the patch branch that was causing problems. Coul

  1   2   >