easonxiang opened a new pull request, #6995:
URL: https://github.com/apache/incubator-nuttx/pull/6995
The return value of function mm_takesemaphore will never below
than zero, DEBUGVERIFY make no effect to check it, use DEBUGASSERT
instead.
Signed-off-by: xiangdong6
## Su
easonxiang opened a new pull request, #6994:
URL: https://github.com/apache/incubator-nuttx/pull/6994
Function builtin_for_index may return NULL.
We must check this to prevent visit invalid address.
Signed-off-by: xiangdong6
## Summary
## Impact
None
## Test
xiaoxiang781216 commented on code in PR #6966:
URL: https://github.com/apache/incubator-nuttx/pull/6966#discussion_r962101781
##
include/queue.h:
##
@@ -67,6 +67,223 @@
} \
while (0)
+#define sq_addfirst(p, q) \
+ do \
+{ \
+ FAR sq_entry_t *tmp_node = p; \
+
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new dcb6b30 Publishing web
vbenso commented on code in PR #5987:
URL: https://github.com/apache/incubator-nuttx/pull/5987#discussion_r962044521
##
arch/xtensa/src/esp32/hardware/esp32_twai.h:
##
@@ -0,0 +1,856 @@
+/
+ * arch/xtens
vbenso opened a new pull request, #6993:
URL: https://github.com/apache/incubator-nuttx/pull/6993
## Summary
Minor issues to fix ESP32's TWAI.
- Some register values weren't the ESP32's values.
- Fix of the bitrate calculation
- enable_irq wasn't called with the right argument.
vbenso commented on PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#issuecomment-1235883117
Hi Everyone,
Thanks for all the comments, I've learned so much.
All the style issues are already checked with checkpatch.sh.
The function's prototypes have been moved to the
gustavonihei commented on code in PR #5987:
URL: https://github.com/apache/incubator-nuttx/pull/5987#discussion_r961998957
##
arch/xtensa/src/esp32/hardware/esp32_twai.h:
##
@@ -0,0 +1,856 @@
+/
+ * arch
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961997505
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961992802
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961992521
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp3
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961986233
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c:
##
@@ -162,91 +166,91 @@ int esp32_bringup(void)
#ifdef CONFIG_ESP32_AES_ACCELERATOR
ret = esp32_aes
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961985563
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_ws2812.c:
##
@@ -0,0 +1,333 @@
+/
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961982748
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961982748
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961957160
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp3
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961972888
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_ws2812.c:
##
@@ -0,0 +1,333 @@
+/
+ * b
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961968869
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp3
hartmannathan commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961960719
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c:
##
@@ -162,91 +166,91 @@ int esp32_bringup(void)
#ifdef CONFIG_ESP32_AES_ACCELERATOR
ret = es
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961957160
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp3
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961940471
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961940027
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961938900
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp3
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961935421
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp3
vbenso commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961917770
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp3
acassis commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961908760
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp
acassis commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961908760
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/src/esp
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961904201
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961898067
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961894949
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961892484
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961891907
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961887605
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961887060
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961883956
##
include/nuttx/board.h:
##
@@ -837,6 +837,27 @@ void board_init_rngseed(void);
int board_reset_cause(FAR struct boardioc_reset_cause_s *cause);
#endif
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961881313
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_ws2812.c:
##
@@ -0,0 +1,333 @@
+/
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961879513
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961879513
##
arch/xtensa/src/esp32/esp32_rmt.c:
##
@@ -0,0 +1,315 @@
+/
+ * arch/xtensa/sr
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961874394
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c:
##
@@ -162,91 +166,91 @@ int esp32_bringup(void)
#ifdef CONFIG_ESP32_AES_ACCELERATOR
ret = esp
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961873062
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_ws2812.c:
##
@@ -0,0 +1,333 @@
+/
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961872141
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_ws2812.c:
##
@@ -0,0 +1,333 @@
+/
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961872141
##
boards/xtensa/esp32/esp32-devkitc/src/esp32_ws2812.c:
##
@@ -0,0 +1,333 @@
+/
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961871444
##
drivers/leds/Kconfig:
##
@@ -123,6 +123,22 @@ config WS2812_NON_SPI_DRIVER
implementations. Selecting this option builds the new
gustavonihei commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961870245
##
drivers/leds/Kconfig:
##
@@ -123,6 +123,22 @@ config WS2812_NON_SPI_DRIVER
implementations. Selecting this option builds the new
acassis commented on PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#issuecomment-1235724901
@vbenso please fix the issues reported by CI compilation.
Suggestion: since it is RMT specific for WS8212 maybe it is better to rename
esp32_rmt.c to esp32_rmt_ws8212.c or simil
xiaoxiang781216 commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961850389
##
include/nuttx/board.h:
##
@@ -837,6 +837,27 @@ void board_init_rngseed(void);
int board_reset_cause(FAR struct boardioc_reset_cause_s *cause);
#endi
xiaoxiang781216 closed issue #6985: Shift out of bounds on ESP32-C3
URL: https://github.com/apache/incubator-nuttx/issues/6985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from a5b006a891 xtensa: Avoid including handlers when no coprocessor is
available
add c5785ee9d5 risc-v/e
xiaoxiang781216 merged PR #6988:
URL: https://github.com/apache/incubator-nuttx/pull/6988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
vbenso opened a new pull request, #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992
## Summary
This PR adds support for using the ESP32's RMT peripheral in transmission
only mode.
With this PR the ws2812 led driver can use ESP32's RMT peripheral to
transmit data to the L
fjpanag commented on issue #6767:
URL:
https://github.com/apache/incubator-nuttx/issues/6767#issuecomment-1235664116
@nealef Thank you for pointing this out.
This is a fairly trivial fix. Would you like to contribute to NuttX by
submitting a PR?
--
This is an automated message fro
fjpanag opened a new pull request, #6991:
URL: https://github.com/apache/incubator-nuttx/pull/6991
## Summary
Fixes `pow()` when negative numbers are used as a base.
See #6941 for more information.
## Impact
Correct calculations in `pow()` for all inputs.
##
fjpanag commented on issue #6941:
URL:
https://github.com/apache/incubator-nuttx/issues/6941#issuecomment-1235656927
So my fix is indeed correct algorithmically, but the library itself is not
very accurate. This is what makes the tests fail.
For example, `2^3` yields `8.0
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a5b006a891 xtensa: Avoid including h
xiaoxiang781216 merged PR #6990:
URL: https://github.com/apache/incubator-nuttx/pull/6990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
gustavonihei opened a new pull request, #6990:
URL: https://github.com/apache/incubator-nuttx/pull/6990
## Summary
This PR intends to fix the build for **ESP32-S2** chip. `xtensa_coproc.S` is
being included even when no coprocessors are available, resulting in some
missing definition
michallenc opened a new pull request, #6989:
URL: https://github.com/apache/incubator-nuttx/pull/6989
## Summary
This IOCTL (QEIOC_GETINDEX) allows the application to get the actual encoder
position, the index last position and the index count with one IOCTL call if
supported by arch
gustavonihei opened a new pull request, #6988:
URL: https://github.com/apache/incubator-nuttx/pull/6988
## Summary
This PR intends to fix some `shift-out-of-bounds` warnings reported by UBSAN.
## Impact
In all reported cases the value resulting from the implicit conversion is
ju
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 27fbca771f stm32h7\stm32_fdcan_sock: fix the FDCAN_LOOPBACK config
macros
new 32a21a1b67 UBSan: Allo
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 32a21a1b6762081e2f925bc63b9daf61f5c8b15a
Author: Huang Qi
AuthorDate: Fri Sep 2 04:42:45 2022 +
UBS
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 274c085c4a7df725da1c4ec965648ea2782032f3
Author: Huang Qi
AuthorDate: Fri Sep 2 04:46:02 2022 +
UBS
xiaoxiang781216 merged PR #6986:
URL: https://github.com/apache/incubator-nuttx/pull/6986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1235315678
During the failed assertion, two threads operate on the same `conn`
structure.
One is receiving data while the other tries to free the connection. Hence
the failed assertio
fjpanag commented on PR #6956:
URL: https://github.com/apache/incubator-nuttx/pull/6956#issuecomment-1235308463
> > Repeating the experiment multiple times I got a failed assertion @
`tcp/tcp_conn.c`, line 770.
>
> @fjpanag ,
>
> Thanks a lot for your detailed analysis! From th
davids5 commented on code in PR #6987:
URL: https://github.com/apache/incubator-nuttx/pull/6987#discussion_r961494565
##
sched/Kconfig:
##
@@ -1826,3 +1826,10 @@ config SCHED_BACKTRACE
using the information automatically generated by the
compiler
zyfeier opened a new pull request, #6987:
URL: https://github.com/apache/incubator-nuttx/pull/6987
## Summary
Add CONFIG_TASK_LIST_OPTIMIZE feature to improve sem and mqueue performance.
1. move waitingforsemaphore list to sem_s;
2. move waitingformqnotempty and waitingformqnot
66 matches
Mail list logo