masayuki2009 opened a new pull request, #6927:
URL: https://github.com/apache/incubator-nuttx/pull/6927
## Summary
- I noticed that error happens in loading nettest elf application.
- This commit fixes this issue by adding SYMTAB to the NSH
as well as adjusting some parameters
xiaoxiang781216 opened a new pull request, #6926:
URL: https://github.com/apache/incubator-nuttx/pull/6926
## Summary
since C89 doesn't support inline keyword:
https://github.com/apache/incubator-nuttx/issues/6896
## Impact
## Testing
--
This is an automated mes
xiaoxiang781216 commented on PR #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#issuecomment-1228075679
@tito97sp will you submit a new PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 423ee67554 Double the MMCSD_IDLE_DEL
xiaoxiang781216 merged PR #6904:
URL: https://github.com/apache/incubator-nuttx/pull/6904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
anchao opened a new pull request, #6925:
URL: https://github.com/apache/incubator-nuttx/pull/6925
## Summary
icmpv6: finetune the RA parsing procedure
icmpv6: update IPv6 NIC parameters unconditionally when ICMPv6 RA is received
icmpv6: add NTOHL when parse ICMPV6 option MTU
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5ed2ee85c9fa1a7654b6d590a1e1cb09732ca3b2
Author: Gustavo Henrique Nihei
AuthorDate: Thu Aug 25 15:36:04 2022
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from ea5ba0113e spresense/configs: Add fmsynth defconfig
new e31e69aa30 xtensa: Fix comparison result for
xiaoxiang781216 merged PR #6924:
URL: https://github.com/apache/incubator-nuttx/pull/6924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit fe2d37aa3395adb24f1d01a23af39a06e089d78a
Author: Gustavo Henrique Nihei
AuthorDate: Thu Aug 25 15:36:53 2022
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2fb8af0c209b3ef0979d2b2a8febaf07af275a7b
Author: Gustavo Henrique Nihei
AuthorDate: Thu Aug 25 17:54:55 2022
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e31e69aa30b5c114bbdc2450e6ccfa681db65b38
Author: Gustavo Henrique Nihei
AuthorDate: Thu Aug 25 15:33:42 2022
anchao commented on code in PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#discussion_r955589398
##
net/tcp/tcp_close.c:
##
@@ -306,13 +303,13 @@ static inline int tcp_close_disconnect(FAR struct socket
*psock)
if ((conn->tcpstateflags == TCP_ESTABLISHE
robertlipe commented on issue #6896:
URL:
https://github.com/apache/incubator-nuttx/issues/6896#issuecomment-1227971503
I raised this issue a while back. The argument that even // comments were
evil rang hollow as git history showed they've been there for years, unnoticed.
While I'm sure t
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new ea5ba0113e spresense/configs: Add fms
masayuki2009 merged PR #6863:
URL: https://github.com/apache/incubator-nuttx/pull/6863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
gustavonihei commented on code in PR #6924:
URL: https://github.com/apache/incubator-nuttx/pull/6924#discussion_r955572525
##
arch/xtensa/src/common/xtensa_fpucmp.c:
##
@@ -59,8 +72,23 @@ bool up_fpucmp(const void *saveregs1, const void *saveregs2)
{
const uint32_t *regs1 =
gustavonihei commented on code in PR #6924:
URL: https://github.com/apache/incubator-nuttx/pull/6924#discussion_r955572437
##
arch/xtensa/src/common/xtensa_fpucmp.c:
##
@@ -30,11 +30,23 @@
#include "xtensa.h"
+#ifdef CONFIG_ARCH_FPU
+
/*
xiaoxiang781216 commented on code in PR #6924:
URL: https://github.com/apache/incubator-nuttx/pull/6924#discussion_r955566236
##
arch/xtensa/src/common/xtensa_fpucmp.c:
##
@@ -59,8 +72,23 @@ bool up_fpucmp(const void *saveregs1, const void *saveregs2)
{
const uint32_t *regs1
gustavonihei commented on PR #6924:
URL: https://github.com/apache/incubator-nuttx/pull/6924#issuecomment-1227912988
@no1wudi Please, take a look these patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
gustavonihei opened a new pull request, #6924:
URL: https://github.com/apache/incubator-nuttx/pull/6924
## Summary
This PR intends to fix the allocation of FPU (and other coprocessors)
registers in exception context.
## Impact
Fix `FPU Test` in `ostest` for Xtensa chips.
takayoshi-k commented on PR #6863:
URL: https://github.com/apache/incubator-nuttx/pull/6863#issuecomment-1227880736
@masayuki2009
I rebased to newest master, and force pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 3cd380b Publishing web
fjpanag commented on PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#issuecomment-1227646430
I am testing this PR, and everything seems to be working correctly.
I did test the snippet that was known to crash the system, and now it seems
stable:
```c
sched
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 71ace555f2 risc-v/mpfs: ihc: fix per
xiaoxiang781216 merged PR #6922:
URL: https://github.com/apache/incubator-nuttx/pull/6922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
pkarashchenko commented on code in PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#discussion_r955237350
##
net/tcp/tcp_close.c:
##
@@ -306,13 +303,13 @@ static inline int tcp_close_disconnect(FAR struct socket
*psock)
if ((conn->tcpstateflags == TCP_EST
PetervdPerk-NXP commented on PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#issuecomment-1227436699
The worst offender was the `struct work_s`.
As you're showing the callback doesn't consume that much memory.
LGTM.
--
This is an automated message from the Apac
anchao commented on code in PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#discussion_r955087144
##
net/udp/udp_recvfrom.c:
##
@@ -411,7 +411,6 @@ static void udp_terminate(FAR struct udp_recvfrom_s
*pstate, int result)
*
* Input Parameters:
* dev
xiaoxiang781216 commented on code in PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#discussion_r955057532
##
net/tcp/tcp_connect.c:
##
@@ -149,7 +148,6 @@ static void psock_teardown_callbacks(FAR struct
tcp_connect_s *pstate,
*
* Input Parameters:
*
anchao commented on PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#issuecomment-1227333175
@PetervdPerk-NXP
https://github.com/apache/incubator-nuttx/pull/6740
Could you please review this PR? since the using pvconn from devif callback
will have some risk i
anchao opened a new pull request, #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923
## Summary
net: cleanup pvconn reference to avoid confuse
net: remove pvconn reference from all devif callback
Do not use 'pvconn' argument to get the connection pointer since
fjpanag commented on PR #6918:
URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1227298748
@xiaoxiang781216 no, I only use the STM32F4 and LPC1769 Ethernet interfaces.
But for the moment I can only test on an STM32F4 board.
--
This is an automated message from t
XinStellaris commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r954958805
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2654 @@
+/
+ * drivers/mtd/mtd_con
XinStellaris commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r954958544
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2654 @@
+/
+ * drivers/mtd/mtd_con
eenurkka commented on code in PR #6922:
URL: https://github.com/apache/incubator-nuttx/pull/6922#discussion_r954941839
##
arch/risc-v/src/mpfs/mpfs_ihc.c:
##
@@ -786,20 +786,19 @@ static int mpfs_ihc_tx_message(ihc_channel_t channel,
uint32_t *message)
uint32_t rhartid
XinStellaris commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r954938279
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2654 @@
+/
+ * drivers/mtd/mtd_con
pkarashchenko commented on code in PR #6922:
URL: https://github.com/apache/incubator-nuttx/pull/6922#discussion_r954913940
##
arch/risc-v/src/mpfs/mpfs_ihc.c:
##
@@ -786,20 +786,19 @@ static int mpfs_ihc_tx_message(ihc_channel_t channel,
uint32_t *message)
uint32_t rhartid
eenurkka opened a new pull request, #6922:
URL: https://github.com/apache/incubator-nuttx/pull/6922
nxsig_usleep() will wait for the next timer tick which is way
too much here. It's not sleeping 100 us, but rather, near 1/60 s.
This causes severe performance problems. Fix this by po
XinStellaris commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r954911528
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2654 @@
+/
+ * drivers/mtd/mtd_con
pkarashchenko closed pull request #6921: Revert "Added lock in ifr ioctl calls."
URL: https://github.com/apache/incubator-nuttx/pull/6921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xiaoxiang781216 commented on PR #6912:
URL: https://github.com/apache/incubator-nuttx/pull/6912#issuecomment-1227184434
@hartmannathan let's confirm how Linux handle this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
xiaoxiang781216 commented on PR #6918:
URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1227182317
> @xiaoxiang781216 should we revert for now? Sorry, I saw approve from you
and misinterpreted the comment
We are identifying the root cause, so let's hold the revert
pkarashchenko opened a new pull request, #6921:
URL: https://github.com/apache/incubator-nuttx/pull/6921
Reverts apache/incubator-nuttx#6918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch revert-6918-net_lock
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
at b4eb73aa29 Revert "Added lock in ifr ioctl calls."
No new revisions were added by this
pkarashchenko commented on PR #6918:
URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1227175017
@xiaoxiang781216 should we revert for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
xiaoxiang781216 commented on PR #6918:
URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1227173853
@pkarashchenko this patch will hit dead lock with bcm43xx driver. @fjpanag I
remember you also use bcm43xx driver? Do you try ifdown wlan0 after connecting
ap?
--
This
pkarashchenko commented on PR #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#issuecomment-1227171514
Yes, I was confused with a message "[tito97sp](https://github.com/tito97sp)
merged commit
[d940d55](https://github.com/apache/incubator-nuttx/commit/d940d55ee4e8eee58f051829
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 130b196876 Refine how to specify
pkarashchenko merged PR #6894:
URL: https://github.com/apache/incubator-nuttx/pull/6894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 9bc47ecdce Added lock in ifr ioc
pkarashchenko merged PR #6918:
URL: https://github.com/apache/incubator-nuttx/pull/6918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
pkarashchenko commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r954877344
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2654 @@
+/
+ * drivers/mtd/mtd_co
pkarashchenko commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r954876230
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2654 @@
+/
+ * drivers/mtd/mtd_co
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 1bf462e1c testing: getprime: Fi
xiaoxiang781216 merged PR #1293:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
masayuki2009 commented on PR #6863:
URL: https://github.com/apache/incubator-nuttx/pull/6863#issuecomment-1227138647
@takayoshi-k
Please rebase this PR to the latest master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 4d86c69a22092e803340f4c22c1a5dee4c592843
Author: Takayoshi Koizumi
AuthorDate: Tue Aug 16 09:03:39 2022
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 40c506f3a0b688fc34eb227ec51b992c0def47e4
Author: Takayoshi Koizumi
AuthorDate: Tue Aug 16 08:48:53 2022
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
from 995aef9d9 net/sockopt: move BINDTODEVICE to socket level
new 40c506f3a audioutils/fmsynth: Add FM
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 80eb94da8a189fde637a26b408112180b7bead77
Author: Takayoshi Koizumi
AuthorDate: Tue Aug 16 08:50:17 2022
masayuki2009 commented on PR #1283:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1283#issuecomment-1227135794
>Few minor comments, but nothing that blocks from merging and can be fixed
in follow-up PR
Let me merge this PR.
--
This is an automated message from the A
masayuki2009 merged PR #1283:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
xiaoxiang781216 commented on code in PR #6920:
URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r954769049
##
crypto/aes.c:
##
@@ -1,842 +1,1085 @@
/
* crypto/aes.c
+ * $OpenBSD: ae
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
from 50177dbae1 arch: common: Fix arm_allocateheap.c for BUILD_KERNEL
add 9cb17841d8 net/sockopt: move BIN
xiaoxiang781216 merged PR #6907:
URL: https://github.com/apache/incubator-nuttx/pull/6907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
takayoshi-k commented on PR #1283:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1283#issuecomment-1227031408
> Few minor comments, but nothing that blocks from merging and can be fixed
in follow-up PR
Thank you.
I will remain them. And will be fix next time.
--
This
fjpanag commented on PR #6918:
URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1227024379
> @zhhyu7 find that this patch introduce a dead lock with our internal test.
@xiaoxiang781216 @zhhyu7 Can you please share the test routine or describe
the dead-lock conditi
xiaoxiang781216 commented on PR #6918:
URL: https://github.com/apache/incubator-nuttx/pull/6918#issuecomment-1227008681
@zhhyu7 find that this patch introduce a dead lock with our internal test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
xiaoxiang781216 commented on PR #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#issuecomment-1226987033
look like the patch become to empty and confuse the github
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pkarashchenko commented on PR #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#issuecomment-1226954852
something really strange with this PR. I see "merge" and the force-push
CC: @xiaoxiang781216 @acassis @btashton
--
This is an automated message from the Apache Git Serv
masayuki2009 opened a new pull request, #1293:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1293
## Summary
- I noticed that getprime sometimes shows a wrong thread number
- This commit fixes this issue
## Impact
- None
## Testing
- Tested wit
pkarashchenko commented on code in PR #6920:
URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r954635239
##
crypto/aes.c:
##
@@ -1,842 +1,1085 @@
/
* crypto/aes.c
+ * $OpenBSD: aes.
pkarashchenko commented on code in PR #1283:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1283#discussion_r954629087
##
examples/fmsynth/mmlplayer_main.c:
##
@@ -0,0 +1,563 @@
+/
+ * apps/ex
pkarashchenko commented on code in PR #1283:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1283#discussion_r954627282
##
examples/fmsynth/mmlplayer_score.h:
##
@@ -0,0 +1,58 @@
+/
+ * apps/ex
anchao commented on code in PR #6907:
URL: https://github.com/apache/incubator-nuttx/pull/6907#discussion_r954607757
##
net/socket/setsockopt.c:
##
@@ -399,6 +400,51 @@ static int psock_socketlevel_option(FAR struct socket
*psock, int option,
}
#endif
+#ifdef CONFIG
76 matches
Mail list logo
