[GitHub] [incubator-nuttx] yangxuan8282 opened a new pull request, #6889: arch/arm/src/stm32f7/Kconfig: add STM32F7_SYSCFG

2022-08-21 Thread GitBox
yangxuan8282 opened a new pull request, #6889: URL: https://github.com/apache/incubator-nuttx/pull/6889 ## Summary According to https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/stm32f7/stm32_otghost.c#L70 the STM32F7_SYSCFG was needed for stm32f7 otgfs, but it was

[GitHub] [incubator-nuttx] yangxuan8282 opened a new pull request, #6888: arch/arm/src/stm32f7/stm32_otg.h: fix stm32_otghost_initialize defini…

2022-08-21 Thread GitBox
yangxuan8282 opened a new pull request, #6888: URL: https://github.com/apache/incubator-nuttx/pull/6888 The `stm32_otghost_initialize` function was defined in `arch/arm/src/stm32f7/stm32_otg.h`, but not used in anywhere. According to `boards/arm/stm32f7/nucleo-144/src/stm32_usb.c`, a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 commented on PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#issuecomment-1221873422 @no1wudi please create a new PR to enable ubsan on sim:kasan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[incubator-nuttx] branch master updated: debug: Introduce portion of UBSan

2022-08-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new a06ec54cd0 debug: Introduce portion

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 merged PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx-apps] 01/02: improve flux linkage identification method

2022-08-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit bd82e8d39f25747d0f80ba2b842d35bf1cd73b53 Author: zouboan AuthorDate: Sat Aug 20 16:07:00 2022 +0800

[incubator-nuttx-apps] branch master updated (511d9d59d -> d1cbbcdb4)

2022-08-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 511d9d59d nshlib: Disable dmesg if RAMLOG_SYSLOG disabled new bd82e8d39 improve flux linkage ide

[incubator-nuttx-apps] 02/02: reset state machine to support identification once more without restart app

2022-08-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit d1cbbcdb41b6743628eba4ce359f8ed93ce82fab Author: zouboan AuthorDate: Sat Aug 20 16:08:33 2022 +0800

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1287: industry/foc foc_ident: improve flux linkage identification method

2022-08-21 Thread GitBox
xiaoxiang781216 merged PR #1287: URL: https://github.com/apache/incubator-nuttx-apps/pull/1287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] branch master updated: nshlib: Disable dmesg if RAMLOG_SYSLOG disabled

2022-08-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 511d9d59d nshlib: Disable dmesg

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1289: nshlib: Disable dmesg if RAMLOG_SYSLOG disabled

2022-08-21 Thread GitBox
xiaoxiang781216 merged PR #1289: URL: https://github.com/apache/incubator-nuttx-apps/pull/1289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6887: sched: fix visual studio compiler error

2022-08-21 Thread GitBox
xiaoxiang781216 commented on code in PR #6887: URL: https://github.com/apache/incubator-nuttx/pull/6887#discussion_r951034509 ## arch/sim/src/Makefile: ## @@ -78,8 +78,12 @@ endif VPATH = sim DEPPATH = $(patsubst %,--dep-path %,$(subst :, ,$(VPATH))) +CFLAGS += -fvisibility=

[GitHub] [incubator-nuttx] XinStellaris commented on pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-08-21 Thread GitBox
XinStellaris commented on PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#issuecomment-1221806810 test cases are here:https://github.com/apache/incubator-nuttx-apps/pull/1288 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1289: nshlib: Disable dmesg if RAMLOG_SYSLOG disabled

2022-08-21 Thread GitBox
xiaoxiang781216 commented on code in PR #1289: URL: https://github.com/apache/incubator-nuttx-apps/pull/1289#discussion_r950987608 ## nshlib/Kconfig: ## @@ -272,8 +272,8 @@ config NSH_DISABLE_DIRNAME config NSH_DISABLE_DMESG bool "Disable dmesg" - default DEFAU

[GitHub] [incubator-nuttx] lupyuen commented on pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-21 Thread GitBox
lupyuen commented on PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#issuecomment-1221761496 Hi @xiaoxiang781216 after I added logging for `dir_open` / `dir_ioctl` / `dir_close`, LoRaWAN worked OK, which is really weird. You're right, `dir_open` / `dir_ioctl` / `dir

[GitHub] [incubator-nuttx] XinStellaris commented on pull request #6829: drivers/mtd:init commit of power-loss resilient cfg

2022-08-21 Thread GitBox
XinStellaris commented on PR #6829: URL: https://github.com/apache/incubator-nuttx/pull/6829#issuecomment-1221732638 I have rebased it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request, #1289: nshlib: Disable dmesg if RAMLOG_SYSLOG disabled

2022-08-21 Thread GitBox
no1wudi opened a new pull request, #1289: URL: https://github.com/apache/incubator-nuttx-apps/pull/1289 ## Summary You can't disable domes if RAMLOG_SYSLOG disabled since `NSH_DISABLE_DMESG` depends on it. ## Impact dmesg only, minor ## Testing Custom build -- This is a

[GitHub] [incubator-nuttx-apps] XinStellaris opened a new pull request, #1288: testing:add MTD Fail-safe config-data tests

2022-08-21 Thread GitBox
XinStellaris opened a new pull request, #1288: URL: https://github.com/apache/incubator-nuttx-apps/pull/1288 Signed-off-by: 田昕 ## Summary testcases for fail-safe MTD config data. Fail-safe here means the new config data system is resilient to power loss. ## Impact Only

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 commented on PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#issuecomment-1221722384 > > Let's change _asan_xxx to satisfy the compiler expectation. > > OK, let's do this in next commit ? Yes, but please append to this PR. -- This is an auto

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 commented on code in PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#discussion_r950956689 ## mm/ubsan/Make.defs: ## @@ -0,0 +1,28 @@ + +# mm/kasan/Make.defs Review Co

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6883: arch/sim: set CMDLINE env to the argument user pass to nuttx

2022-08-21 Thread GitBox
xiaoxiang781216 commented on code in PR #6883: URL: https://github.com/apache/incubator-nuttx/pull/6883#discussion_r950954845 ## arch/sim/src/sim/up_initialize.c: ## @@ -31,12 +31,30 @@ #include #include +#include + #include "up_internal.h" /**

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6887: sched: fix visual studio compiler error

2022-08-21 Thread GitBox
anchao commented on code in PR #6887: URL: https://github.com/apache/incubator-nuttx/pull/6887#discussion_r950943135 ## arch/sim/src/sim/up_head.c: ## @@ -105,7 +105,7 @@ static void allsyms_relocate(void) * ***

[GitHub] [incubator-nuttx] no1wudi commented on pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
no1wudi commented on PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#issuecomment-1221685281 > Let's change _asan_xxx to satisfy the compiler expectation. OK, let's do this in next commit ? -- This is an automated message from the Apache Git Service. To respond to

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 49c50d3bf4c987697e6e95886332cd0cb4a17e39

2022-08-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ecbd580 Publishing web

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6883: arch/sim: set CMDLINE env to the argument user pass to nuttx

2022-08-21 Thread GitBox
acassis commented on code in PR #6883: URL: https://github.com/apache/incubator-nuttx/pull/6883#discussion_r950903358 ## arch/sim/src/sim/up_initialize.c: ## @@ -31,12 +31,30 @@ #include #include +#include + #include "up_internal.h" /**

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 commented on PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#issuecomment-1221582553 @no1wudi look like UBSan will influence KASan function prototype: ``` Error: kasan/kasan.c:225:6: error: conflicting types for built-in function '__asan_report_load_n

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 commented on code in PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#discussion_r950869035 ## mm/ubsan/ubsan.c: ## @@ -0,0 +1,376 @@ +/ + * mm/ubsan/ubsan.c + * + * Lic

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6803: fs/directory: Using file api to implement operations on directories

2022-08-21 Thread GitBox
xiaoxiang781216 commented on PR #6803: URL: https://github.com/apache/incubator-nuttx/pull/6803#issuecomment-1221560366 @lupyuen it's strange that dir_open/dir_ioctl can generate this side effect since: 1. dir_allocate is already used in open(O_DIRECTORY) 2. dir_open/dir_ioctl is

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 commented on code in PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#discussion_r950854991 ## mm/ubsan/ubsan.c: ## @@ -0,0 +1,387 @@ +/ + * mm/ubsan/ubsan.c + * + * Lic

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6881: debug: Introduce portion of UBSan

2022-08-21 Thread GitBox
xiaoxiang781216 commented on PR #6881: URL: https://github.com/apache/incubator-nuttx/pull/6881#issuecomment-1221559186 let's add a option to enable -fsanitize-undefined-trap-on-error which could save the space significantly: ``` size ubsan-basic-noubsan ubsan-basic ubsan-basic-trap-on

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6887: sched: fix visual studio compiler error

2022-08-21 Thread GitBox
xiaoxiang781216 commented on code in PR #6887: URL: https://github.com/apache/incubator-nuttx/pull/6887#discussion_r950830025 ## arch/sim/src/sim/up_head.c: ## @@ -105,7 +105,7 @@ static void allsyms_relocate(void) * **

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6887: sched: fix visual studio compiler error

2022-08-21 Thread GitBox
anchao opened a new pull request, #6887: URL: https://github.com/apache/incubator-nuttx/pull/6887 ## Summary sched: fix visual studio compiler error GCC __attribute__ is not fully compatible with MSVC, In the MSVC environment the programmer typically explicitly exports functi