eaglelaw commented on PR #6795:
URL: https://github.com/apache/incubator-nuttx/pull/6795#issuecomment-1207134228
@xiaoxiang781216 this PR is for remove unused dependent lib, please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
eaglelaw opened a new pull request, #6795:
URL: https://github.com/apache/incubator-nuttx/pull/6795
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
masayuki2009 commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r939440389
##
netutils/telnetd/telnetd_daemon.c:
##
@@ -369,6 +389,7 @@ static int telnetd_daemon(int argc, FAR char *argv[])
*
*
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new c5a94d7 Publishing web
mlyszczek commented on PR #6781:
URL: https://github.com/apache/incubator-nuttx/pull/6781#issuecomment-1207082144
> @mlyszczek your original Kconfig wasn't too big to motivate split it.
Almost all Kconfig inside arch/ is way bigget than these.
@acassis Yes, that is true, for now that
masayuki2009 commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r939440389
##
netutils/telnetd/telnetd_daemon.c:
##
@@ -369,6 +389,7 @@ static int telnetd_daemon(int argc, FAR char *argv[])
*
*
mlyszczek commented on code in PR #6781:
URL: https://github.com/apache/incubator-nuttx/pull/6781#discussion_r939438853
##
arch/arm/src/stm32wl5/kconfig.d/configuration.kconfig:
##
@@ -0,0 +1,4 @@
+source "arch/arm/src/stm32wl5/kconfig.d/configuration/serial.kconfig"
Review Com
mlyszczek commented on code in PR #6781:
URL: https://github.com/apache/incubator-nuttx/pull/6781#discussion_r939438153
##
boards/arm/stm32wl5/nucleo-wl55jc/Kconfig:
##
@@ -24,547 +24,8 @@ config ARCH_BOARD_ENABLE_CPU2
When enabled, CPU2 (cortex-m0) will be start
masayuki2009 commented on PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1206961444
Hmm, I need to fix the following error
```
Configuration/Tool: arty_a7/
masayuki2009 commented on PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1206957311
>Hmm, I'm not sure why the following errors happen.
It seems that restarting the CI fixed the issue.
So, the issue might be a parallel build issue.
--
Th
masayuki2009 commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r939312351
##
include/nshlib/nshlib.h:
##
@@ -126,6 +126,27 @@ void nsh_initialize(void);
int nsh_consolemain(int argc, FAR char *argv[]);
+/***
masayuki2009 commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r939307862
##
include/netutils/telnetd.h:
##
@@ -77,6 +91,23 @@ extern "C"
#define EXTERN extern
#endif
+/***
masayuki2009 commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r939307862
##
include/netutils/telnetd.h:
##
@@ -77,6 +91,23 @@ extern "C"
#define EXTERN extern
#endif
+/***
acassis commented on PR #6781:
URL: https://github.com/apache/incubator-nuttx/pull/6781#issuecomment-1206924383
@mlyszczek you original Kconfig wasn't too big to motivate split it. Almost
all Kconfig inside arch/ is way bigget than these.
--
This is an automated message from the Apache Gi
PetervdPerk commented on code in PR #6788:
URL: https://github.com/apache/incubator-nuttx/pull/6788#discussion_r939049907
##
arch/arm/src/lpc17xx_40xx/lpc17_40_pwm.c:
##
@@ -279,19 +327,135 @@ static int pwm_timer(struct lpc17_40_pwmtimer_s *priv,
const str
davids5 commented on PR #6794:
URL: https://github.com/apache/incubator-nuttx/pull/6794#issuecomment-1206706104
@pkarashchenko - I tried to catch all the format changes that you suggested
on the last PRs that nxstyle did not catch, but I might have missed some.
--
This is an automated me
davids5 opened a new pull request, #6794:
URL: https://github.com/apache/incubator-nuttx/pull/6794
## Summary
Adds Add DMA on LPSPI, LPUART, LPI2C
## Impact
Should be none
## Testing
PX4 nxp_fmurt1062-v1
--
This is an automated message from the Apach
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 9be737c89f sim/adb: Enable ping
pkarashchenko merged PR #6792:
URL: https://github.com/apache/incubator-nuttx/pull/6792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
xiaoxiang781216 commented on code in PR #6781:
URL: https://github.com/apache/incubator-nuttx/pull/6781#discussion_r939028157
##
arch/arm/src/stm32wl5/kconfig.d/configuration.kconfig:
##
@@ -0,0 +1,4 @@
+source "arch/arm/src/stm32wl5/kconfig.d/configuration/serial.kconfig"
Revi
xiaoxiang781216 commented on code in PR #6781:
URL: https://github.com/apache/incubator-nuttx/pull/6781#discussion_r939027660
##
boards/arm/stm32wl5/nucleo-wl55jc/Kconfig:
##
@@ -24,547 +24,8 @@ config ARCH_BOARD_ENABLE_CPU2
When enabled, CPU2 (cortex-m0) will be
davids5 commented on code in PR #6787:
URL: https://github.com/apache/incubator-nuttx/pull/6787#discussion_r938958338
##
arch/arm/src/imxrt/imxrt_enet.c:
##
@@ -125,6 +125,12 @@
# error Write back D-Cache not yet supported
#endif
+/* TX poll delay = 1 seconds. CLK_TCK is th
xiaoxiang781216 commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r938939669
##
include/nshlib/nshlib.h:
##
@@ -126,6 +126,27 @@ void nsh_initialize(void);
int nsh_consolemain(int argc, FAR char *argv[]);
+/
tmedicci opened a new pull request, #6793:
URL: https://github.com/apache/incubator-nuttx/pull/6793
## Summary
Added support for the Lily Go TTGO T-Display ESP32 V1.1 board which contains
a TFT Display (st7789).
## Impact
Added support for the Lily Go TTGO T-Display ESP32 V1.1 b
masayuki2009 commented on PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#issuecomment-1206531563
Hmm, I'm not sure why the following errors happen.
```
Configuration/To
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new b3cd9090d1 drivers/net: make sure th
xiaoxiang781216 merged PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 commented on code in PR #6787:
URL: https://github.com/apache/incubator-nuttx/pull/6787#discussion_r938868074
##
arch/arm/src/imxrt/imxrt_enet.c:
##
@@ -125,6 +125,12 @@
# error Write back D-Cache not yet supported
#endif
+/* TX poll delay = 1 seconds. CLK_T
davids5 commented on PR #6787:
URL: https://github.com/apache/incubator-nuttx/pull/6787#issuecomment-1206506468
> CI still complains on
>
> ```
> Error: chip/imxrt_enet.c:120:37: error: 'GPR_GPR1_ENET1_TX_DIR_OUT'
undeclared (first use in this function); did you mean 'GPR_GPR1_ENET
pkarashchenko commented on PR #6787:
URL: https://github.com/apache/incubator-nuttx/pull/6787#issuecomment-1206503208
CI still complains on
```
Error: chip/imxrt_enet.c:120:37: error: 'GPR_GPR1_ENET1_TX_DIR_OUT'
undeclared (first use in this function); did you mean 'GPR_GPR1_ENET_TX_DI
Donny9 commented on code in PR #6783:
URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r938835344
##
libs/libc/time/lib_localtime.c:
##
@@ -307,14 +307,15 @@ struct rule_s
/* The minimum and maximum finite time values. */
-static const time_t g_min_timet
davids5 commented on code in PR #6787:
URL: https://github.com/apache/incubator-nuttx/pull/6787#discussion_r938751569
##
arch/arm/src/imxrt/imxrt_enet.c:
##
@@ -125,6 +125,12 @@
# error Write back D-Cache not yet supported
#endif
+/* TX poll delay = 1 seconds. CLK_TCK is th
masayuki2009 commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r938727307
##
include/nshlib/nshlib.h:
##
@@ -126,6 +126,27 @@ void nsh_initialize(void);
int nsh_consolemain(int argc, FAR char *argv[]);
+/***
pkarashchenko commented on code in PR #6781:
URL: https://github.com/apache/incubator-nuttx/pull/6781#discussion_r938715331
##
arch/arm/src/stm32wl5/stm32wl5_ipcc.c:
##
@@ -381,11 +390,13 @@ static ssize_t stm32wl5_ipcc_write(struct ipcc_lower_s
*ipcc,
static int stm32wl5_ipcc
pkarashchenko commented on code in PR #6783:
URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r938714137
##
libs/libc/time/lib_localtime.c:
##
@@ -307,14 +307,15 @@ struct rule_s
/* The minimum and maximum finite time values. */
-static const time_t g_mi
pkarashchenko commented on code in PR #1254:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1254#discussion_r938707914
##
include/nshlib/nshlib.h:
##
@@ -126,6 +126,27 @@ void nsh_initialize(void);
int nsh_consolemain(int argc, FAR char *argv[]);
+/**
pkarashchenko commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206326557
> > > > > @pkarashchenko Why the name change from ETH_HDR to BUF?
> > > >
> > > >
> > > > Just to unify across the available variants. I can get back that
macro
masayuki2009 opened a new pull request, #1254:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1254
## Summary
- This PR contains the following commits
- commit1: netutils: Make telnetd_daemon() in public
- This commit makes telnetd_daemon() in public so that we
davids5 commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206289622
> > > > @pkarashchenko Why the name change from ETH_HDR to BUF?
> > >
> > >
> > > Just to unify across the available variants. I can get back that macro
> >
> >
pkarashchenko commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206287148
> > > @pkarashchenko Why the name change from ETH_HDR to BUF?
> >
> > Just to unify across the available variants. I can get back that macro
>
> For me it adds c
davids5 commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206285930
> > @pkarashchenko Why the name change from ETH_HDR to BUF?
>
> Just to unify across the available variants. I can get back that macro
For me it adds context at the po
pkarashchenko commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206284265
> @pkarashchenko Why the name change from ETH_HDR to BUF?
Just to unify across the available variants. I can get back that macro
--
This is an automated message fro
davids5 commented on PR #6789:
URL: https://github.com/apache/incubator-nuttx/pull/6789#issuecomment-1206277578
@pkarashchenko Why the name change from ETH_HDR to BUF?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
davids5 commented on PR #6787:
URL: https://github.com/apache/incubator-nuttx/pull/6787#issuecomment-1206271555
@pkarashchenko @xiaoxiang781216 - Thank you for the review. I will
incorporate all the changes and fix CI - then force push.
--
This is an automated message from the Apache Git
xiaoxiang781216 opened a new pull request, #6792:
URL: https://github.com/apache/incubator-nuttx/pull/6792
## Summary
## Impact
ping with ip address can work
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Donny9 commented on code in PR #6783:
URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r938511912
##
libs/libc/time/lib_localtime.c:
##
@@ -307,14 +307,15 @@ struct rule_s
/* The minimum and maximum finite time values. */
-static const time_t g_min_timet
pkarashchenko commented on PR #6787:
URL: https://github.com/apache/incubator-nuttx/pull/6787#issuecomment-1206117525
`Error: chip/imxrt_clockconfig.c:276:12: error: 'CCM_ANALOG_PLL_ENET_ENABLE'
undeclared (first use in this function); did you mean
'CCM_ANALOG_PLL_USB2_ENABLE'?`
--
This
pkarashchenko commented on code in PR #6780:
URL: https://github.com/apache/incubator-nuttx/pull/6780#discussion_r938505225
##
mm/iob/Kconfig:
##
@@ -32,6 +32,18 @@ config IOB_BUFSIZE
chain. This setting determines the data payload each
preallocated
48 matches
Mail list logo
