xiaoxiang781216 commented on PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#issuecomment-1179484688
@masayuki2009 how about we invoke "make distclean) in all subfolder like
https://github.com/apache/incubator-nuttx-apps/pull/1217?
--
This is an automated message
adamkaliszan commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r917225088
##
drivers/lcd/ssd1680.c:
##
@@ -1011,21 +1021,35 @@ static void ssd1680_snd_cmd_with_data_bitstrip(
{
for (j = 0; j < 8; j++)
{
+#
qinwei2004 commented on PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#issuecomment-1179483127
@xiaoxiang781216 @hartmannathan @pkarashchenko
all review issue was fixed or replied, please check again
--
This is an automated message from the Apache Git Service.
To re
xiaoxiang781216 opened a new pull request, #1217:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1217
Signed-off-by: Xiang Xiao
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
xiaoxiang781216 commented on code in PR #6590:
URL: https://github.com/apache/incubator-nuttx/pull/6590#discussion_r917222088
##
net/icmp/icmp_netpoll.c:
##
@@ -142,17 +142,27 @@ static uint16_t icmp_poll_eventhandler(FAR struct
net_driver_s *dev,
int icmp_pollsetup(FAR stru
qinwei2004 commented on PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#issuecomment-1179476789
> FYI when applying patch:
>
> ```
> $ wget https://github.com/apache/incubator-nuttx/pull/6478.patch
> $ git checkout master
> $ git apply 6478.patch
> 6478.
qinwei2004 commented on code in PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r917212831
##
arch/arm64/src/common/arm64_initialstate.c:
##
@@ -0,0 +1,154 @@
+/
+ * arch/ar
normanr commented on PR #904:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/904#issuecomment-1179452650
> * sometimes it sees a double-offer, it it will decline it even if it's
just a duplicate of the offer that it's just received.
I noticed that this is _not_ how [RFC
21
This is an automated email from the ASF dual-hosted git repository.
masayuki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 9bdeed73e2 net/tcp: fix assertion of
masayuki2009 merged PR #6589:
URL: https://github.com/apache/incubator-nuttx/pull/6589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 33d995c Publishing web
masayuki2009 commented on PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#issuecomment-1179415721
@xiaoxiang781216
Please review this PR again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
anchao commented on code in PR #6589:
URL: https://github.com/apache/incubator-nuttx/pull/6589#discussion_r917162878
##
net/tcp/tcp_conn.c:
##
@@ -656,11 +656,13 @@ FAR struct tcp_conn_s *tcp_alloc(uint8_t domain)
* in the socket layer.
Review Comment:
Yes, REVIS
pkarashchenko commented on code in PR #6589:
URL: https://github.com/apache/incubator-nuttx/pull/6589#discussion_r917151834
##
net/tcp/tcp_conn.c:
##
@@ -656,11 +656,13 @@ FAR struct tcp_conn_s *tcp_alloc(uint8_t domain)
* in the socket layer.
Review Comment:
sin
onegray commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r917146001
##
drivers/lcd/ssd1680.c:
##
@@ -1011,21 +1021,35 @@ static void ssd1680_snd_cmd_with_data_bitstrip(
{
for (j = 0; j < 8; j++)
{
+#if de
anchao opened a new pull request, #6590:
URL: https://github.com/apache/incubator-nuttx/pull/6590
## Summary
net/poll: fix race condition if connect free before poll teardown
Net poll teardown is not protected by net lock, if the conn is released
before teardown, the
anchao commented on PR #6589:
URL: https://github.com/apache/incubator-nuttx/pull/6589#issuecomment-1179312591
@pkarashchenko @yamt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
anchao commented on PR #6587:
URL: https://github.com/apache/incubator-nuttx/pull/6587#issuecomment-1179312367
> Yes, this is a regression issue, I want to resolve a assertion failure by
fall back connect allocation, please merge this PR, I will upload the new PR
asap
Please review t
anchao opened a new pull request, #6589:
URL: https://github.com/apache/incubator-nuttx/pull/6589
## Summary
net/tcp: fix assertion of fallback connection alloc
When the free connection list is unenough to alloc a new instance,
the TCP stack will reuse the currently close
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new cd3e93ef17 esp32s3-devkit: Add suppo
xiaoxiang781216 merged PR #6585:
URL: https://github.com/apache/incubator-nuttx/pull/6585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
adamkaliszan commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r916973204
##
drivers/lcd/ssd1680.c:
##
@@ -735,7 +733,17 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s
*priv)
static int ssd1680_update_all_and_redraw
xiaoxiang781216 commented on code in PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#discussion_r916902257
##
Directory.mk:
##
@@ -26,6 +26,7 @@ SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile))
CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELI
masayuki2009 commented on code in PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#discussion_r916839273
##
Directory.mk:
##
@@ -26,6 +26,7 @@ SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile))
CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELIM)K
masayuki2009 commented on code in PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#discussion_r916839273
##
Directory.mk:
##
@@ -26,6 +26,7 @@ SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile))
CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELIM)K
onegray commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r916824566
##
drivers/lcd/ssd1680.c:
##
@@ -1104,11 +1125,11 @@ static void
ssd1680_snd_cmd_with_data_even_bits_bitstrip(
}
}
-#if defined(CONFIG_L
onegray commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r916824291
##
drivers/lcd/ssd1680.c:
##
@@ -1087,13 +1108,13 @@ static void
ssd1680_snd_cmd_with_data_even_bits_bitstrip(
val = 0;
for (j = 0; j < 8;
onegray commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r916822588
##
drivers/lcd/ssd1680.c:
##
@@ -1036,29 +1060,26 @@ static void ssd1680_snd_cmd_with_data_bitstrip(
}
}
-#if defined(CONFIG_LCD_LANDSCAP
onegray commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r916821925
##
drivers/lcd/ssd1680.c:
##
@@ -1011,21 +1021,35 @@ static void ssd1680_snd_cmd_with_data_bitstrip(
{
for (j = 0; j < 8; j++)
{
+#if de
onegray commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r916819001
##
drivers/lcd/ssd1680.c:
##
@@ -735,7 +733,17 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s
*priv)
static int ssd1680_update_all_and_redraw(stru
xiaoxiang781216 commented on code in PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#discussion_r916813553
##
Directory.mk:
##
@@ -26,6 +26,7 @@ SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile))
CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELI
qinwei2004 commented on code in PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r916802696
##
arch/arm64/src/common/arm64_internal.h:
##
@@ -0,0 +1,387 @@
+/
+ * arch/arm64/
Ouss4 commented on code in PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#discussion_r916801543
##
Directory.mk:
##
@@ -26,6 +26,7 @@ SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile))
CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELIM)Kconfig)
masayuki2009 commented on code in PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#discussion_r916795262
##
Directory.mk:
##
@@ -26,6 +26,7 @@ SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile))
CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELIM)K
Ouss4 commented on code in PR #1216:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1216#discussion_r916790281
##
Directory.mk:
##
@@ -26,6 +26,7 @@ SUBDIRS := $(dir $(wildcard *$(DELIM)Makefile))
CONFIGSUBDIRS := $(filter-out $(dir $(wildcard *$(DELIM)Kconfig)
masayuki2009 commented on PR #6586:
URL: https://github.com/apache/incubator-nuttx/pull/6586#issuecomment-1178953728
@xiaoxiang781216
I've just sent https://github.com/apache/incubator-nuttx-apps/pull/1216
--
This is an automated message from the Apache Git Service.
To respond to
masayuki2009 opened a new pull request, #1216:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1216
## Summary
- I noticed that some files (e.g. xxx.tar.gz) which are downloaded
by 'make context' are not deleted when we build the kernel only
then we do 'make distclea
qinwei2004 commented on code in PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r916777030
##
arch/arm64/src/common/arm64_internal.h:
##
@@ -0,0 +1,387 @@
+/
+ * arch/arm64/
qinwei2004 commented on code in PR #6478:
URL: https://github.com/apache/incubator-nuttx/pull/6478#discussion_r916775163
##
arch/arm64/src/common/arm64_internal.h:
##
@@ -0,0 +1,387 @@
+/
+ * arch/arm64/
adamkaliszan opened a new pull request, #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588
Displays with resolution that is not multiplication of 8 has some issues in
landscape mode
## Summary
Fixed LANDSCAPE mode.
Some performance improvement in landscape mode.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 19eb4d7d77 Revert "net/tcp: discard
xiaoxiang781216 merged PR #6587:
URL: https://github.com/apache/incubator-nuttx/pull/6587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 commented on PR #6586:
URL: https://github.com/apache/incubator-nuttx/pull/6586#issuecomment-1178669384
> .github/workflows/build.yml
Yes, because I want CI verify that "make distclean" can remove all temporary
files.
--
This is an automated message from the Apache
anchao commented on PR #6587:
URL: https://github.com/apache/incubator-nuttx/pull/6587#issuecomment-1178657827
Yes, this is a regression issue, I want to resolve a assertion failure by
fall back connect allocation, please merge this PR, I will upload the new PR
asap
--
This is an automat
masayuki2009 commented on PR #6586:
URL: https://github.com/apache/incubator-nuttx/pull/6586#issuecomment-1178648324
>How about we fix the problem instead?
@xiaoxiang781216
I noticed that cibuild.sh -G works but you removed the option in
.github/workflows/build.yml
--
This
45 matches
Mail list logo
