xiaoxiang781216 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825389413
##
File path: arch/xtensa/src/common/xtensa_asm_utils.h
##
@@ -0,0 +1,76 @@
+/
xiaoxiang781216 opened a new pull request #5730:
URL: https://github.com/apache/incubator-nuttx/pull/5730
## Summary
Style change only.
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
xiaoxiang781216 commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825384473
##
File path: arch/arm/src/armv7-m/mpu.h
##
@@ -33,8 +33,6 @@
# include
# include
# include
-
-# include "arm_arch.h"
Review co
xiaoxiang781216 commented on pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#issuecomment-1066019262
> looks like `USB_DmaDesc` has to be `g_usbddesc`
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
xiaoxiang781216 commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825384544
##
File path: arch/arm/src/lpc54xx/lpc54_emc.c
##
@@ -388,7 +387,7 @@ void lpc54_emc_sdram_initialize(
putreg32(2 * EMC_REFRESH_CLOCK
xiaoxiang781216 commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825384473
##
File path: arch/arm/src/armv7-m/mpu.h
##
@@ -33,8 +33,6 @@
# include
# include
# include
-
-# include "arm_arch.h"
Review co
xiaoxiang781216 commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825384453
##
File path: arch/arm/src/dm320/dm320_gio.h
##
@@ -27,7 +27,7 @@
#ifndef __ASSEMBLY__
# include
-# include "arm_arch.h"
+# include "
xiaoxiang781216 commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825384301
##
File path: arch/arm/src/common/arm_internal.h
##
@@ -182,6 +182,19 @@
#define INTSTACK_COLOR 0xdeadbeef
#define HEAP_COLOR 'h'
pkarashchenko commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825371300
##
File path: arch/arm/src/lpc54xx/lpc54_emc.c
##
@@ -388,7 +387,7 @@ void lpc54_emc_sdram_initialize(
putreg32(2 * EMC_REFRESH_CLOCK_S
MTres19 commented on pull request #5151:
URL: https://github.com/apache/incubator-nuttx/pull/5151#issuecomment-1065993904
Thanks for the feedback. Not all TM4C devices have dual CAN:
https://www.ti.com/lit/sg/spmt285e/spmt285e.pdf
Should the changes to arch/arm/src/tiva/Kconfig go in
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new dcfa1ef Publishing web
pkarashchenko commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825364025
##
File path: arch/arm/src/armv7-m/mpu.h
##
@@ -33,8 +33,6 @@
# include
# include
# include
-
-# include "arm_arch.h"
Review comm
pkarashchenko commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825362660
##
File path: arch/arm/src/common/arm_internal.h
##
@@ -182,6 +182,19 @@
#define INTSTACK_COLOR 0xdeadbeef
#define HEAP_COLOR 'h'
+#
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825363284
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -768,13 +756,13 @@ _xtensa_level6_handler:
/* Restore only level-
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825363170
##
File path: arch/xtensa/src/common/xtensa_asm_utils.h
##
@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) 2017, Intel Corporation
+ *
+ * SPDX-Licen
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825362684
##
File path: arch/xtensa/src/common/xtensa_asm_utils.h
##
@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) 2017, Intel Corporation
+ *
+ * SPDX-License-Ident
Ouss4 commented on pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#issuecomment-1065981864
This is the inconsistency I was referring to earlier. Fixing these tabs in
the middle of instructions and comments in assembly files in a snippet of code
feels pointless,
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825362043
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -768,13 +756,13 @@ _xtensa_level6_handler:
/* Restore only level-specific
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825361954
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -768,13 +756,13 @@ _xtensa_level6_handler:
/* Restore only level-
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825361463
##
File path: arch/xtensa/src/common/xtensa_user_handler.S
##
@@ -441,8 +427,8 @@ _xtensa_syscall_handler:
l32ia0, a2, (4 * REG_
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825361090
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -348,13 +346,13 @@ _xtensa_level1_handler:
/* Restore only level-
pkarashchenko commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825360034
##
File path: arch/arm/src/armv7-m/mpu.h
##
@@ -33,8 +33,6 @@
# include
# include
# include
-
-# include "arm_arch.h"
Review comm
pkarashchenko commented on a change in pull request #5720:
URL: https://github.com/apache/incubator-nuttx/pull/5720#discussion_r825360034
##
File path: arch/arm/src/armv7-m/mpu.h
##
@@ -33,8 +33,6 @@
# include
# include
# include
-
-# include "arm_arch.h"
Review comm
pkarashchenko merged pull request #5727:
URL: https://github.com/apache/incubator-nuttx/pull/5727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f94093b arch/ceva: Move the idl
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825358463
##
File path: arch/xtensa/src/common/xtensa_asm_utils.h
##
@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) 2017, Intel Corporation
+ *
+ * SPDX-Licen
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825358028
##
File path: arch/xtensa/src/common/xtensa_asm_utils.h
##
@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) 2017, Intel Corporation
+ *
+ * SPDX-License-Ident
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825357096
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -324,9 +252,9 @@ xtensa_context_save:
*
* NOTE: MUST BE CALLED ONLY BY 'CA
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825356946
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -353,7 +352,7 @@ _xtensa_level1_handler:
l32ia0, a2, (4 * REG_P
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825356789
##
File path: arch/xtensa/src/common/xtensa_asm_utils.h
##
@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) 2017, Intel Corporation
+ *
+ * SPDX-Licen
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825351318
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -80,32 +81,28 @@
*
* Description:
*
- * NOTE: MUST BE CALLED ONLY BY 'CALL0' INS
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825349105
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -80,32 +81,28 @@
*
* Description:
*
- * NOTE: MUST BE CALLED ONLY BY 'CA
Ouss4 commented on pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#issuecomment-1065960386
Github actually makes it look even worst, I see a line that extends too
long. I will drop the last commit all together and address individual spaces I
introduced.
--
Ouss4 commented on pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#issuecomment-1065960123
> I see that many many .S files use TABs and I'm fine with that. But spaces
are used in comments.
There are also many assembly files that are not consistent in the
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825348518
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -3,12 +3,12 @@
*
* Adapted from use in NuttX by:
*
- * Copyright (C) 2016 Gregor
xiaoxiang781216 commented on a change in pull request #5727:
URL: https://github.com/apache/incubator-nuttx/pull/5727#discussion_r825347454
##
File path: arch/ceva/src/common/up_createstack.c
##
@@ -233,6 +233,11 @@ void up_stack_color(FAR void *stackbase, size_t nbytes)
uin
pkarashchenko commented on pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#issuecomment-1065956570
> Regarding spaces and tabs, it's simpler to just use spaces everywhere
(also easy to replace existing tabs). We don't have any rule for what to use
for indentati
xiaoxiang781216 commented on a change in pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728#discussion_r825345749
##
File path: arch/sim/src/sim/up_initialize.c
##
@@ -351,5 +243,7 @@ void up_initialize(void)
audio_register("pcm0c", sim_audio_initia
xiaoxiang781216 commented on a change in pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728#discussion_r825345350
##
File path: arch/mips/src/common/mips_initialize.c
##
@@ -67,10 +52,6 @@
void up_initialize(void)
{
- /* Initialize global variable
Ouss4 commented on pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#issuecomment-1065955839
Regarding spaces and tabs, it's simpler to just use spaces everywhere (also
easy to replace existing tabs). We don't have any rule for what to use for
indentation in ass
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825342214
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -3,12 +3,12 @@
*
* Adapted from use in NuttX by:
*
- * Copyright (C) 201
gustavonihei commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825341976
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -164,16 +161,28 @@ _xtensa_context_save:
#error Overlay support is not implement
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825341700
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -353,7 +352,7 @@ _xtensa_level1_handler:
l32ia0, a2, (4 * REG_PC)
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825341700
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -353,7 +352,7 @@ _xtensa_level1_handler:
l32ia0, a2, (4 * REG_PC)
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825341279
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -164,16 +161,28 @@ _xtensa_context_save:
#error Overlay support is not implemented
#en
Ouss4 commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825341161
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -164,16 +161,28 @@ _xtensa_context_save:
#error Overlay support is not implemented
#en
pkarashchenko commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825340951
##
File path: arch/xtensa/src/common/xtensa_int_handlers.S
##
@@ -353,7 +352,7 @@ _xtensa_level1_handler:
l32ia0, a2, (4 * REG_P
pkarashchenko commented on a change in pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728#discussion_r825340423
##
File path: arch/sim/src/sim/up_initialize.c
##
@@ -351,5 +243,7 @@ void up_initialize(void)
audio_register("pcm0c", sim_audio_initiali
gustavonihei commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825340591
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -164,16 +161,28 @@ _xtensa_context_save:
#error Overlay support is not implement
gustavonihei commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825340332
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -164,16 +161,28 @@ _xtensa_context_save:
#error Overlay support is not implement
gustavonihei commented on a change in pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729#discussion_r825340332
##
File path: arch/xtensa/src/common/xtensa_context.S
##
@@ -164,16 +161,28 @@ _xtensa_context_save:
#error Overlay support is not implement
pkarashchenko commented on a change in pull request #5727:
URL: https://github.com/apache/incubator-nuttx/pull/5727#discussion_r825339785
##
File path: arch/ceva/src/common/up_createstack.c
##
@@ -233,6 +233,11 @@ void up_stack_color(FAR void *stackbase, size_t nbytes)
uint3
Ouss4 opened a new pull request #5729:
URL: https://github.com/apache/incubator-nuttx/pull/5729
## Summary
- `xtensa_context_save` can use A1 directly no need to pass the saving area
in SP. This will free A2 to use as a scratch register.
- A1 register was being restored twice.
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d9a442a859cfe88bc28729a4f609a8bc9ae61f2b
Author: Xiang Xiao
AuthorDate: Sat Mar 12 04:04:08 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit b0786606fc5bec29464fb197b9b2c80fa265d44a
Author: Xiang Xiao
AuthorDate: Sat Mar 12 04:01:19 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4cc28882f9d847b261f77e8846b935acac71a912
Author: Xiang Xiao
AuthorDate: Sat Mar 12 12:07:33 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit cf2538c27707a75b6e9afbb77507cf4c5daee292
Author: Xiang Xiao
AuthorDate: Sat Mar 12 03:58:25 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit dfb9a763a79ea6d60441a23fb88811984449a7f0
Author: Xiang Xiao
AuthorDate: Sat Mar 12 03:56:57 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 8b7d08f net: Reoder the initialize sequence(mac->ip->tcp/udp)
new dfb9a76 fs: Initialize g_inod
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2ce62bb5831122a962c6aa72cebdf45440ff4aca
Author: Xiang Xiao
AuthorDate: Sat Mar 12 04:05:36 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit ab872b01999e7d13ad1aeaa95c7d2ebf7118d95d
Author: Xiang Xiao
AuthorDate: Sat Mar 12 04:10:24 2022 +0800
gustavonihei merged pull request #5721:
URL: https://github.com/apache/incubator-nuttx/pull/5721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
xiaoxiang781216 opened a new pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728
## Summary
## Impact
Minor, code refactor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
gustavonihei commented on a change in pull request #5721:
URL: https://github.com/apache/incubator-nuttx/pull/5721#discussion_r825080609
##
File path: sched/init/nx_start.c
##
@@ -628,15 +628,6 @@ void nx_start(void)
irq_initialize();
}
- /* Initialize the watchd
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 75980705087dd370a53e7bdffd13bf56036d3ac3
Author: Xiang Xiao
AuthorDate: Sat Mar 12 14:13:40 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4d0fcc2526cae74555719fba354da1b3a21acbd3
Author: Xiang Xiao
AuthorDate: Sat Mar 12 13:23:37 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 716e27cbebadbc93ee7d2c550503768b24a0a838
Author: Xiang Xiao
AuthorDate: Sat Mar 12 12:23:22 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9c1fc8da4e97cdb6e57cfeb3b5c9a664962d0040
Author: Xiang Xiao
AuthorDate: Sat Mar 12 12:14:11 2022 +0800
pkarashchenko merged pull request #5725:
URL: https://github.com/apache/incubator-nuttx/pull/5725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 19ec0b4fe321448049c3605027697b1fe64f45b9
Author: Xiang Xiao
AuthorDate: Sat Mar 12 12:39:09 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7028531e74813b6097045bc0910c94115e517c89
Author: Xiang Xiao
AuthorDate: Sat Mar 12 12:26:14 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8b7d08f59ab9953e5db334f48a4dc5dd1208627f
Author: Xiang Xiao
AuthorDate: Sat Mar 12 14:16:00 2022 +0800
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 1a7f49e arch/z[80|16]: Move up_getsp declaration to arch.h
new 9c1fc8d net: Remove net_lockini
pkarashchenko merged pull request #5726:
URL: https://github.com/apache/incubator-nuttx/pull/5726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1a7f49e arch/z[80|16]: Move up_
xiaoxiang781216 opened a new pull request #5727:
URL: https://github.com/apache/incubator-nuttx/pull/5727
## Summary
to follow other arch's implementation
## Impact
Minor, code refactor
## Testing
--
This is an automated message from the Apache Git Service.
To
xiaoxiang781216 commented on pull request #5725:
URL: https://github.com/apache/incubator-nuttx/pull/5725#issuecomment-1065903258
Done, @pkarashchenko .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoxiang781216 commented on a change in pull request #5721:
URL: https://github.com/apache/incubator-nuttx/pull/5721#discussion_r825314176
##
File path: mm/iob/iob_initialize.c
##
@@ -95,54 +95,46 @@ sem_t g_qentry_sem; /* Counts free I/O buffer queue
containers */
xiaoxiang781216 opened a new pull request #5726:
URL: https://github.com/apache/incubator-nuttx/pull/5726
## Summary
Follow other arch
## Impact
Minor
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
pkarashchenko commented on a change in pull request #5721:
URL: https://github.com/apache/incubator-nuttx/pull/5721#discussion_r825310381
##
File path: mm/iob/iob_initialize.c
##
@@ -95,54 +95,46 @@ sem_t g_qentry_sem; /* Counts free I/O buffer queue
containers */
v
pkarashchenko commented on pull request #5725:
URL: https://github.com/apache/incubator-nuttx/pull/5725#issuecomment-1065893814
Please add `const` to `ip` parameter of `void igmp_removemcastmac(FAR struct
net_driver_s *dev, FAR in_addr_t *ip)` and `static void igmp_mcastmac(in_addr_t
*ip,
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from d7364a6 esp32s3-devkit: Enable RT-Timer on board bringup
add e8213b9 tools: define BOARD_COMMON_DI
xiaoxiang781216 merged pull request #5715:
URL: https://github.com/apache/incubator-nuttx/pull/5715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
xiaoxiang781216 commented on pull request #5725:
URL: https://github.com/apache/incubator-nuttx/pull/5725#issuecomment-1065886718
> Maybe we can remove
>
> ```
> #define sq_init(q) \
> do \
> { \
> (q)->head = NULL; \
> (q)->tail = NULL; \
> } \
xiaoxiang781216 commented on a change in pull request #5725:
URL: https://github.com/apache/incubator-nuttx/pull/5725#discussion_r825304161
##
File path: net/utils/net_lock.c
##
@@ -49,9 +49,9 @@
* Private Data
***
pkarashchenko commented on a change in pull request #5725:
URL: https://github.com/apache/incubator-nuttx/pull/5725#discussion_r825303147
##
File path: net/utils/net_lock.c
##
@@ -49,9 +49,9 @@
* Private Data
*
pkarashchenko merged pull request #5723:
URL: https://github.com/apache/incubator-nuttx/pull/5723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 86b18bd xtensa/esp32s3: Move code documentation to the correct place
add 7ede285 xtensa/esp32s
gustavonihei commented on a change in pull request #5723:
URL: https://github.com/apache/incubator-nuttx/pull/5723#discussion_r825292270
##
File path: arch/xtensa/src/esp32s3/esp32s3_rt_timer.h
##
@@ -0,0 +1,251 @@
+/*
pkarashchenko commented on a change in pull request #5723:
URL: https://github.com/apache/incubator-nuttx/pull/5723#discussion_r825292087
##
File path: arch/xtensa/src/esp32s3/esp32s3_rt_timer.h
##
@@ -0,0 +1,251 @@
+/
90 matches
Mail list logo