juniskane commented on pull request #4580:
URL: https://github.com/apache/incubator-nuttx/pull/4580#issuecomment-924622667
Tested this with few of my projects that use CONFIG_SYSLOG_BUFFER. Works and
change looks good to me.
--
This is an automated message from the Apache Git Service.
To
juniskane commented on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-924621898
I tested PR #4580 and it fixes this issue for me. My defconfig has
CONFIG_SYSLOG_BUFFER, so root cause was within this syslog internal buffering,
not related to public
xiaoxiang781216 commented on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-924557189
@a-lunev but my change make the fail path more simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiaoxiang781216 opened a new pull request #4591:
URL: https://github.com/apache/incubator-nuttx/pull/4591
## Summary
since the caller already hold the net lock before
## Impact
No, remove the redundant lock/unlock
## Testing
--
This is an automated message from
yamt commented on pull request #4590:
URL: https://github.com/apache/incubator-nuttx/pull/4590#issuecomment-924531649
what's the motivation of the change? make the code look neater?
a downside of this kind of changes is that it can introduce unnecessary
differences among implementati
xiaoxiang781216 commented on pull request #4590:
URL: https://github.com/apache/incubator-nuttx/pull/4590#issuecomment-924530993
I thank we can ignore the style warning in these patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gustavonihei commented on pull request #4590:
URL: https://github.com/apache/incubator-nuttx/pull/4590#issuecomment-924524033
> @gustavonihei do you plan to apply the same change to other arch(e.g. arm,
sim...)?
I think it is important to consider those other archs, but not on this P
xiaoxiang781216 merged pull request #4589:
URL: https://github.com/apache/incubator-nuttx/pull/4589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 5e19ebb818056f3433f7501a819673b85c9c6ea8
Author: David Sidrane
AuthorDate: Fri Sep 17 06:35:00 2021 -0700
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 0504e1d esp32-devkitc/wifinsh: Adds missing dependency on defconfig
new d5e306e stm32:Etablish dev
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d5e306e6f300cda9984bf03222a8ff36134b3213
Author: David Sidrane
AuthorDate: Thu Sep 16 10:43:59 2021 -0700
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a8d5f21f8196c56c661adcbb7767cfa2a892fa5f
Author: David Sidrane
AuthorDate: Fri Sep 17 06:35:49 2021 -0700
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit a9ff808dd1acd55f7c76644d391d3da21973badd
Author: David Sidrane
AuthorDate: Tue Sep 21 11:11:23 2021 -0700
xiaoxiang781216 commented on pull request #4590:
URL: https://github.com/apache/incubator-nuttx/pull/4590#issuecomment-924506830
@gustavonihei do you plan to apply the same change to other arch(e.g. arm,
sim...)?
--
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new f13cd55 Publishing web
gustavonihei commented on pull request #4590:
URL: https://github.com/apache/incubator-nuttx/pull/4590#issuecomment-924461785
Please, ignore the nxstyle errors due to mixed case on the ESP32-C3 BLE
adapter.
```
Error:
/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-
gustavonihei opened a new pull request #4590:
URL: https://github.com/apache/incubator-nuttx/pull/4590
## Summary
This PR intends to remove all references to the FAR and CODE qualifiers from
Xtensa and RISC-V files.
`FAR` and `CODE` are defined to nothing on both architectures.
saramonteiro commented on pull request #4585:
URL: https://github.com/apache/incubator-nuttx/pull/4585#issuecomment-924433163
FYI: Ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
davids5 commented on pull request #4589:
URL: https://github.com/apache/incubator-nuttx/pull/4589#issuecomment-924321643
All: You may want to review the order of operations on the GPIO code for the
SoC you work on, I think this may systemic.
--
This is an automated message from the Apach
davids5 opened a new pull request #4589:
URL: https://github.com/apache/incubator-nuttx/pull/4589
## Summary
The PR fixes stm32xx GPIO glitches from GPIO configuration with bad order of
operations
When I2C was initialized the SDA and SCL lines would glitch low. The Bosch
BMM1
a-lunev commented on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-924287019
> > @xiaoxiang781216 I tried to find if changing dev->d_flags is
synchronized to net_lock() anywhere. It looks like dev->d_flags can be modified
(e.g. by psock_ioctl())
a-lunev edited a comment on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-924272301
> @xiaoxiang781216 I tried to find if changing dev->d_flags is synchronized
to net_lock() anywhere. It looks like dev->d_flags can be modified (e.g. by
psock_ioct
a-lunev edited a comment on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-924272301
> @xiaoxiang781216 I tried to find if changing dev->d_flags is synchronized
to net_lock() anywhere. It looks like dev->d_flags can be modified (e.g. by
psock_ioct
a-lunev commented on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-924272301
> @xiaoxiang781216 I tried to find if changing dev->d_flags is synchronized
to net_lock() anywhere. It looks like dev->d_flags can be modified (e.g. by
psock_ioctl()) as
acassis merged pull request #4588:
URL: https://github.com/apache/incubator-nuttx/pull/4588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 0504e1d esp32-devkitc/wifinsh: Adds m
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from fc12d68 risc-v/esp32-c3: Group static variables into a struct and
prevent an unitialized thread to be del
davids5 merged pull request #4578:
URL: https://github.com/apache/incubator-nuttx/pull/4578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
saramonteiro opened a new pull request #4588:
URL: https://github.com/apache/incubator-nuttx/pull/4588
## Summary
This is a short PR only to add a missing config to the wifinsh defconfig.
## Impact
Now the .config is properly generated with all the required configs and t
Ouss4 merged pull request #4584:
URL: https://github.com/apache/incubator-nuttx/pull/4584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new fc12d68 risc-v/esp32-c3: Group st
This is an automated email from the ASF dual-hosted git repository.
sara pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7edb39f880aa3ad529b2009bf6c7edae9c4b78a9
Author: Alan C. Assis
AuthorDate: Wed Sep 15 15:22:51 2021 -0300
bo
This is an automated email from the ASF dual-hosted git repository.
sara pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 35824b4 Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet: make driver
compile for teensy 4.1 (link detection nee
This is an automated email from the ASF dual-hosted git repository.
sara pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f9b322567cc4fa7eb6b0ebf4908af75648909091
Author: Alan C. Assis
AuthorDate: Wed Sep 15 15:35:22 2021 -0300
bo
saramonteiro merged pull request #4563:
URL: https://github.com/apache/incubator-nuttx/pull/4563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
acassis merged pull request #4583:
URL: https://github.com/apache/incubator-nuttx/pull/4583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 35824b4 Added CONFIG_ETH0_PHY_DP83825
saramonteiro opened a new pull request #4587:
URL: https://github.com/apache/incubator-nuttx/pull/4587
## Summary
This PR adds the freerun timer wrapper.
## Impact
From now on freerun API can be used in the board logic of ESP32-S2 for the
initialization of some external
jarivanewijk commented on pull request #4578:
URL: https://github.com/apache/incubator-nuttx/pull/4578#issuecomment-923964178
>
>
> @jarivanewijk - Minor change needed
Thanks @davids5. I made the requested changes. Also made the same change to
the UCANS32K146 board.
--
Thi
acassis merged pull request #4581:
URL: https://github.com/apache/incubator-nuttx/pull/4581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 0aa4f07 libc/sched/sched_backtrace.c: Include unistd.h to avoid
warning about getpid function.
add f
saramonteiro opened a new pull request #4586:
URL: https://github.com/apache/incubator-nuttx/pull/4586
## Summary
This PR adds support for oneshot device driver and wrapper for ESP32-S2.
## Impact
New feature.
## Test
Oneshot example.
--
This is an autom
saramonteiro opened a new pull request #4585:
URL: https://github.com/apache/incubator-nuttx/pull/4585
## Summary
Espressif newer chips come with systimer peripheral which is suitable for OS
tick generation and timekeeping.
RT timer is a component that allow multiple clients (like
saramonteiro opened a new pull request #4584:
URL: https://github.com/apache/incubator-nuttx/pull/4584
## Summary
Fix on esp32c3_rt_timer.c: Group static variables into a struct and prevent
an uninitialized thread to be deleted.
## Impact
Organization.
Prevent a pot
gustavonihei merged pull request #4582:
URL: https://github.com/apache/incubator-nuttx/pull/4582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 9f4d7e4767c0af920a30e75dfceb820ec0cd2e52
Author: Abdelatif Guettouche
AuthorDate: Tue Sep 21 13:08:20 202
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 1692aa7 drivers/syslog: Ensure the buffer zero terminate
new 9f4d7e4 xtensa_dumpstate.c: Fix th
This is an automated email from the ASF dual-hosted git repository.
gustavonihei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 0aa4f07e93daa64889833b1ae20dca659985bae7
Author: Abdelatif Guettouche
AuthorDate: Tue Sep 21 13:08:41 202
acassis merged pull request #4580:
URL: https://github.com/apache/incubator-nuttx/pull/4580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commit
pbrier opened a new pull request #4583:
URL: https://github.com/apache/incubator-nuttx/pull/4583
Added CONFIG_ETH0_PHY_DP83825I to imxrt_enet (used in teensy 4.1, link
detection needs more checks to see if it works as expected)
## Summary
This adds the PHY used on the teensy 4
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4ac7945 net/devif/devif_callback.c: made the connection event list
doubly linked. The resulting time comp
pbrier closed pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
pbrier commented on pull request #4577:
URL: https://github.com/apache/incubator-nuttx/pull/4577#issuecomment-923898196
Abandoning this one for individual PRs on the different issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
xiaoxiang781216 edited a comment on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-923880880
> Seems OK to me on the surface.
>
> The function's docstring says assumptions: this function is called with
the network locked. Is that a stale com
xiaoxiang781216 commented on pull request #4575:
URL: https://github.com/apache/incubator-nuttx/pull/4575#issuecomment-923880880
> Seems OK to me on the surface.
>
> The function's docstring says assumptions: this function is called with
the network locked. Is that a stale comment?
Ouss4 opened a new pull request #4582:
URL: https://github.com/apache/incubator-nuttx/pull/4582
## Summary
- Commit 1: Fix the name of the TCB variable, `rtcb` was used instead of
`tcb`
- Commit 2: Include "unistd.h" to avoid an implicit declaration warning.
## Impact
Xtensa dum
gustavonihei edited a comment on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923865313
> According to the [syslog
documentation](https://pubs.opengroup.org/onlinepubs/007904975/functions/syslog.html):
>
> > The message body is generated f
gustavonihei commented on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923865313
> According to the [syslog
documentation](https://pubs.opengroup.org/onlinepubs/007904975/functions/syslog.html):
>
> > The message body is generated from the
xiaoxiang781216 merged pull request #4579:
URL: https://github.com/apache/incubator-nuttx/pull/4579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4ac7945 net/devif/devif_callback.c:
gustavonihei edited a comment on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923858972
According to the [syslog
documentation](https://pubs.opengroup.org/onlinepubs/007904975/functions/syslog.html):
> The message body is generated from th
gustavonihei commented on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923858972
According to the [syslog
documentation](https://pubs.opengroup.org/onlinepubs/007904975/functions/syslog.html):
> The message body is generated from the messa
pbrier opened a new pull request #4581:
URL: https://github.com/apache/incubator-nuttx/pull/4581
## Summary
Fixed compilation of the CANBUS driver for imxrt when the
CONFIG_NETDEV_CAN_BITRATE_IOCTL was set
## Impact
None expected.
## Testing
Make a config where yo
xiaoxiang781216 edited a comment on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923851046
> The commit
[ca62341](https://github.com/apache/incubator-nuttx/commit/ca62341c931a2ee2536aea9d8f598f4e9f11f833)
is incorrect and should be reverted. Not
xiaoxiang781216 commented on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923851046
> The commit
[ca62341](https://github.com/apache/incubator-nuttx/commit/ca62341c931a2ee2536aea9d8f598f4e9f11f833)
is incorrect and should be reverted. Nothing gu
xiaoxiang781216 opened a new pull request #4580:
URL: https://github.com/apache/incubator-nuttx/pull/4580
## Summary
This patch fix the regression by:
```
commit 174b2403258cbf0e063ac389beeedcd09b8a0b1a
Author: Xiang Xiao
Date: Fri Sep 17 11:56:21 2021 +0800
driv
juniskane commented on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923830708
The commit ca62341c931a2ee2 is incorrect and should be reverted. Nothing
guarantees that the buffer is NUL-terminated. Nothing guarantees there won't be
multiple NUL-t
67 matches
Mail list logo
