[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3757: riscv: Add inline IRQ process functions

donghengqaz commented on a change in pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#discussion_r647095813 ## File path: arch/risc-v/include/irq.h ## @@ -64,12 +64,70 @@ extern "C" #define EXTERN extern #endif +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3757: riscv: Add inline IRQ process functions

xiaoxiang781216 commented on a change in pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#discussion_r647088301 ## File path: arch/risc-v/include/irq.h ## @@ -64,12 +64,70 @@ extern "C" #define EXTERN extern #endif +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3757: riscv: Add inline IRQ process functions

xiaoxiang781216 commented on a change in pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#discussion_r647088301 ## File path: arch/risc-v/include/irq.h ## @@ -64,12 +64,70 @@ extern "C" #define EXTERN extern #endif +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3757: riscv: Add inline IRQ process functions

xiaoxiang781216 commented on a change in pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#discussion_r647088301 ## File path: arch/risc-v/include/irq.h ## @@ -64,12 +64,70 @@ extern "C" #define EXTERN extern #endif +/*

[incubator-nuttx-apps] branch master updated: testing: getprime: Fix to wait for all the threads to finish

This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 068e187 testing: getprime: Fix to

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #751: testing: getprime: Fix to wait for all the threads to finish

patacongo merged pull request #751: URL: https://github.com/apache/incubator-nuttx-apps/pull/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3757: riscv: Add inline IRQ process functions

donghengqaz commented on a change in pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#discussion_r647082811 ## File path: arch/risc-v/include/irq.h ## @@ -64,12 +64,70 @@ extern "C" #define EXTERN extern #endif +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3757: riscv: Add inline IRQ process functions

xiaoxiang781216 commented on a change in pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#discussion_r647081385 ## File path: arch/risc-v/include/irq.h ## @@ -64,12 +64,70 @@ extern "C" #define EXTERN extern #endif +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3755: net/icmp: icmp bug fix and enhancement

xiaoxiang781216 merged pull request #3755: URL: https://github.com/apache/incubator-nuttx/pull/3755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[incubator-nuttx] branch master updated (9aaeaef -> 39245f6)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 9aaeaef TLS: Correct handling of returned error values. add b0ac97a net/icmp: fix invalid conditio

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #750: Makefile: update licenses to Apache

xiaoxiang781216 merged pull request #750: URL: https://github.com/apache/incubator-nuttx-apps/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about t

[incubator-nuttx-apps] branch master updated (f961a6c -> e9f1ce7)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from f961a6c iperf: Do not busy loop on a connection closed by the peer add 3170ca0 builtin: updat

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #751: testing: getprime: Fix to wait for all the threads to finish

masayuki2009 opened a new pull request #751: URL: https://github.com/apache/incubator-nuttx-apps/pull/751 ## Summary - I noticed that sometimes getprime causes ASSERT in tls_getset.c - This commit fixes this issue. ## Impact - None ## Testing - Tested wi

[GitHub] [incubator-nuttx] gustavonihei merged pull request #3867: TLS: Correct handling of returned error values.

gustavonihei merged pull request #3867: URL: https://github.com/apache/incubator-nuttx/pull/3867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[incubator-nuttx] branch master updated (3859031 -> 9aaeaef)

This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3859031 Fix ht16k33 driver to support multi-modules add 9aaeaef TLS: Correct handling of return

[incubator-nuttx-website] branch asf-site updated: Publishing web: 19fb3d010436bab437da6af739a765c6832761ed docs: 3859031a6bfdc987b6704f5460762e91e8d84b8e

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 8ae2ea3 Publishing web

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3865: Fix tcp seq wrap around issues

yamt commented on a change in pull request #3865: URL: https://github.com/apache/incubator-nuttx/pull/3865#discussion_r646988979 ## File path: net/tcp/tcp.h ## @@ -86,6 +86,15 @@ # endif #endif +/* 32-bit modular arithmetics for tcp sequence numbers */ + +#define TCP_SEQ_L

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3865: Fix tcp seq wrap around issues

yamt commented on a change in pull request #3865: URL: https://github.com/apache/incubator-nuttx/pull/3865#discussion_r646988874 ## File path: net/tcp/tcp.h ## @@ -86,6 +86,15 @@ # endif #endif +/* 32-bit modular arithmetics for tcp sequence numbers */ + +#define TCP_SEQ_L

[GitHub] [incubator-nuttx] patacongo commented on pull request #3867: TLS: Correct handling of returned error values.

patacongo commented on pull request #3867: URL: https://github.com/apache/incubator-nuttx/pull/3867#issuecomment-856269793 @no1wudi Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx] patacongo opened a new pull request #3867: TLS: Correct handling of returned error values.

patacongo opened a new pull request #3867: URL: https://github.com/apache/incubator-nuttx/pull/3867 ## Summary I note two problems in handling of the return error values in PR #3858: 1. In KERNEL mode, the error return value of _SEM_WAIT() will be a negated errno value; in all

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3848: Syslog file rotations number is configurable.

gustavonihei commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646936686 ## File path: drivers/syslog/Kconfig ## @@ -273,23 +273,26 @@ menuconfig SYSLOG_FILE if SYSLOG_FILE -config SYSLOG_FILE_ROTATE - b

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3848: Syslog file rotations number is configurable.

gustavonihei commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646936686 ## File path: drivers/syslog/Kconfig ## @@ -273,23 +273,26 @@ menuconfig SYSLOG_FILE if SYSLOG_FILE -config SYSLOG_FILE_ROTATE - b

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646933162 ## File path: drivers/syslog/Kconfig ## @@ -273,23 +273,26 @@ menuconfig SYSLOG_FILE if SYSLOG_FILE -config SYSLOG_FILE_ROTATE - bool "

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646931297 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -85,28 +86,44 @@ static void log_rotate(FAR const char *log_file) return; }

[GitHub] [incubator-nuttx] antmerlino commented on a change in pull request #3755: net/icmp: icmp bug fix and enhancement

antmerlino commented on a change in pull request #3755: URL: https://github.com/apache/incubator-nuttx/pull/3755#discussion_r646891542 ## File path: net/icmp/icmp_recvmsg.c ## @@ -181,7 +181,8 @@ static uint16_t recvfrom_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] jlaitine commented on pull request #3787: drivers/spi: Add SPI Slave character device driver

jlaitine commented on pull request #3787: URL: https://github.com/apache/incubator-nuttx/pull/3787#issuecomment-856171541 Hi! That slave works only as a receiver, and unfortunately I don't currently have any stm32h7 hw to actually test it on. So I don't think that I will continue on

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #3865: Fix tcp seq wrap around issues

hartmannathan commented on a change in pull request #3865: URL: https://github.com/apache/incubator-nuttx/pull/3865#discussion_r646830480 ## File path: net/tcp/tcp.h ## @@ -86,6 +86,15 @@ # endif #endif +/* 32-bit modular arithmetics for tcp sequence numbers */ + +#define

[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request #750: Makefile: update licenses to Apache

jerpelea opened a new pull request #750: URL: https://github.com/apache/incubator-nuttx-apps/pull/750 ## Summary We received SGA or ICLA from authors and we can update the licenses ## Impact LICENSE ## Testing NONE -- This is an automated message from the Apache

[GitHub] [incubator-nuttx-apps] btashton commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

btashton commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646813276 ## File path: math/libtommath/Makefile ## @@ -0,0 +1,112 @@ + +#

[GitHub] [incubator-nuttx-apps] btashton commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

btashton commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646809281 ## File path: crypto/libtomcrypt/Makefile ## @@ -0,0 +1,224 @@ +

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

Ouss4 commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646806645 ## File path: crypto/libtomcrypt/Makefile ## @@ -0,0 +1,224 @@ + +#

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

gustavonihei commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646789216 ## File path: crypto/libtomcrypt/Makefile ## @@ -0,0 +1,224 @@ +#

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

gustavonihei commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646784839 ## File path: crypto/libtomcrypt/Kconfig ## @@ -0,0 +1,57 @@ +# +# For a description of the syntax of this configuration file, +# see the

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

Ouss4 commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646736437 ## File path: math/libtommath/Makefile ## @@ -0,0 +1,112 @@ + +# app

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

Ouss4 commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646739091 ## File path: math/libtommath/Makefile ## @@ -0,0 +1,112 @@ + +# app

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

Ouss4 commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646736437 ## File path: math/libtommath/Makefile ## @@ -0,0 +1,112 @@ + +# app

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

Ouss4 commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646726142 ## File path: crypto/libtomcrypt/Makefile ## @@ -0,0 +1,224 @@ + +#

[GitHub] [incubator-nuttx-apps] btashton commented on pull request #749: Add initial support libtommath and libtomcrypt libraries

btashton commented on pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#issuecomment-856053256 > @btashton did you get Dropbear working on NuttX? I will provide a separate PR for it. But yes it is partially working in the sim. -- This is an automate

[GitHub] [incubator-nuttx-apps] btashton commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

btashton commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646718713 ## File path: crypto/libtomcrypt/Makefile ## @@ -0,0 +1,224 @@ +

[GitHub] [incubator-nuttx-apps] acassis commented on pull request #749: Add initial support libtommath and libtomcrypt libraries

acassis commented on pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#issuecomment-856052194 @btashton did you get Dropbear working on NuttX? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx-apps] btashton commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

btashton commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646715718 ## File path: crypto/libtomcrypt/digit-bit.patch ## @@ -0,0 +1,11 @@ +--- libtomcrypt/src/math/ltm_desc.c2018-07-01 13:49:01.0 -0

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #749: Add initial support libtommath and libtomcrypt libraries

xiaoxiang781216 commented on a change in pull request #749: URL: https://github.com/apache/incubator-nuttx-apps/pull/749#discussion_r646697512 ## File path: crypto/libtomcrypt/Kconfig ## @@ -0,0 +1,57 @@ +# +# For a description of the syntax of this configuration file, +# see

[incubator-nuttx-apps] branch master updated (1140beb -> f961a6c)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 1140beb Fix nxstyle warning add f961a6c iperf: Do not busy loop on a connection closed by the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #748: iperf: Do not busy loop on a connection closed by the peer

xiaoxiang781216 merged pull request #748: URL: https://github.com/apache/incubator-nuttx-apps/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about t

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3834: RFQ: progmem.h: Modify interface to avoid terms like page, sector, and block, as these terms are used interchangea

gustavonihei commented on a change in pull request #3834: URL: https://github.com/apache/incubator-nuttx/pull/3834#discussion_r646692432 ## File path: include/nuttx/progmem.h ## @@ -49,96 +49,127 @@ extern "C" * Public Functions Definitions *

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3834: RFQ: progmem.h: Modify interface to avoid terms like page, sector, and block, as these terms are used interchangea

gustavonihei commented on a change in pull request #3834: URL: https://github.com/apache/incubator-nuttx/pull/3834#discussion_r646692432 ## File path: include/nuttx/progmem.h ## @@ -49,96 +49,127 @@ extern "C" * Public Functions Definitions *

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3848: Syslog file rotations number is configurable.

xiaoxiang781216 commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646688459 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -85,28 +86,44 @@ static void log_rotate(FAR const char *log_file) return;

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3834: RFQ: progmem.h: Modify interface to avoid terms like page, sector, and block, as these terms are used interchangea

gustavonihei commented on a change in pull request #3834: URL: https://github.com/apache/incubator-nuttx/pull/3834#discussion_r646682929 ## File path: include/nuttx/progmem.h ## @@ -49,96 +49,127 @@ extern "C" * Public Functions Definitions *

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3834: RFQ: progmem.h: Modify interface to avoid terms like page, sector, and block, as these terms are used interchangea

gustavonihei commented on a change in pull request #3834: URL: https://github.com/apache/incubator-nuttx/pull/3834#discussion_r646675017 ## File path: include/nuttx/progmem.h ## @@ -49,96 +49,127 @@ extern "C" * Public Functions Definitions *

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646676300 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -85,28 +86,44 @@ static void log_rotate(FAR const char *log_file) return; }

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3834: RFQ: progmem.h: Modify interface to avoid terms like page, sector, and block, as these terms are used interchangea

gustavonihei commented on a change in pull request #3834: URL: https://github.com/apache/incubator-nuttx/pull/3834#discussion_r646675017 ## File path: include/nuttx/progmem.h ## @@ -49,96 +49,127 @@ extern "C" * Public Functions Definitions *

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3848: Syslog file rotations number is configurable.

gustavonihei commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646668768 ## File path: drivers/syslog/Kconfig ## @@ -273,23 +273,26 @@ menuconfig SYSLOG_FILE if SYSLOG_FILE -config SYSLOG_FILE_ROTATE - b

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3848: Syslog file rotations number is configurable.

xiaoxiang781216 commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646656255 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -85,28 +86,44 @@ static void log_rotate(FAR const char *log_file) return;

[GitHub] [incubator-nuttx] zzmxoo closed pull request #3866: Merge pull request #1 from apache/master

zzmxoo closed pull request #3866: URL: https://github.com/apache/incubator-nuttx/pull/3866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-nuttx] zzmxoo opened a new pull request #3866: Merge pull request #1 from apache/master

zzmxoo opened a new pull request #3866: URL: https://github.com/apache/incubator-nuttx/pull/3866 xx ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] patacongo commented on pull request #3626: libc: Move pthread stuff to userspace

patacongo commented on pull request #3626: URL: https://github.com/apache/incubator-nuttx/pull/3626#issuecomment-855882718 > For ELF binary, we have three case: > > 1. ELF binary in FLAT build, it simplify to the direct function call > > 2. ELF binary in PROTECTED build

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #3794: risc-v/esp32c3: Support ESP32-C3 RTC driver

saramonteiro commented on a change in pull request #3794: URL: https://github.com/apache/incubator-nuttx/pull/3794#discussion_r646530701 ## File path: arch/risc-v/src/esp32c3/esp32c3_rtc.c ## @@ -2135,3 +2246,415 @@ void IRAM_ATTR esp32c3_rtc_sleep_set_wakeup_time(uint64_t t)

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #3794: risc-v/esp32c3: Support ESP32-C3 RTC driver

saramonteiro commented on a change in pull request #3794: URL: https://github.com/apache/incubator-nuttx/pull/3794#discussion_r646529460 ## File path: arch/risc-v/src/esp32c3/esp32c3_rtc.c ## @@ -2135,3 +2246,415 @@ void IRAM_ATTR esp32c3_rtc_sleep_set_wakeup_time(uint64_t t)

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #3794: risc-v/esp32c3: Support ESP32-C3 RTC driver

saramonteiro commented on a change in pull request #3794: URL: https://github.com/apache/incubator-nuttx/pull/3794#discussion_r646528828 ## File path: arch/risc-v/src/esp32c3/esp32c3_rtc.c ## @@ -2135,3 +2246,415 @@ void IRAM_ATTR esp32c3_rtc_sleep_set_wakeup_time(uint64_t t)

[GitHub] [incubator-nuttx] AlexanderVasiljev edited a comment on pull request #3836: Make: -nostartfiles -nodefaultlibs are not flags of LD but flags of GCC

AlexanderVasiljev edited a comment on pull request #3836: URL: https://github.com/apache/incubator-nuttx/pull/3836#issuecomment-855679790 @gustavonihei Thank you! Now I am stuck on spresense:nsh_trace. spresense:nsh - OK spresense:nsh_trace - FAILED ``` arm-no

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646484047 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -58,25 +60,25 @@ FAR static struct syslog_channel_s *g_syslog_file_channel; * Private Fu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3848: Syslog file rotations number is configurable.

xiaoxiang781216 commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646471613 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -58,25 +60,25 @@ FAR static struct syslog_channel_s *g_syslog_file_channel; * Pr

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646441882 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -58,25 +60,28 @@ FAR static struct syslog_channel_s *g_syslog_file_channel; * Private Fu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3757: riscv: Add inline IRQ process functions

xiaoxiang781216 commented on pull request #3757: URL: https://github.com/apache/incubator-nuttx/pull/3757#issuecomment-855784417 Yes, if all implementation is same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3848: Syslog file rotations number is configurable.

xiaoxiang781216 commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646436854 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -58,25 +60,28 @@ FAR static struct syslog_channel_s *g_syslog_file_channel; * Pr

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646382028 ## File path: drivers/syslog/Kconfig ## @@ -286,6 +286,13 @@ config SYSLOG_FILE_ROTATE This option is useful to ensure that log fi

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646381868 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -85,28 +89,44 @@ static void log_rotate(FAR const char *log_file) return; }

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3848: Syslog file rotations number is configurable.

fjpanag commented on a change in pull request #3848: URL: https://github.com/apache/incubator-nuttx/pull/3848#discussion_r646368271 ## File path: drivers/syslog/syslog_filechannel.c ## @@ -85,28 +89,44 @@ static void log_rotate(FAR const char *log_file) return; }

[GitHub] [incubator-nuttx] yamt opened a new pull request #3865: Fix tcp seq wraparoud issues

yamt opened a new pull request #3865: URL: https://github.com/apache/incubator-nuttx/pull/3865 ## Summary ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on pull request #3836: Make: -nostartfiles -nodefaultlibs are not flags of LD but flags of GCC

AlexanderVasiljev commented on pull request #3836: URL: https://github.com/apache/incubator-nuttx/pull/3836#issuecomment-855679790 @gustavonihei Thank you! Now I am stuck on spresense:nsh_trace. spresense:nsh - OK spresense:nsh_trace - FAILED ``` arm-none-eabi

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #3755: net/icmp: icmp bug fix and enhancement

anchao commented on a change in pull request #3755: URL: https://github.com/apache/incubator-nuttx/pull/3755#discussion_r646338066 ## File path: net/icmp/icmp_recvmsg.c ## @@ -181,7 +181,8 @@ static uint16_t recvfrom_eventhandler(FAR struct net_driver_s *dev, /* I